alexfh accepted this revision.
alexfh added a comment.
LG with a couple of nits.
================
Comment at:
clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230
+ explicit FunctionASTVisitor(const bool IgnoreMacros)
+ : IgnoreMacros(IgnoreMacros){};
+
----------------
nit: Please remove the semicolon and clang-format.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31
+ any macro arguments are ignored, even if they should count to the
complexity.
+ As this might change in the future, this option isn't guarantueed to be
+ forward-compatible. Default is `false`.
----------------
typo: "guarantueed" -> "guaranteed".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98070/new/
https://reviews.llvm.org/D98070
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
