sdesmalen added a comment.
Thanks for taking time from your weekend to look into this @tambre, much
appreciated!
================
Comment at: clang/lib/Sema/SemaDecl.cpp:10953-10967
if (unsigned BuiltinID = NewFD->getBuiltinID()) {
ASTContext::GetBuiltinTypeError Error;
LookupNecessaryTypesForBuiltin(S, BuiltinID);
QualType T = Context.GetBuiltinType(BuiltinID, Error);
// If the type of the builtin differs only in its exception
// specification, that's OK.
// FIXME: If the types do differ in this way, it would be better to
----------------
tambre wrote:
> This whole block is unnecessary since D77491 and should've been removed, but
> seems I missed it. Reverting/forgetting builtins was problematic and the
> attribute-based approach solved those deficiencies.
>
> Delete this whole block and also remove `forgetBuiltin()`. The
> builtin-related code in `ActOnFunctionDeclarator()` handles everything
> necessary. No tests break and the SVE ones will pass. :)
Awesome! I had indeed noticed commenting it out didn't fail any tests and
wondered if removing it entirely was the way to go. Good to hear you confirming
that!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100046/new/
https://reviews.llvm.org/D100046
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
