[PATCH] D100129: Tiny format fix

bruno accepted this revision. bruno added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100129/new/ https://reviews.llvm.org/D100129 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added a comment. In D75844#2677457 , @brooksmoses wrote: > FWIW, this now causes Clang to produce an error on this code, when it didn't > before: > > using namespace::foo __attribute__((deprecated("message"))); > > I discussed this with Ri

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman added a comment. In D4#2677566 , @rnk wrote: > IMO it's best to avoid adding fields to DICompileUnit if at all possible. > It's the "god object" / "katamari damacy" of module debug info. Is there > something about the IR module that indicates

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336203. haberman added a comment. - Formatted files with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/include/clang/AST/Expr.h clang/

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman marked 2 inline comments as done. haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:561-568 + for (const auto *A : Attrs) { +if (A->getKind() == attr::MustTail) { + if (!checkMustTailAttr(SubStmt, *A)) { +return SubStmt; + } +

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra created this revision. tra added reviewers: rsmith, arphaman. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. The original intent of enforcing exact match between `apply_to` and the attribute's was to `ensure that the user will know wha

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra updated this revision to Diff 336212. tra added a comment. Updated Sema/pragma-attribute-strict-subjects.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136 Files: clang/lib/Sema/SemaAttr.cpp clang/

[clang] f66e05a - Include `count` in AppleClang toolchains.

Author: Dan Liew Date: 2021-04-08T14:00:29-07:00 New Revision: f66e05a720f74409790bdede308380909f2ecd86 URL: https://github.com/llvm/llvm-project/commit/f66e05a720f74409790bdede308380909f2ecd86 DIFF: https://github.com/llvm/llvm-project/commit/f66e05a720f74409790bdede308380909f2ecd86.diff LOG:

[PATCH] D100087: Include `count` in AppleClang toolchains.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf66e05a720f7: Include `count` in AppleClang toolchains. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100087/new/ https://reviews.l

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336223. Holman added a comment. Get PGO info from Module instead of adding new field to debug info. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp Ind

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Do we still need the following tests: - clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp - clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp ? Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {} +templ

[PATCH] D100139: [ifs][elfabi] Merge llvm-ifs/elfabi tools

haowei created this revision. haowei added reviewers: phosek, plotfi, compnerd, mcgrathr. Herald added subscribers: hiraditya, mgorny. haowei requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change merges llvm-elfabi a

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

rnk added a comment. Seems reasonable, but we still need a small IR test. Comment at: llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:807 // TODO: Figure out which other flags need to be set. + if (MMI->getModule()->getProfileSummary(/* IsCS */ false) != nullptr) { +Flag

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:896 + attr::SubjectMatchRule MatchRule = attr::SubjectMatchRule(Rule.first); + if (auto ParentRule = getParentAttrMatcherRule(MatchRule)) { +if (llvm::any_of(StrictSubjectMatchRuleSet, ---

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM but you should wait a bit for @pcc or @eugenis to have a chance to to review this as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

brooksmoses added a comment. As a heads up, I'm seeing segfaults on internal code as a result of this change, as well as errors in Eigen's unalignedassert.cpp test (specifically, this line asserts: https://github.com/madlib/eigen/blob/master/test/unalignedassert.cpp#L151). Repository: rG LL

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

lebedev.ri added a comment. In D99790#2677917 , @brooksmoses wrote: > As a heads up, I'm seeing segfaults on internal code as a result of this > change, as well as errors in Eigen's unalignedassert.cpp test (specifically, > this line asserts: > https://

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: compiler-rt/lib/hwasan/hwasan_new_delete.cpp:104 +INTERCEPTOR_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE void operator delete( +void *ptr, std::align_val_t align)NOEXCEPT { + OPERATOR_DELETE_BODY; --

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra updated this revision to Diff 336236. tra added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136 Files: clang/lib/Sema/SemaAttr.cpp clang/test/Parser/pragma-attribute.

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

tra added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:896 + attr::SubjectMatchRule MatchRule = attr::SubjectMatchRule(Rule.first); + if (auto ParentRule = getParentAttrMatcherRule(MatchRule)) { +if (llvm::any_of(StrictSubjectMatchRuleSet, --

[PATCH] D100144: [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

yaxunl created this revision. yaxunl added a reviewer: JonChesterfield. Herald added subscribers: jfb, t-tye, tpr, dstuttard, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D100144 Files: clang/lib/CodeGen/CGBuiltin.cpp c

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

jyknight added a comment. In D99790#2677917 , @brooksmoses wrote: > As a heads up, I'm seeing segfaults on internal code as a result of this > change, as well as errors in Eigen's unalignedassert.cpp test (specifically, > this line asserts: > https://gi

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

smaslov added a comment. > I really don't think this should go in. Here are more arguments for why, I think, this is an useful option in my opinion, in arbitrary order: 1. This was requested by and added for users of Intel Compiler. Having similar option in LLVM would make the two compilers mo

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://reviews.llvm.org/D100136 ___

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

craig.topper added a comment. I think I wouldn't mind if we just didn't emit aligned loads/store instructions for AVX/AVX512 from isel and other places in the compiler in the first place. As noted, if the load gets folded the alignment check doesn't happen. That would reduce the size of the ise

[PATCH] D100144: [AMDGPU] Allow relaxed/consume memory order for atomic inc/dec

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice. Thank you for fixing the oversight. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100144/new/ https://reviews.llvm.org/D100144 ___

[PATCH] D99368: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked an inline comment as done. Closed by commit rGa7b51d8a4fc8: [compiler-rt][hwasan] Add C++17 new/delete operators with alignment (authored by leonardc

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk created this revision. hvdijk added a reviewer: glaubitz. hvdijk added a project: clang. Herald added subscribers: pengfei, dberris. hvdijk requested review of this revision. Herald added a subscriber: cfe-commits. x86_64-linux-gnu and x86_64-linux-gnux32 use different ABIs and objects buil

[PATCH] D100150: [Sanitizers] Add a flag -f[no-]sanitize-merge-traps

rnk created this revision. rnk added reviewers: pcc, phosek, rsmith, zequanwu. Herald added subscribers: jansvoboda11, dexonsmith, dang. rnk requested review of this revision. Herald added a project: clang. Without this flag, enabling optimizations causes clang to emit a single ubsantrap for every

[PATCH] D99565: [X86] Support replacing aligned vector moves with unaligned moves when avx is enabled.

smaslov added a comment. > Sergey, remind me, does icc always emit unaligned loads/stores? Is there any > option to control it? There was a control to emit aligned opcodes, yes, but I don't think anyone ever used it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 2f18108 - [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

Author: Nikita Kniazev Date: 2021-04-09T00:05:36+01:00 New Revision: 2f181086b5cbbe83c4492aa44484a77ed06ec812 URL: https://github.com/llvm/llvm-project/commit/2f181086b5cbbe83c4492aa44484a77ed06ec812 DIFF: https://github.com/llvm/llvm-project/commit/2f181086b5cbbe83c4492aa44484a77ed06ec812.diff

[PATCH] D69218: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-top-level)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f181086b5cb: [ASTMatchers] Add `cxxBaseSpecifier` matcher (non-to

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2828-2829 + "%0 attribute requires that the return value, all parameters, and any " + "temporaries created by the expression are trivially destructible and " + "do not require ARC">; +de

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

Holman updated this revision to Diff 336274. Holman set the repository for this revision to rG LLVM Github Monorepo. Holman added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 Files:

[clang] eb8a28e - DebugInfo: Include inline namespaces in template specialization parameter names

Author: David Blaikie Date: 2021-04-08T17:37:55-07:00 New Revision: eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679 URL: https://github.com/llvm/llvm-project/commit/eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679 DIFF: https://github.com/llvm/llvm-project/commit/eb8a28e2cf033f2bfbfe33a0bd0d9e75a12e2679.diff

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

brooksmoses added a comment. In D99790#2677919 , @lebedev.ri wrote: > In D99790#2677917 , @brooksmoses > wrote: > >> As a heads up, I'm seeing segfaults on internal code as a result of this >> change, as well as e

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = RKSimon wrote: > Using ICLTuning suggests we should still be avoiding

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/X86.td:767 + // Rocketlake + list RKLAdditionalFeatures = [FeatureAES, + FeatureXSAVEC, craig.topper wrote: > FreddyYe wrote: > > craig.topper wrote

[clang] ca55f05 - [clang][SourceManager] Fix -Wparentheses warning (NFC)

Author: Yang Fan Date: 2021-04-09T10:22:56+08:00 New Revision: ca55f0511698e5b64538e02eff9f6b2280282b15 URL: https://github.com/llvm/llvm-project/commit/ca55f0511698e5b64538e02eff9f6b2280282b15 DIFF: https://github.com/llvm/llvm-project/commit/ca55f0511698e5b64538e02eff9f6b2280282b15.diff LOG:

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336295. FreddyYe added a comment. delete FeatureSGX in the backend since there are no IR intrinsics for SGX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files:

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:293-301 +// Empty processor. Include X87 and CMPXCHG8 for backwards compatibility. +{{""}, CK_None, ~0U, FeatureX87 | FeatureCMPXCHG8B}, +// i386-generation processors. +{{"i386"}, CK_i38

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271 "Invalidate Process-Context Identifier">; -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. In D97669#2676826 , @Anastasia wrote: > In D97669#2665865 , @benshi001 wrote: > >> In D97669#2661560 , @Anastasia >> wrote: >> >>> Is `stdio.h` u

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271-273 -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software Guard Extensions">; def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt", "HasCLFLU

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 created this revision. gtt1995 added reviewers: 01alchemist, 0b01. gtt1995 requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Divide the corpus into n parts according to size. Each job executes each corpus in tur

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86.td:271-273 -def FeatureSGX : SubtargetFeature<"sgx", "HasSGX", "true", - "Enable Software Guard Extensions">; def FeatureCLFLUSHOPT : SubtargetFeature<"clflushopt", "

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336301. FreddyYe added a comment. cancel the clang-format in constexpr ProcInfo Processors[] = {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336303. FreddyYe added a comment. revert clang-format and revert deleting FeatureSGX def. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic/Ta

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @craig.topper and @skan , THX for review! I tested that deleting sgx indeed leads to not generating "+sgx" in 'target-features', didn't know before:) '+sgx' is not a recognized feature for this target (ignoring feature) Repository: rG LLVM Github Monorepo CH

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai added a comment. In D97264#2663082 , @rogfer01 wrote: > I was under the impression we didn't want to use class-member access syntax > for vector tuples (see > https://github.com/riscv/rvv-intrinsic-doc/issues/17#issuecomment-628998077 ) > so w

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336310. haberman marked 3 inline comments as done. haberman added a comment. - Refined the implicit constructor skipping code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2828-2829 + "%0 attribute requires that the return value, all parameters, and any " + "temporaries created by the expression are trivially destructible and " + "do not require ARC">; +

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336316. haberman added a comment. - Rename and refine IgnoreElidableImplicitConstructorSingleStep(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/inc

[PATCH] D97264: [RISCV] Define types for Zvlsseg.

HsiangKai updated this revision to Diff 336320. HsiangKai added a comment. Put element types in the macro and use them to create RecordType directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97264/new/ https://reviews.llvm.org/D97264 Files:

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99151/new/ https://reviews.llvm.org/D99151 ___

<    1   2