[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

liaolucy added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c:11 // ASM-NOT: warning -#include +#include riscv_vector_overloaded.h ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

rjmccall added a comment. Is it feasible to outline the initial segment that you don't want to be part of the coroutine, and then have coroutine splitting force that outlined function to be inlined into the ramp function? IIUC, you were saying that the splitting patch was difficult, but maybe

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

rjmccall added a comment. In D99227#2646710 , @lxfind wrote: >> I think you just set `ShouldEmitLifetimeMarkers` correctly in the first >> place instead of adding this as an extra condition to every place that >> considers it, however. > > This was set w

[PATCH] D99238: [DebugInfo] Enable the call site parameter feature by default

djtodoro added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1645 - if (Opts.OptimizationLevel > 0 && Opts.hasReducedDebugInfo() && + if (Opts.hasReducedDebugInfo() && llvm::is_contained(DebugEntryValueArchs, T.getArch())) I am

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder added a comment. I'm gonna continue the conversation here if that's ok, the inline comments are rather cramped and confusing. So, I just double-checked this and `Attrs.Range.getBegin()` returns the location of the first `[`, which is correct and not a problem. `Lexer::getRawToken(Attrs

[PATCH] D99243: [CMake][Fuchsia] Include llvm-lipo

phosek created this revision. phosek added reviewers: leonardchan, haowei. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want to use llvm-lipo for building universal libraries. Repository:

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 332886. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/test/Parser/cxx0x-attributes.cpp

[PATCH] D99188: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6cdb2c0a714: [clang][ASTImporter] Add import of DeducedTemplateSpecializationType. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D991

[clang] f6cdb2c - [clang][ASTImporter] Add import of DeducedTemplateSpecializationType.

Author: Balázs Kéri Date: 2021-03-24T09:43:58+01:00 New Revision: f6cdb2c0a714f8921688de08858f34d8c776f0e6 URL: https://github.com/llvm/llvm-project/commit/f6cdb2c0a714f8921688de08858f34d8c776f0e6 DIFF: https://github.com/llvm/llvm-project/commit/f6cdb2c0a714f8921688de08858f34d8c776f0e6.diff L

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

jhenderson added a comment. Overall, this seems reasonable to me. I have a slight concern that it might cause surprising failures for downstream users, that aren't picked up at build time (due to implicit conversions), but I don't think you need to worry too much about that.

[PATCH] D99248: [RFC][CodeGen] Emit range metadata for array subscript.

courbet created this revision. courbet requested review of this revision. Herald added a project: clang. To allow LLVM to do better alias anaysis. See RFC on llvm-dev. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99248 Files: clang/lib/CodeGen/CGExpr.cpp Index: clang/lib

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

curdeius updated this revision to Diff 332904. curdeius added a comment. - Address review comments (newline + remove diagnostic). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 Files: clang/include/clang

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

jansvoboda11 resigned from this revision. jansvoboda11 added a comment. Thanks for the update. Changes touching the command line LGTM, but I'll let others confirm the changes to `CodeGen` are fine too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D8

[PATCH] D95516: [clang][cli] Benchmark command line round-trip

jansvoboda11 updated this revision to Diff 332905. jansvoboda11 added a comment. Benchmark compilation and preprocessing as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95516/new/ https://reviews.llvm.org/D95516 Files: clang/CMakeLists.txt

[PATCH] D99250: [DebugInfo] Fix the C++ language tags for Dwarf versions.

Esme created this revision. Esme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Solve the problem of tags and version mismatch Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99250 Files: clang/lib/CodeGen/CGDebugInfo

[PATCH] D99189: [RISCV][Clang] Update new overloading rules for RVV intrinsics.

khchen marked 3 inline comments as done. khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c:11 // ASM-NOT: warning -#include +#include liaolucy wrote: > riscv_vector_overloaded.h ? Sorry, I forget to have a di

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

steakhal added a comment. I'm always in favor of bugfixes. However, I have some concerns about this one. Comment at: clang/lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:169-171 + } else if (B->getOpcode() == BinaryOperatorKind::BO_Cmp) { +// We can't reason ab

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

steakhal added a comment. In D98918#2636790 , @OikawaKirie wrote: > Please commit this patch on my behalf (Ella Ma ), so > that I can continue with D83660 with your > mocked solver. Oh, I forgot about this one. My apolo

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. In D99152#2644373 , @LuoYuanke wrote: >> To be honest i don't really understand why `x86_amx` type is even there. >> It seems to me that if you just directly used >> `@llvm.x86.tileloadd64.internal` / `@llvm.x86.tilestored64.interna

[PATCH] D99165: [clang] Fix a crash on checkDestructorReference.

hokein updated this revision to Diff 332925. hokein added a comment. - jrefine the fix of the crash: if the element type of an variable-length array is incomplete, the array type is incomplete; - simplify the testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 1d8fc08 - [clang][lit] Allow test cases to use the compiler that are used to compile Clang

Author: Ella Ma Date: 2021-03-24T11:32:57+01:00 New Revision: 1d8fc086ae26a1f973b25387b5063f1e801dc0f7 URL: https://github.com/llvm/llvm-project/commit/1d8fc086ae26a1f973b25387b5063f1e801dc0f7 DIFF: https://github.com/llvm/llvm-project/commit/1d8fc086ae26a1f973b25387b5063f1e801dc0f7.diff LOG:

[PATCH] D98918: [clang][lit] Allow test cases to use the compiler that are used to compile Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d8fc086ae26: [clang][lit] Allow test cases to use the compiler that are used to compile Clang (authored by OikawaKirie, committed by Balazs Benics ). Repository: rG LL

[PATCH] D97462: [clang][cli] Round-trip cc1 arguments in assert builds

jansvoboda11 added a comment. In D97462#2644406 , @arichardson wrote: > How expensive are these checks? If it is non-trivial overhead, maybe it > should default to `${LLVM_ENABLE_EXPENSIVE_CHECKS}` instead? Thanks for bringing that up. I measured the per

[PATCH] D99165: [clang] Fix a crash on checkDestructorReference.

hokein added a comment. In D99165#2644243 , @sammccall wrote: > The fix doesn't look obviously correct: the side effect of marking the > destructor reference seems important if we actually generate code. It's not > obvious to me why the type can only be

[clang] f8a850c - [Analyzer][NFC] Fix typos in comments

Author: Gabor Marton Date: 2021-03-24T11:46:10+01:00 New Revision: f8a850ccf452f9709c652823f11f1e95fd2c0e24 URL: https://github.com/llvm/llvm-project/commit/f8a850ccf452f9709c652823f11f1e95fd2c0e24 DIFF: https://github.com/llvm/llvm-project/commit/f8a850ccf452f9709c652823f11f1e95fd2c0e24.diff

[PATCH] D99121: [IR][InstCombine] IntToPtr Produces Typeless Pointer To Byte

nlopes added a comment. In D99121#2645593 , @dblaikie wrote: > In D99121#2644362 , @lebedev.ri > wrote: > >> In D99121#2644223 , @nlopes wrote: >> >>> The pointee type in LL

[clang] 0e4f5f3 - [PowerPC] Change option to mrop-protect

Author: Stefan Pintilie Date: 2021-03-24T05:51:35-05:00 New Revision: 0e4f5f3ea6e11c3e697504b9c43a328a8b85cd13 URL: https://github.com/llvm/llvm-project/commit/0e4f5f3ea6e11c3e697504b9c43a328a8b85cd13 DIFF: https://github.com/llvm/llvm-project/commit/0e4f5f3ea6e11c3e697504b9c43a328a8b85cd13.dif

[PATCH] D99185: [PowerPC] Change option to mrop-protect

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4f5f3ea6e1: [PowerPC] Change option to mrop-protect (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99185/new/ https://reviews.llvm.o

[PATCH] D99248: [RFC][CodeGen] Emit range metadata for array subscript.

courbet updated this revision to Diff 332931. courbet added a comment. Forgot to add test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99248/new/ https://reviews.llvm.org/D99248 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/arr

[clang] 3190cf2 - [clang][deps] NFC: Extract ModuleID struct

Author: Jan Svoboda Date: 2021-03-24T11:57:43+01:00 New Revision: 3190cf2017511e7a0570ea9a050a5f28f99d2bf6 URL: https://github.com/llvm/llvm-project/commit/3190cf2017511e7a0570ea9a050a5f28f99d2bf6 DIFF: https://github.com/llvm/llvm-project/commit/3190cf2017511e7a0570ea9a050a5f28f99d2bf6.diff L

[PATCH] D98943: [clang][deps] NFC: Extract ModuleID struct

This revision was automatically updated to reflect the committed changes. Closed by commit rG3190cf201751: [clang][deps] NFC: Extract ModuleID struct (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98943/new/ https://review

[clang] 772e9f8 - [clang][deps] NFC: Document collector, rename members

Author: Jan Svoboda Date: 2021-03-24T11:58:43+01:00 New Revision: 772e9f88dd78e6295bd71f1add4bcd7be0582817 URL: https://github.com/llvm/llvm-project/commit/772e9f88dd78e6295bd71f1add4bcd7be0582817 DIFF: https://github.com/llvm/llvm-project/commit/772e9f88dd78e6295bd71f1add4bcd7be0582817.diff L

[PATCH] D98950: [clang][deps] NFC: Document collector, rename members

This revision was automatically updated to reflect the committed changes. Closed by commit rG772e9f88dd78: [clang][deps] NFC: Document collector, rename members (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98950/new/ htt

Re: [clang] 874bdc8 - [Driver] Clean up Debian multiarch /usr/include/ madness

On Tue, Mar 23, 2021 at 7:09 PM Nico Weber wrote: > > Was this reviewed anywhere? No. This is a nice code cleanup. Do you find a case it does not handle correctly? > On Mon, Mar 22, 2021 at 1:40 AM Fangrui Song via cfe-commits > wrote: >> >> >> Author: Fangrui Song >> Date: 2021-03-21T22:40:38

Re: [clang] 874bdc8 - [Driver] Clean up Debian multiarch /usr/include/ madness

On Tue, Mar 23, 2021 at 9:22 PM Nico Weber wrote: > > Yes. > > 1. Download > https://commondatastorage.googleapis.com/chrome-linux-sysroot/toolchain/500976182686961e34974ea7bdc0a21fca32be06/debian_sid_amd64_sysroot.tar.xz > 2. Unpack somewhere > 3. Delete the lib/ folder in it > 4. Try to use tha

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro added a comment. Thanks. I feel like this is ready to go. Any additional comment? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D99165: [clang] Fix a crash on checkDestructorReference.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for digging! Comment at: clang/lib/AST/Type.cpp:2234 // (C++ [dcl.array]p1). -// We don't handle variable arrays (they're not allowed in C++) or -//

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plu

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

LuoYuanke added a comment. > IIUC you need this to transfer/convert data from a consecutive vector to an > `AMX` tile. To express that, emitting an intrinsic for the conversion instead > a `bit cast` seems the right thing to me. Yes. We need to transfer/convert data from a consecutive vector to

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 332946. abhina.sreeskantharajan edited the summary of this revision. abhina.sreeskantharajan added a comment. I've removed FileSize from getFileAux and WritableMemoryBuffer::getFile as well. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan marked 2 inline comments as done. abhina.sreeskantharajan added inline comments. Comment at: llvm/include/llvm/Support/MemoryBuffer.h:78-80 /// if successful, otherwise returning null. If FileSize is specified, this /// means that the client knows th

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this basically LGTM with a few minor nits, but I'd like to make sure @rsmith doesn't have concerns, so please wait a few days before landing in case he wants to chime in.

[clang] d1c8a15 - [OpenCL] Added distinct file extension for C++ for OpenCL.

Author: Anastasia Stulova Date: 2021-03-24T13:07:04Z New Revision: d1c8a151df830c6c727f0bb7d33774bd3eb96824 URL: https://github.com/llvm/llvm-project/commit/d1c8a151df830c6c727f0bb7d33774bd3eb96824 DIFF: https://github.com/llvm/llvm-project/commit/d1c8a151df830c6c727f0bb7d33774bd3eb96824.diff

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1c8a151df83: [OpenCL] Added distinct file extension for C++ for OpenCL. (authored by Anastasia). Herald added a subscriber: ldrumm. Herald added a p

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98433/new/ https://reviews.llvm.org/D98433 ___

[PATCH] D99258: [OpenCL] Fix AST check in address-space-templates test

Anastasia created this revision. Anastasia added a reviewer: bader. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. See comment: https://reviews.llvm.org/D95624#2621226 https://reviews.llvm.org/D99258 Files: clang/test/SemaOpenCLCXX/address-space-templa

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

Anastasia added inline comments. Herald added a subscriber: ldrumm. Comment at: clang/test/SemaOpenCLCXX/address-space-templates.cl:60 + // Preserve the address space of the type in forwarding reference. + // CHECK: CXXMethodDecl {{.*}} operator() 'void (__private int &__privat

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin created this revision. aheejin added a reviewer: sbc100. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, dschuff. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Functions specified in `-emscripten-cxx

[PATCH] D99165: [clang] Treat variable-length array of incomplete element type as incomplete type.

hokein added inline comments. Comment at: clang/lib/AST/Type.cpp:2234 // (C++ [dcl.array]p1). -// We don't handle variable arrays (they're not allowed in C++) or -// dependent-sized arrays (dependent types are never treated as incomplete). sammccall

[PATCH] D99260: [analyzer] Fix false positives in inner pointer checker (PR49628)

vsavchenko created this revision. vsavchenko added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D99259: [WebAssembly] Don't inline -emscripten-cxx-exceptions-allowed functions

aheejin updated this revision to Diff 332957. aheejin added a comment. Comment fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99259/new/ https://reviews.llvm.org/D99259 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp clang/test/Driver/wa

[PATCH] D99258: [OpenCL] Fix AST check in address-space-templates test

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99258/new/ https://reviews.llvm.org/D99258 ___ cfe-commits mailing list cfe-comm

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow

[clang] cfc36bf - [clang] Treat variable-length array of incomplete element type as

Author: Haojian Wu Date: 2021-03-24T14:22:15+01:00 New Revision: cfc36bf0179435ecbd489761bd7d5dae00846c87 URL: https://github.com/llvm/llvm-project/commit/cfc36bf0179435ecbd489761bd7d5dae00846c87 DIFF: https://github.com/llvm/llvm-project/commit/cfc36bf0179435ecbd489761bd7d5dae00846c87.diff LO

[PATCH] D99165: [clang] Treat variable-length array of incomplete element type as incomplete type.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfc36bf01794: [clang] Treat variable-length array of incomplete element type as (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES

[clang] 91f4c11 - [PowerPC] Add mprivileged option

Author: Stefan Pintilie Date: 2021-03-24T08:33:22-05:00 New Revision: 91f4c1113350e847397bcfa5b98d2029a5160da9 URL: https://github.com/llvm/llvm-project/commit/91f4c1113350e847397bcfa5b98d2029a5160da9 DIFF: https://github.com/llvm/llvm-project/commit/91f4c1113350e847397bcfa5b98d2029a5160da9.dif

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Herald added a project: clang-tools-extra. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:678 } - Server->addDocument(File, NewCode, encodeVersion(Pa

[PATCH] D99193: [PowerPC] Add mprivileged option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91f4c1113350: [PowerPC] Add mprivileged option (authored by stefanp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 332964. tbaeder added a comment. Alright, thanks for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 332966. tbaeder marked 6 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97362/new/ https://reviews.llvm.org/D97362 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

This revision was automatically updated to reflect the committed changes. Closed by commit rG0620e6f4b76a: [clang] [C++2b] [P1102] Accept lambdas without parameter list (). (authored by curdeius). Changed prior to commit: https://reviews.llvm.org/D98433?vs=332904&id=332967#toc Repository: rG

[clang] 0620e6f - [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

Author: Marek Kurdej Date: 2021-03-24T14:42:27+01:00 New Revision: 0620e6f4b76a9725dbd82454d58c5a68a7e47074 URL: https://github.com/llvm/llvm-project/commit/0620e6f4b76a9725dbd82454d58c5a68a7e47074 DIFF: https://github.com/llvm/llvm-project/commit/0620e6f4b76a9725dbd82454d58c5a68a7e47074.diff

[clang-tools-extra] 338d162 - [clang-tidy] Ignore all spaces in the list of checks

Author: Dmitry Polukhin Date: 2021-03-24T06:43:13-07:00 New Revision: 338d16275571df4d841609d7e12bcb310b3a95e6 URL: https://github.com/llvm/llvm-project/commit/338d16275571df4d841609d7e12bcb310b3a95e6 DIFF: https://github.com/llvm/llvm-project/commit/338d16275571df4d841609d7e12bcb310b3a95e6.dif

[PATCH] D12375: [PATCH] Relax parse ordering rules for attributes

thakis added a comment. Note to self: D95459 was a new attempt to fix this, which landed in https://reviews.llvm.org/rG9f2c7effd7f386e95aff3358500bc30974d35b0d Thanks for that :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12375/new/ https://review

[PATCH] D99262: [analyzer] Fix dead store checker false positive

vsavchenko created this revision. vsavchenko added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D98724: Fix false negative in -Wthread-safety-attributes

aaronpuchert added a comment. Ping @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98724/new/ https://reviews.llvm.org/D98724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaronpuchert added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98747/new/ https://reviews.llvm.org/D98747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

markj updated this revision to Diff 332974. markj added a comment. Enable the memory sanitizer too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98286/new/ https://reviews.llvm.org/D98286 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp Index:

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Does it also work on AArch64? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98286/new/ https://reviews.llvm.org/D98286 __

[PATCH] D98286: [Driver] Enable kernel address and memory sanitizers on FreeBSD

markj added a comment. In D98286#2647606 , @arichardson wrote: > Does it also work on AArch64? Not yet, I haven't yet ported the sanitizer runtimes (though it's on my todo list). ASAN requires that we specify the relative offset of the shadow map to the

[PATCH] D99063: [clang-format] Fix ObjC method indent after f7f9f94b

benhamilton accepted this revision. benhamilton added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99063/new/ https://reviews.llvm.org/D99063 _

[PATCH] D99152: [AMX] Prototype for vector and amx bitcast.

fhahn added a comment. > Front-end alloca <256 x i32> for the local variable tile. When the return > value of __builtin_ia32_tileloadd64_internal is assigned to tile. Front-end > bitcast x86_amx to <256 x i32>. The x86_amx is the type returned from > __builtin_ia32_tileloadd64_internal. Can

[PATCH] D99181: [analyzer] Fix crash on spaceship operator (PR47511)

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:331 // Note: LAnd, LOr, Comma are handled specially by higher-level logic. steakhal wrote: > So, there are some corner cases already. > I can't see any wa

[PATCH] D97119: [flang][driver] Add options for -std=f2018

arnamoy10 updated this revision to Diff 332991. arnamoy10 added a comment. Rebasing on top of main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97119/new/ https://reviews.llvm.org/D97119 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inc

[PATCH] D98657: [flang][driver] Add options for -Werror

arnamoy10 updated this revision to Diff 332997. arnamoy10 added a comment. rebasing on top of main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98657/new/ https://reviews.llvm.org/D98657 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp flang/inc

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for updating this @arnamoy10! One thing worth pointing out - this patch adds `-pedantic` rather than `-fpendatic` as @richard.barton.arm suggested. That was clearly a typo, s

[PATCH] D99200: [SystemZ][z/OS] JSON file should be text files

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99200/new/ https://reviews.llvm.org/D99200

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

gribozavr2 added a comment. Could you also update the switch statement in LLDB here: `llvm-project/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:472` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D9

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

gribozavr2 added a comment. Pushed the most minimal fix in https://github.com/llvm/llvm-project/commit/41454c30f6a38c3e107d857e63da0561610fd141, please double check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.or

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 333010. sdesmalen added a comment. Moved error reporting to llvm::reportInvalidSizeRequest in TypeSize.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https://reviews.llvm.org/D98856 Files: c

[PATCH] D99227: [Coroutine][Clang] Force emit lifetime intrinsics for Coroutines

lxfind added a comment. In D99227#2646819 , @rjmccall wrote: > Is it feasible to outline the initial segment that you don't want to be part > of the coroutine, and then have coroutine splitting force that outlined > function to be inlined into the ramp f

[PATCH] D98657: [flang][driver] Add options for -Werror

awarzynski added a comment. I see that `-Werror` changes the behavior of the driver in 5 different places. I would hope to see 5 new tests to verify each case. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:353-354 +/// Parses all semantic related arguments and popul

[PATCH] D98505: [clangd] Propagate data in diagnostics

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.h:58 + /// If true, Clangd will populate the data field in LSP diagnostic + /// representation. This is used to prevent extra data transfer with old + /// clients that doesn't support data field.

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM -

[PATCH] D98724: Fix false negative in -Wthread-safety-attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98724/new/ https://reviews.llvm.org/D98724 __

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5052-5055 + if (isa(JA)) { +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } paulwalker-arm wrote: > Are there any concerns

[PATCH] D99274: [analyzer] Fix crash when reasoning about C11 atomics (PR49422)

vsavchenko created this revision. vsavchenko added reviewers: NoQ, steakhal, xazax.hun, ASDenysPetrov. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, jfb, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald adde

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen updated this revision to Diff 333018. sdesmalen marked 5 inline comments as done. sdesmalen added a comment. Moved implementation of EVT::getVectorNumElements back to header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98856/new/ https:

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

sdesmalen added inline comments. Comment at: llvm/lib/CodeGen/ValueTypes.cpp:17 +unsigned EVT::getVectorNumElements() const { + auto Error = []() { ctetreau wrote: > Out of curiosity, what is the eventual plan for this function? Does it go > away, or will it

[PATCH] D98747: Thread safety analysis: Don't warn about managed locks on join points

aaron.ballman added a comment. I'd really like to hear from @delesley about these changes, specifically because of this bit: > the primary goal of the Thread safety analysis is not to find double locks > but race conditions. I believe the primary goal of TSA is to find threading-related issues

[PATCH] D99235: [HIP] Change to code object v4

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { We do not do it for v2/v3. Could you elabo

[PATCH] D99278: [clang][parser] Allow GNU-style attributes in struct declarations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sorry for the title, I'm not 100% sure that's even correct here. This call to `ProhibitAttribu

[clang] a6a1c30 - Fix false negative in -Wthread-safety-attributes

Author: Aaron Puchert Date: 2021-03-24T17:45:25+01:00 New Revision: a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7 URL: https://github.com/llvm/llvm-project/commit/a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7 DIFF: https://github.com/llvm/llvm-project/commit/a6a1c3051dbd2cc5ccc70272890cf38d11dca9c7.diff

[PATCH] D98724: Fix false negative in -Wthread-safety-attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa6a1c3051dbd: Fix false negative in -Wthread-safety-attributes (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D98505: [clangd] Propagate data in diagnostics

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.h:77 + // list. + std::vector OpaqueData; }; Hmm, you've replaced the json::Array with an array

[PATCH] D99280: [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. If emit inlined region for master/critical directives, no need to

[PATCH] D98538: [clangd] Perform merging for stale symbols in MergeIndex

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Merge.cpp:59 + + bool DynamicIndexIsAuthoritative = + // We expect the definition to see the canonical decl

[PATCH] D99274: [analyzer] Fix crash when reasoning about C11 atomics (PR49422)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99274/new/ https://reviews.llvm.org/D99274 _

[PATCH] D99280: [OPENMP]Fix PR48571: critical/master in outlined contexts cause crash.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99280/new/ https://reviews.llvm.org/D99280 _

[PATCH] D99151: [RISCV][Clang] Add RVV vleff intrinsic functions.

jrtc27 added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics/vle16ff.c:9 +// RUN: -target-feature +experimental-zfh -target-feature +m -fallow-half-arguments-and-returns -Werror -Wall -S -o - %s >/dev/null 2>%t +// RUN: FileCheck --check-prefix=ASM --allow

  1   2   >