rjmccall added a comment. In D99227#2646710 <https://reviews.llvm.org/D99227#2646710>, @lxfind wrote:
>> I think you just set `ShouldEmitLifetimeMarkers` correctly in the first >> place instead of adding this as an extra condition to every place that >> considers it, however. > > This was set when a CodeGenFunction is constructed, at that point it doesn't > yet know if this function is a coroutine. > I could turn ShouldEmitLifetimeMarkers to non-const, and then modify it once > it realizes it's a coroutine though, if that's better than the current > approach. That would be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99227/new/ https://reviews.llvm.org/D99227 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
