aaron.ballman added a comment.

I'd really like to hear from @delesley about these changes, specifically 
because of this bit:

> the primary goal of the Thread safety analysis is not to find double locks 
> but race conditions.

I believe the primary goal of TSA is to find threading-related issues that can 
be caught at compile time which includes both double locks and race conditions, 
and I don't have a good feel for whether these changes have a larger impact on 
the overall design or not.

As far as the changes in the patch go, they look reasonable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98747/new/

https://reviews.llvm.org/D98747

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to