[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. This looks really good. Just a few rather minor remarks. Comment at: clang/lib/Format/WhitespaceManager.cpp:280-281 // In the above example, we need to take

[clang] 587859d - clang-format: use `pb` as a canonical raw string delimiter for google style

Author: Krasimir Georgiev Date: 2021-03-09T09:07:14+01:00 New Revision: 587859d977e88648bee1888dce5175ef827f212e URL: https://github.com/llvm/llvm-project/commit/587859d977e88648bee1888dce5175ef827f212e DIFF: https://github.com/llvm/llvm-project/commit/587859d977e88648bee1888dce5175ef827f212e.d

[PATCH] D97688: clang-format: use `pb` as a canonical raw string delimiter for google style

This revision was automatically updated to reflect the committed changes. Closed by commit rG587859d977e8: clang-format: use `pb` as a canonical raw string delimiter for google style (authored by krasimir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. In D97183#2598806 , @NoQ wrote: > We could, for instance, teach it to mark //exploded nodes// as interesting > when it changes tracking mode. @NoQ, what is tracking mode for an `ExplodedNode`? Repository: rG LLVM Github Mono

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. @tbaeder sorry for the delay. I don't see any reason why we should keep that one in review any longer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This looks pretty good, great cleanup! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:408 +clangd::rename({Pos, NewName.getValueOr("__clangd_rename_dummy

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

CodaFi added a comment. I believe removing inode numbers is the correct fix, yes. The workaround I applied, and the one here, are both insufficient in the general case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97850/new/ https://reviews.llvm.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev updated this revision to Diff 329234. v.g.vassilev added a comment. - Do not rely on process exit code for `--host-supports-jit` but parse the true/false flag. - Move the `IncrementalProcessingTest` unittest from unittests/CodeGen to unittests/Interpreter. CHANGES SINCE LAST ACTI

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

steakhal added a comment. All reports and crashes are preserved at this point of the patch stack - with or without z3 crosscheck on multiple projects - even on llvm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 __

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

steakhal added a comment. If @NoQ doesn't have any objections I'm ok with this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329242. serge-sans-paille added a comment. Patch rebased on main. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang/Basic/DiagnosticGroup

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin added a comment. @aaron.ballman @alexfh @njames93 - friendly ping, please take a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 ___ cfe-comm

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov added a comment. @NoQ wrote: > IIUC this is roughly the first time ever when `SValBuilder` starts emitting > symbols of float type. This is a huge change with an almost unlimited scope > of unexpected side effects and very rigorous testing is required to > understand the actual e

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. I am trying to use scan-build on a file to see what sort of errors are reported: `./llvm-project/release/bin/scan-build -o . -enable-checker alpha.cplusplus.SmartPtr -analyzer-config alpha.cplusplus.SmartPtrModelling:ModelSmartPtrDereference=true clang++ -c uniq_deref

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.h:40 + // The filesystem to query when performing cross file renames. + llvm::IntrusiveRefCntPtr FS; sammccall wrote: > Index + FS are both only used for cross-file renames a

[PATCH] D98241: [clangd] Move logging out of LSPTest base class into a separate one.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This was causing TSan failures due to a rac

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

martong added a comment. > This causes a crash if the function is called in such case. Is the crash caused by the below assertion? QualType Expr::findBoundMemberType(const Expr *expr) { assert(expr->hasPlaceholderType(BuiltinType::BoundMember)); Comment at: clang/lib/AS

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

martong added inline comments. Comment at: clang/lib/AST/Expr.cpp:1406 + } else if (CalleeType->isDependentType() || + CalleeType->isSpecificPlaceholderType(BuiltinType::Overload)) { +return CreateDependentType(); Can't we create a built in place

[PATCH] D98242: [clangd] Store system relative includes as verbatim

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This makes our index more portable between

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/DraftStore.cpp:287 +for (const auto &KV : DS.Drafts) { + // Query the base filesystem for file uniqueids. + auto BaseStatus = BaseView->status(KV.getKey()); njames93 wrote: > njam

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:408 +clangd::rename({Pos, NewName.getValueOr("__clangd_rename_dummy"), +InpAST->AST, File, TFS.view(llvm::None), +/*Index=*/nullptr, Renam

[PATCH] D98241: [clangd] Move logging out of LSPTest base class into a separate one.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for working this out! And sorry for the stupid private inheritance tricks :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98241/n

[PATCH] D97277: [analyzer] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder

vsavchenko accepted this revision. vsavchenko added a comment. This revision is now accepted and ready to land. Looks great, thanks for cleaning up! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97277/new/ https://reviews.llvm.org/D97277 ___

[clang-tools-extra] d1531b0 - [clangd] Move logging out of LSPTest base class into a separate one.

Author: Kadir Cetinkaya Date: 2021-03-09T11:57:05+01:00 New Revision: d1531b08c3d1bd46829a91313e7d6eb24d04c0d0 URL: https://github.com/llvm/llvm-project/commit/d1531b08c3d1bd46829a91313e7d6eb24d04c0d0 DIFF: https://github.com/llvm/llvm-project/commit/d1531b08c3d1bd46829a91313e7d6eb24d04c0d0.dif

[PATCH] D98244: [analyzer] Fix StdLibraryFunctionsChecker performance issue

vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald

[PATCH] D98241: [clangd] Move logging out of LSPTest base class into a separate one.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1531b08c3d1: [clangd] Move logging out of LSPTest base class into a separate one. (authored by kadircet). Repository: rG LLVM Github Monorepo CH

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

CarlosAlbertoEnciso added a comment. In D97411#2611142 , @probinson wrote: > In D97411#2598625 , @akhuang wrote: > >> I started looking into some diffs of debug info in libc++ tests, but it's >> pretty hard to tell

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:801 + if (IsSystem) +return "<" + ShorterInclude + ">"; // Standard case: just insert the file itself. This is a great heuristic, now I'm thinking of all the w

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jansvoboda11 added a comment. In D89986#2612021 , @DiggerLin wrote: > Gentle ping . @jansvoboda11 . Do you have any comment on it the last update > on "added -round-trip-args functionality for the lang opt > "-mignore-xcoff-visibility" ? I'd slightly

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

sammccall accepted this revision. sammccall added a comment. Still LG btw! Comment at: clang-tools-extra/clangd/ClangdServer.h:342 - llvm::Optional getDraft(PathRef File) const; + std::shared_ptr getDraft(PathRef File) const; Maybe add an explicit comment

[clang] 13c77f2 - [OpenCL] Fix builtins that require multiple extensions

Author: Sven van Haastregt Date: 2021-03-09T11:37:26Z New Revision: 13c77f204671f403a30d29ec1c9145c556302f66 URL: https://github.com/llvm/llvm-project/commit/13c77f204671f403a30d29ec1c9145c556302f66 DIFF: https://github.com/llvm/llvm-project/commit/13c77f204671f403a30d29ec1c9145c556302f66.diff

[PATCH] D97930: [OpenCL] Fix builtins that require multiple extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG13c77f204671: [OpenCL] Fix builtins that require multiple extensions (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97930/new/ https://

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

ASDenysPetrov updated this revision to Diff 329282. ASDenysPetrov added a comment. Updated due to discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97874/new/ https://reviews.llvm.org/D97874 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/test/Analysis/cast_symbo

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

balazske added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97196/new/ https://reviews.llvm.org/D97196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D98076: [OpenCL][Docs] Release 12.0 notes

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:208 +- Added ``-cl-std=CL3.0`` and predefined version macro for OpenCL 3.0. +- Added ``-cl-std=CL1.0`` and mapped to the existing OpenCL 1.0 functionality. +- Improved OpenCL extension handling per target. ---

[PATCH] D97990: [clang] Improve diagnostics on implicitly deleted defaulted comparisons

mizvekov updated this revision to Diff 329289. mizvekov added a comment. Change to simpler way to do it: For CompleteObject Kind, just fill in the declaration for the complete object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97990/new/ https:/

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added a comment. In D97080#2586289 , @arnamoy10 wrote: > Also, not sure what to set as the default directory, as gfortran uses a > specific installation location. We probably should use a location relative to the `flang-new` binary, i.e. `/..

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Could the logic be implemented in the driver? LGTM regardless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://rev

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added a comment. LGTM. @jrtc27 are you ok with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D97552: [clang][cli] Fix generation of '-fvisibility' with regards to '-mignore-xcoff-visibility'

jansvoboda11 added a comment. In D97552#2607842 , @DiggerLin wrote: > 1. in your summary , it looks clang will emit "-fvisibility default" to cc1 > even if there is no -fvisibility in the clang command ? I compiled the clang > with your patch, it look

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6172-6174 + if (IsVectorConditional) { +return CheckVectorConditionalTypes(Cond, LHS, RHS, QuestionLoc); + } aaron.ballman wrote: > I'll fix tha

[PATCH] D98251: [-Wcompletion-handler] Extend list of detected conventions

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update convention detection to accomodate changes from: https://github.com/D

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan added a comment. If there are no concerns about setting OF_None flag for all ToolOutputFiles on Windows only, I would also like to get your reviews for this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ htt

[clang] fc8d376 - [ExtVectorType] Support conditional select operator for C++.

Author: Florian Hahn Date: 2021-03-09T13:08:52Z New Revision: fc8d3766d721ebc075e16814e48adf48034ea858 URL: https://github.com/llvm/llvm-project/commit/fc8d3766d721ebc075e16814e48adf48034ea858 DIFF: https://github.com/llvm/llvm-project/commit/fc8d3766d721ebc075e16814e48adf48034ea858.diff LOG:

[PATCH] D98055: [ExtVectorType] Support conditional select operator for C++.

This revision was automatically updated to reflect the committed changes. fhahn marked an inline comment as done. Closed by commit rGfc8d3766d721: [ExtVectorType] Support conditional select operator for C++. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D98055?vs=328815

[PATCH] D98253: [clang][ARM] Refactor computeLLVMTriple code for ARM

DavidSpickett created this revision. Herald added subscribers: danielkiss, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This moves code that sets the architecture name and Float ABI into two new functions in

[PATCH] D98253: [clang][ARM] Refactor computeLLVMTriple code for ARM

DavidSpickett added a reviewer: ostannard. DavidSpickett added a comment. Besides the usual motivations this is prep for fixing https://bugs.llvm.org/show_bug.cgi?id=48894 for AArch64. Which will need a similar (but simpler) set of calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D98254: Fix typo in two files in Clang

FusionBolt created this revision. FusionBolt added reviewers: 01alchemist, 0b01. FusionBolt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98254 Files: clang/lib/AST/Inter

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra created this revision. amilendra added reviewers: willlovett, kristof.beyls, jgreenhalgh. amilendra added a project: clang. amilendra requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98255 Files:

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97951/new/ https://reviews.llvm.org/D97951 ___ c

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder updated this revision to Diff 329309. tbaeder added a comment. Just re-tested this on a SystemZ machine and found that the `set()` in `clang/CMakeLists.txt` were not actually being applied. I also made it disable LLD on SystemZ as well, as you suggested. And I added a warning when `BOOT

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 329312. kbobyrev added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Use reflection, improve message format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329318. serge-sans-paille added a comment. Updated error message to report the reason why an identifier is reserved. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST

[clang-tools-extra] 0250b05 - [clangd] Add a Filesystem that overlays Dirty files.

Author: Nathan James Date: 2021-03-09T14:35:21Z New Revision: 0250b053b5aa7fc16408e6c037e5e71db5e9b012 URL: https://github.com/llvm/llvm-project/commit/0250b053b5aa7fc16408e6c037e5e71db5e9b012 DIFF: https://github.com/llvm/llvm-project/commit/0250b053b5aa7fc16408e6c037e5e71db5e9b012.diff LOG:

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0250b053b5aa: [clangd] Add a Filesystem that overlays Dirty files. (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D94554?vs=329070&id=329319#toc Repository: rG LLVM Github

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 329316. DiggerLin added a comment. slight change , move to if (Opts.IgnoreXCOFFVisibility) GenerateArg(Args, OPT_mignore_xcoff_visibility, SA); to position as comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang-tools-extra] 574663f - [clangd][NFC] Silence some buildbot warnings after 0250b053

Author: Nathan James Date: 2021-03-09T14:55:55Z New Revision: 574663f9d522420be7a67d9c55728af8330e1dd3 URL: https://github.com/llvm/llvm-project/commit/574663f9d522420be7a67d9c55728af8330e1dd3 DIFF: https://github.com/llvm/llvm-project/commit/574663f9d522420be7a67d9c55728af8330e1dd3.diff LOG:

[clang] 272bcd0 - [clang][sema][NFC] Remove a superfluous semicolon

Author: Timm Bäder Date: 2021-03-09T16:14:07+01:00 New Revision: 272bcd0eeff5297eea5a25223d169dcd44b06ba6 URL: https://github.com/llvm/llvm-project/commit/272bcd0eeff5297eea5a25223d169dcd44b06ba6 DIFF: https://github.com/llvm/llvm-project/commit/272bcd0eeff5297eea5a25223d169dcd44b06ba6.diff LO

[PATCH] D93769: [clang] Add support for option -ffp-eval-method and extend #pragma float_control similarly

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2884 + } + Opts.setFPEvalMethod(FEM); + Can you please use the marshalling infrastructure for this? https://clang.llvm.org/docs/InternalsManual.html#adding-new-command-li

[clang] 46d4d1f - [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

Author: diggerlin Date: 2021-03-09T10:38:00-05:00 New Revision: 46d4d1fea401de1d22fe746077a4ca4dd7e137b4 URL: https://github.com/llvm/llvm-project/commit/46d4d1fea401de1d22fe746077a4ca4dd7e137b4 DIFF: https://github.com/llvm/llvm-project/commit/46d4d1fea401de1d22fe746077a4ca4dd7e137b4.diff LOG

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46d4d1fea401: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff… (authored by DiggerLin). Repository: rG LLVM Github Mon

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz updated this revision to Diff 329346. adamcz added a comment. expanded a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97965/new/ https://reviews.llvm.org/D97965 Files: clang/lib/Sema/SemaTemplate.cpp clang/test/SemaCXX/cxx1z-cl

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

adamcz added inline comments. Comment at: clang/test/SemaCXX/cxx1z-class-template-argument-deduction.cpp:425 + // This used to crash due to unparsed default arg above. + B(); // expected-error {{deduction guide declaration without trailing return type}} +}; ho

[clang] 4f8e299 - [Sema] Fix diagnostics for one-byte length modifier

Author: Anton Bikineev Date: 2021-03-09T16:56:20+01:00 New Revision: 4f8e299785e860cf974d696d7ca83b70a94977fe URL: https://github.com/llvm/llvm-project/commit/4f8e299785e860cf974d696d7ca83b70a94977fe DIFF: https://github.com/llvm/llvm-project/commit/4f8e299785e860cf974d696d7ca83b70a94977fe.diff

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f8e299785e8: [Sema] Fix diagnostics for one-byte length modifier (authored by AntonBikineev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97951/new/ http

[PATCH] D97951: [Sema] Fix diagnostics for one-byte length modifier

AntonBikineev added a comment. Thanks Aaron for taking a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97951/new/ https://reviews.llvm.org/D97951 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm created this revision. stelios-arm added reviewers: dmgreen, SjoerdMeijer, fhahn, simon_tatham, ostannard, c-rhodes. stelios-arm added a project: LLVM. Herald added subscribers: danielkiss, hiraditya, kristof.beyls. stelios-arm requested review of this revision. Herald added a project:

[clang] 4e1c487 - [clang] Fix crash when creating deduction guide.

Author: Adam Czachorowski Date: 2021-03-09T16:57:56+01:00 New Revision: 4e1c487004a29ec9bc56fd47fc30336d033c57dd URL: https://github.com/llvm/llvm-project/commit/4e1c487004a29ec9bc56fd47fc30336d033c57dd DIFF: https://github.com/llvm/llvm-project/commit/4e1c487004a29ec9bc56fd47fc30336d033c57dd.d

[PATCH] D97965: [clang] Fix crash when creating deduction guide.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e1c487004a2: [clang] Fix crash when creating deduction guide. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:363 + if (HasRandGen) +Builder.defineMacro("__ARM_FEATURE_RNG", "1"); Where/when is `HasRandGen` set? Comment at: clang/test/Preprocessor/init-aarch64.c:

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Xiangling_L created this revision. Xiangling_L added reviewers: daltenty, hubert.reinterpretcast, cebowleratibm, jsji, Whitney. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. LLVM is recommending to use SmallVector (that is, o

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

njames93 updated this revision to Diff 329354. njames93 added a comment. Update to assert that either Index and FS are both set, or neither set. Document this behaviour. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95043/new/ https://reviews.llvm.

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1495 let DecoderNamespace = "Fallback"; + let Defs = [NZCV]; } SjoerdMeijer wrote: > Do all MRS instructions do this? No, but some do and it's not obvious which ones do

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added a comment. @jrtc27, please advise if there is anything more should to be changed, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 ___ cfe-com

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 329361. serge-sans-paille added a comment. Fix some formatting Support literal operator CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://reviews.llvm.org/D93095 Files: clang/include/clang/AST/Decl.h clang/include/clang

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1495 let DecoderNamespace = "Fallback"; + let Defs = [NZCV]; } dmgreen wrote: > SjoerdMeijer wrote: > > Do all MRS instructions do this? > No, but some do and it's

[PATCH] D98244: [analyzer] Fix StdLibraryFunctionsChecker performance issue

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Good catch! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98244/new/ https://reviews.llvm.org/D98244 _

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

craig.topper added a comment. Maybe this needs to be addressed in the forward declaration in clang/include/clang/Basic/LLVM.h ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98265/new/ https://reviews.llvm.org/D98265 _

[PATCH] D98244: [analyzer] Fix StdLibraryFunctionsChecker performance issue

steakhal accepted this revision. steakhal added a comment. > For projects not using standard libraries, the speed-up can reach 50% after > this patch. Uh, that's something serious! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98244/new/ https://

[PATCH] D97277: [analyzer] Eliminate dispatchCast, evalCastFromNonLoc and evalCastFromLoc functions from SValBuilder

steakhal added a comment. Please, @ASDenysPetrov, mention `NFC` in the commit message when you commit this change. The same applies to all of your NFC changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97277/new/ https://reviews.llvm.org/D97277

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Xiangling_L added a comment. In D98265#2614245 , @craig.topper wrote: > Maybe this needs to be addressed in the forward declaration in > clang/include/clang/Basic/LLVM.h ? Yeah, adding an additional llvm namespace is a certain another way to workaround

[clang] b8b7a9d - [clang] unbreak Index/preamble-reparse-changed-module.m with LLVM_APPEND_VC_REV=NO after 46d4d1fea401

Author: Nico Weber Date: 2021-03-09T12:29:43-05:00 New Revision: b8b7a9dcdcbcd7427119f92b9a276ac0122ca8c6 URL: https://github.com/llvm/llvm-project/commit/b8b7a9dcdcbcd7427119f92b9a276ac0122ca8c6 DIFF: https://github.com/llvm/llvm-project/commit/b8b7a9dcdcbcd7427119f92b9a276ac0122ca8c6.diff LO

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98265/new/ https://reviews.llvm.org/D98265

[PATCH] D46443: [libc++] Add missing cstdalign header

curdeius added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > sbc100 wrote: > > hubert.reinterpretcast wrote: > > > This seems to be assuming that the underlying C library's `stdalign.h`

[PATCH] D46443: [libc++] Add missing cstdalign header

curdeius added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > hubert.reinterpretcast wrote: > > sbc100 wrote: > > > hubert.reinterpretcast wrote: > > > > This seems to be assuming that the underlying C

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:15993 + DAG.getConstant(0, dl, MVT::i32), + DAG.getConstant(AArch64CC::EQ, dl, MVT::i32), A.getValue(1)); + return DAG.getMergeValues( Can you make s

[clang] 561fb7f - [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

Author: Xiangling Liao Date: 2021-03-09T13:03:52-05:00 New Revision: 561fb7f60ab631e712c3fb6bbeb47061222c6818 URL: https://github.com/llvm/llvm-project/commit/561fb7f60ab631e712c3fb6bbeb47061222c6818 DIFF: https://github.com/llvm/llvm-project/commit/561fb7f60ab631e712c3fb6bbeb47061222c6818.diff

[PATCH] D98265: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG561fb7f60ab6: [NFC] Use llvm::SmallVector to workaround XL compiler problem on AIX (authored by Xiangling_L). Repository: rG LLVM Github Monorepo

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra updated this revision to Diff 329380. amilendra added a comment. Herald added subscribers: llvm-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, jansvoboda11, frasercrmck, dexonsmith, ecnelises, wenlei, dang, jdoerfert, sstefan1, omjavaid, jvesely, phosek, kerbowa, lu

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra abandoned this revision. amilendra added a comment. Herald added a subscriber: JDevlieghere. Abandoning this revision because I think I messed up something when using arcanist to fix pre-merge errors. https://buildkite.com/llvm-project/diff-checks/builds/32719 I'll submit a new review.

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

MaskRay added a comment. In D97743#2613629 , @jansvoboda11 wrote: > Could the logic be implemented in the driver? > > LGTM regardless. No. `Res` is a `clang::CompilerInvocation` object. `CompilerInvocation` is not in the driver... Repository: rG LLV

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:1495 let DecoderNamespace = "Fallback"; + let Defs = [NZCV]; } dmgreen wrote: > SjoerdMeijer wrote: > > dmgreen wrote: > > > SjoerdMeijer wrote: > > > > Do all MRS

[clang] c11ff4b - Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

Author: Fangrui Song Date: 2021-03-09T10:52:26-08:00 New Revision: c11ff4bbada3b5127a1f010e0a97a1e6e46fb61a URL: https://github.com/llvm/llvm-project/commit/c11ff4bbada3b5127a1f010e0a97a1e6e46fb61a DIFF: https://github.com/llvm/llvm-project/commit/c11ff4bbada3b5127a1f010e0a97a1e6e46fb61a.diff

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc11ff4bbada3: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98274: [clangd][NFC] Use std::string::replace in SourceCode:applyChange.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Just looks nicer and easier to rea

[PATCH] D98275: [clang-tidy] Fix mpi checks when running multiple TUs per clang-tidy process

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Both the mpi-type-mismatch and mpi-buffer-deref check make use o

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra created this revision. amilendra added reviewers: willlovett, kristof.beyls, jgreenhalgh. amilendra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98277 Files: c

[PATCH] D97743: Define __GCC_HAVE_DWARF2_CFI_ASM if applicable

thakis added a comment. This seems to break tests everywhere: http://45.33.8.238/linux/41275/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97743/new/ https://reviews.llvm.org/D97743 ___ cfe-co

[clang] 8bb8d65 - Move some attribute diagnostic helper functions; NFC.

Author: Aaron Ballman Date: 2021-03-09T14:57:00-05:00 New Revision: 8bb8d65e167dceb659211468fd44df5da17e0785 URL: https://github.com/llvm/llvm-project/commit/8bb8d65e167dceb659211468fd44df5da17e0785 DIFF: https://github.com/llvm/llvm-project/commit/8bb8d65e167dceb659211468fd44df5da17e0785.diff

  1   2   >