sammccall accepted this revision. sammccall added a comment. Still LG btw!
================ Comment at: clang-tools-extra/clangd/ClangdServer.h:342 - llvm::Optional<std::string> getDraft(PathRef File) const; + std::shared_ptr<const std::string> getDraft(PathRef File) const; ---------------- Maybe add an explicit comment that this returns nullptr if the file is not open. (When the type was Optional this was fairly self-explanatory) ================ Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + const std::unique_ptr<ThreadsafeFS> DirtyFS; }; ---------------- nit: we don't use const on pointer members, just on the pointee where appropriate. Maybe not the best style in a vacuum but it's fairly consistent and diverging from it is a bit confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
