njames93 added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/Rename.h:40 + // The filesystem to query when performing cross file renames. + llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem> FS; ---------------- sammccall wrote: > Index + FS are both only used for cross-file renames at this point. > > (We used to support a single-file rename mode where the index was used to > validate that the symbol wasn't used elsewhere, but that's gone now) > > I think we should document this, and assert that they're either both set > (cross-file) or neither is. I wasn't sure the best way to approach this, but i agree, this is probably the safest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95043/new/ https://reviews.llvm.org/D95043 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
