[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe updated this revision to Diff 327691. FreddyYe added a comment. delete extra spaces. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 Files: clang/test/Preprocessor/predefined-arch

[PATCH] D97832: [X86] Refine "Support -march=alderlake"

FreddyYe marked an inline comment as done. FreddyYe added a comment. THX for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97832/new/ https://reviews.llvm.org/D97832 ___ cfe-commits mailing list

[PATCH] D97606: [Clang interpreter] Avoid storing pointers at unaligned locations

nand added a comment. The patches implementing more features/control flow constructs have not yet been committed, so if the pre-existing test passes, the functionality should be fine. Adjustments can be made later on when those patches are rebased. Comment at: clang/lib/AST/I

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added inline comments. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:52-62 +void testMultiple() { + int F::*f = &F::field; + int A::*a = reinterpret_cast(f); + int C::*c = reinterpret_cast(f); + A aobj; + C cobj; + aobj.*a = 13; ---

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 327716. qiucf marked 2 inline comments as done. qiucf added a comment. - Add helper method to count 'unordered' cases - Add missing tests (in last update) - Add test for openmp device-host case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D97717: [SYCL] Rework the SYCL driver options

bader added a comment. @aaron.ballman, it looks like unittests should be updated as well. Please, take a look at failures in pre-merge checks. Comment at: clang/include/clang/Basic/LangOptions.def:252 LANGOPT(SYCLIsDevice , 1, 0, "Generate code for SYCL device") +LANGOPT

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

tbaeder updated this revision to Diff 327718. tbaeder added a comment. Thanks for the suggestions, Aaron. The new version seems to work but I was not sure how to get the token at a source location. I could only find `Lexer::findNextToken()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D96281: [clang-tidy] Add options to flag individual core increments and to ignore macros to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327721. massberg added a comment. Remove IgnoreMacros option (to be added in a follow up patch) and sync to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281 Files

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg added a comment. In D96281#2596657 , @lebedev.ri wrote: > Once again, can we please split this into two patches? > I'm quite happy with the `DescribeBasicIncrements` stuff, that can be merged > right now. I have removed the IgnoreMacros and will

[PATCH] D97775: [AArch64] Add missing intrinsics for vcls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG394a4d04333e: [AArch64] Add missing intrinsics for vcls (authored by jaykang10). Herald added a project: clang. Herald added a subscriber: cfe-commit

[clang] 394a4d0 - [AArch64] Add missing intrinsics for vcls

Author: JinGu Kang Date: 2021-03-03T10:17:56Z New Revision: 394a4d04333e8b26ff581eb1f6c56a6e50a157e4 URL: https://github.com/llvm/llvm-project/commit/394a4d04333e8b26ff581eb1f6c56a6e50a157e4 DIFF: https://github.com/llvm/llvm-project/commit/394a4d04333e8b26ff581eb1f6c56a6e50a157e4.diff LOG: [A

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

lebedev.ri added a comment. Does the test start to fail if you undo the .cpp change? You may want to add some ` // CHECK-NOTES-NOT: warning` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281

[clang-tools-extra] 1a4990a - [clangd] Fix uninit member

Author: Sam McCall Date: 2021-03-03T11:45:16+01:00 New Revision: 1a4990a4f71adf1ea0b8f7e0ae2ddd8a85f9c393 URL: https://github.com/llvm/llvm-project/commit/1a4990a4f71adf1ea0b8f7e0ae2ddd8a85f9c393 DIFF: https://github.com/llvm/llvm-project/commit/1a4990a4f71adf1ea0b8f7e0ae2ddd8a85f9c393.diff LO

[PATCH] D97156: [ASTMatchers] Make Param functors variadic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG243cd0afadc7: [ASTMatchers] Make Param functors variadic (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 243cd0a - [ASTMatchers] Make Param functors variadic

Author: Stephen Kelly Date: 2021-03-03T11:41:20Z New Revision: 243cd0afadc7b406ed6c314f7645b1d72748ddd1 URL: https://github.com/llvm/llvm-project/commit/243cd0afadc7b406ed6c314f7645b1d72748ddd1 DIFF: https://github.com/llvm/llvm-project/commit/243cd0afadc7b406ed6c314f7645b1d72748ddd1.diff LOG:

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:389 + + class DirtyFS : public ThreadsafeFS { + public: Probably needs moving to its own place, but wasn't sure where best to put it. Comment at: clang-tools-

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. In D96281#2599812 , @lebedev.ri wrote: > Does the test start to fail if you undo the .cpp change? > You may want to add some ` // CHECK-NOTES-N

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong created this revision. martong added reviewers: riccibruno, aaron.ballman, shafik, teemperor, rsmith. Herald added subscribers: gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. martong requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong added a comment. F15719554: valgrind-output.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97849/new/ https://reviews.llvm.org/D97849 ___ cfe-commits maili

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327746. massberg added a comment. Add checks to ensure that notes aren't added for specific options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96281/new/ https://reviews.llvm.org/D96281 Files: clang-too

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

lebedev.ri added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-function-cognitive-complexity-flags.cpp:16 + // CHECK-NOTES: :[[@LINE-1]]:6: warning: function 'func_of_complexity_4' has cognitive complexity of 4 (threshold 0) [readability-

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman added a comment. In D97717#2599728 , @bader wrote: > @aaron.ballman, it looks like unittests should be updated as well. Please, > take a look at failures in pre-merge checks. Thanks, I'll correct those! Comment at: clang

[PATCH] D97806: [clang-query] Fix help text after D91918

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97806/new/ https://reviews.llvm.org/D97806 ___ cfe-commits mailing list cfe-commit

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 327743. whisperity retitled this revision from "[clang-tidy] Approximate implicit conversion issues in 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type'" to "[clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixabil

[PATCH] D97850: Fix PCM read from ModuleCache for ext4 filesystem

ilyakuteev created this revision. ilyakuteev requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97850 Files: clang/lib/Serialization/ModuleManager.cpp Index: clang/lib/Seria

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

thakis added a comment. > Thank you. Let me know when you have more information. Repro is moving along. https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 and onward are getting pretty close. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 8da0903 - Improve static_assert/_Static_assert diagnostics

Author: Aaron Ballman Date: 2021-03-03T08:48:27-05:00 New Revision: 8da090381d567d0ec555840f6b2a651d2997e4b3 URL: https://github.com/llvm/llvm-project/commit/8da090381d567d0ec555840f6b2a651d2997e4b3 DIFF: https://github.com/llvm/llvm-project/commit/8da090381d567d0ec555840f6b2a651d2997e4b3.diff

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman closed this revision. aaron.ballman added a comment. In D95396#2598932 , @rsmith wrote: > Looks like `test/FixIt/fixit-static-assert.cpp` is failing in Phabricator's > pre-merge checks: B91556 . Please take a

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM with some nitpicks 😊 Comment at: llvm/include/llvm/CodeGen/Passes.h:496 + + /// The pass transform amx intrinsics to scalar operation if the function has + /// optno

[PATCH] D75041: [clang-tidy] Extend 'bugprone-easily-swappable-parameters' with mixability because of implicit conversions

whisperity updated this revision to Diff 327761. whisperity added a comment. After reading through the diff as rendered by Phabricateur, I realised I left in a few crappy debug prints and commented-out values that are not needed in the end. This is fixed now. CHANGES SINCE LAST ACTION https:

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2600031 , @thakis wrote: >> Thank you. Let me know when you have more information. > > Repro is moving along. > https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 and onward > are getting pretty close. Tha

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added a comment. @aaron.ballman I've reworked and uploaded the final addition to this line, the crown jewel, the very reason this checker was developed (D75041 ). So, AFAIK, the "let's rewrite the whole thing with better code quality" work can be cons

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski requested changes to this revision. awarzynski added a comment. This revision now requires changes to proceed. This patch won't build with `BUILD_SHARED_LIBS` set to `On`. That's because a new dependency in `CompilerInvocation` is introduced (on `IntrinsicTypeDefaultKinds`). This depe

[PATCH] D97362: [clang][parser] Allow attributes in explicit template instantiations

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:1618 + +if (Tok && (*Tok).is(tok::l_square)) { + Diag(Attrs.Range.getBegin(), diag::err_attributes_not_allowed) << Attrs.Range; This will incorrectly classify an empty MS att

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov updated this revision to Diff 327767. azabaznov added a comment. Check 'isEnabled' is now private: it is used only for non-core or non-optional core features; creation of implicit type definitions is guarder with extension support check; minor refactoring Repository: rG LLVM Github

[PATCH] D97717: [SYCL] Rework the SYCL driver options

aaron.ballman updated this revision to Diff 327769. aaron.ballman added a comment. Fixed the failing unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97717/new/ https://reviews.llvm.org/D97717 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Opti

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added inline comments. Comment at: clang/lib/Basic/OpenCLOptions.cpp:22-26 + auto &OptInfo = OptMap.find(Ext)->getValue(); + if (OptInfo.isCoreIn(LO) || OptInfo.isOptionalCoreIn(LO)) +return isSupported(Ext, LO); + + return isEnabled(Ext); Note t

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

aaron.ballman added a comment. This looks reasonable to me (good catch!), but is there a way for us to add a regression test for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97849/new/ https://reviews.llvm.org/D97849

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. The preprocessed source is attached to this comment: https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c26 good.s and bad.s are here: https://bugs.chromium.org/p/chromium/issues/detail?id=1182642#c28 And this shows the problematic difference between them: htt

[clang-tools-extra] 188373f - [clangd] Make WorkspaceSymbols request work with empty queries

Author: Kadir Cetinkaya Date: 2021-03-03T15:41:39+01:00 New Revision: 188373fb46979d8141e9f844f13a85157b1ce5dd URL: https://github.com/llvm/llvm-project/commit/188373fb46979d8141e9f844f13a85157b1ce5dd DIFF: https://github.com/llvm/llvm-project/commit/188373fb46979d8141e9f844f13a85157b1ce5dd.dif

[PATCH] D97773: [clangd] Make WorkspaceSymbols request work with empty queries

This revision was automatically updated to reflect the committed changes. Closed by commit rG188373fb4697: [clangd] Make WorkspaceSymbols request work with empty queries (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97773/new/

[PATCH] D97805: [clang-query] Add option to enable only displaying main file matches

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-query/Query.cpp:60-61 +"main-file-only " +"Only match nodes from the main source file. This mode is the " +"default.\n" " set output " ---

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

steakhal added a comment. In D97849#2600201 , @aaron.ballman wrote: > This looks reasonable to me (good catch!), but is there a way for us to add a > regression test for it? I'm not sure if it's possible to write a test for deterministically demonstrat

[clang] 0a5dd06 - Revert "[ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR"

Author: Hans Wennborg Date: 2021-03-03T15:51:40+01:00 New Revision: 0a5dd067181dac2a8882a139ea3bd19bdea5fa44 URL: https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 DIFF: https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44.diff

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

hans added a comment. Reverted in https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 until this can be fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808

[clang] 25ad188 - [OpenCL] Prevent adding extension pragma by default.

Author: Anastasia Stulova Date: 2021-03-03T15:02:21Z New Revision: 25ad188bfcdb2a85416013c6303f30cbc7775674 URL: https://github.com/llvm/llvm-project/commit/25ad188bfcdb2a85416013c6303f30cbc7775674 DIFF: https://github.com/llvm/llvm-project/commit/25ad188bfcdb2a85416013c6303f30cbc7775674.diff

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25ad188bfcdb: [OpenCL] Prevent adding extension pragma by default. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

fhahn created this revision. fhahn added reviewers: anemet, rjmccall, rsmith, Bigcheese. Herald added subscribers: dexonsmith, tschuett. fhahn requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This patch extends the matrix spec to allow

[clang] b2bc0a3 - Implement P2173 for attributes on lambdas

Author: Aaron Ballman Date: 2021-03-03T10:05:39-05:00 New Revision: b2bc0a32545f9b066fed1631c6fba92a2a5a6d84 URL: https://github.com/llvm/llvm-project/commit/b2bc0a32545f9b066fed1631c6fba92a2a5a6d84 DIFF: https://github.com/llvm/llvm-project/commit/b2bc0a32545f9b066fed1631c6fba92a2a5a6d84.diff

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in b2bc0a32545f9b066fed1631c6fba92a2a5a6d84 and will work on a patch for the remainder of the diagnostic groups. Thanks for the reviews! CHANGES

[clang] cc3d25b - [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

Author: Melanie Blower Date: 2021-03-03T10:11:13-05:00 New Revision: cc3d25be0116fc3cc41a08f8bf9eef73d6dc5d62 URL: https://github.com/llvm/llvm-project/commit/cc3d25be0116fc3cc41a08f8bf9eef73d6dc5d62 DIFF: https://github.com/llvm/llvm-project/commit/cc3d25be0116fc3cc41a08f8bf9eef73d6dc5d62.diff

[PATCH] D97764: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines with no_saved_reg

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcc3d25be0116: [clang][patch] To solve PR26413, x86 interrupt routines may only call routines… (authored by mibintc). Repository: rG LLVM Github Mo

[PATCH] D97805: [clang-query] Add option to enable only displaying main file matches

njames93 added inline comments. Comment at: clang-tools-extra/clang-query/Query.cpp:60-61 +"main-file-only " +"Only match nodes from the main source file. This mode is the " +"default.\n" " set output "

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 327789. arnamoy10 added a comment. Herald added a subscriber: mgorny. Fixing build failures, also moved the pipeline check to an existing file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clan

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

abhina.sreeskantharajan updated this revision to Diff 327790. abhina.sreeskantharajan added a comment. Remove some changes that cause lit failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97785/new/ https://reviews.llvm.org/D97785 Files: c

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

teemperor added a comment. We can (and do) run LIT tests under valgrind, so if you have a test that triggers this valgrind error then that seems like the way to go. I don't think the test has to deterministically fail outside valgrind to be a valid test. Repository: rG LLVM Github Monorepo

[clang] 9403b59 - [test] Fix apparent typo in clang/test/Driver/std.c

Author: Daniel McIntosh Date: 2021-03-03T10:31:47-05:00 New Revision: 9403b59a7dbbf35714b5786df0e535281b926746 URL: https://github.com/llvm/llvm-project/commit/9403b59a7dbbf35714b5786df0e535281b926746 DIFF: https://github.com/llvm/llvm-project/commit/9403b59a7dbbf35714b5786df0e535281b926746.dif

[PATCH] D97796: [test] Fix apparent typo in clang/test/Driver/std.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9403b59a7dbb: [test] Fix apparent typo in clang/test/Driver/std.c (authored by DanielMcIntosh-IBM, committed by abhina.sreeskantharajan). Repositor

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405 + T.getOSVersion(major, minor, micro); + TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7"; +} else if (T.getArch() == llvm::Triple::ppc64le) jsji wro

[PATCH] D97823: Update default arch on AIX

jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); `micro` unsed. Comment at: clang/lib/Driver/ToolChai

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327798. stevewan added a comment. Address comments with regard to handling older AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Drive

[clang] 66799bf - [AIX][clang][driver] Restrict /usr/lib to internal library search paths

Author: David Tenty Date: 2021-03-03T10:48:35-05:00 New Revision: 66799bf0e281099f05b781e5279a7025b1e365cf URL: https://github.com/llvm/llvm-project/commit/66799bf0e281099f05b781e5279a7025b1e365cf DIFF: https://github.com/llvm/llvm-project/commit/66799bf0e281099f05b781e5279a7025b1e365cf.diff L

[PATCH] D97574: [AIX][clang][driver] Restrict /usr/lib to internal library search paths

This revision was automatically updated to reflect the committed changes. Closed by commit rG66799bf0e281: [AIX][clang][driver] Restrict /usr/lib to internal library search paths (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[clang-tools-extra] e7080aa - [clang-query] Fix help text after D91918

Author: Nathan James Date: 2021-03-03T15:57:49Z New Revision: e7080aa2253356effed6c381313a93ec2420b44a URL: https://github.com/llvm/llvm-project/commit/e7080aa2253356effed6c381313a93ec2420b44a DIFF: https://github.com/llvm/llvm-project/commit/e7080aa2253356effed6c381313a93ec2420b44a.diff LOG:

[PATCH] D97806: [clang-query] Fix help text after D91918

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7080aa22533: [clang-query] Fix help text after D91918 (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

This revision was automatically updated to reflect the committed changes. Closed by commit rG19aefd2d5dc3: [clang-tidy] Deprecate readability-deleted-default check (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D97491?vs=326449&id=327802#toc Repository: rG LLVM Git

[clang-tools-extra] 19aefd2 - [clang-tidy] Deprecate readability-deleted-default check

Author: Nathan James Date: 2021-03-03T16:01:13Z New Revision: 19aefd2d5dc3a8d3b8e81219973828170b7fcd2c URL: https://github.com/llvm/llvm-project/commit/19aefd2d5dc3a8d3b8e81219973828170b7fcd2c DIFF: https://github.com/llvm/llvm-project/commit/19aefd2d5dc3a8d3b8e81219973828170b7fcd2c.diff LOG:

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

thakis added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; cjdb wrote: > cjdb wrote: > > aaron.ballman wrote: > > > I'm not 100% certain, but

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327803. stevewan added a comment. Improve handling different AIX versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonA

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg updated this revision to Diff 327805. massberg added a comment. Remove unnecessary checks. After testing locally it turned out that we do not need these checks. If there is an unexpected note, the test fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-function-cognitive-complexity-flags.cpp:16 + // CHECK-NOTES: :[[@LINE-1]]:6: warning: function 'func_of_complexity_4' has cognitive com

[PATCH] D96281: [clang-tidy] Add options to describe individual core increments to readability-function-cognitive-complexity check.

lebedev.ri added a comment. In D96281#2599951 , @lebedev.ri wrote: > If you need help committing this, please specify `name ` to be > used for git commit author field. Comment at: clang-tools-extra/test/clang-tidy/checkers/readabili

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 327804. DiggerLin added a comment. rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/inc

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

courbet added a comment. When bootstrapping LLVM with nsan, there are only a few issues. Several of them stem from using `double` to measure elapsed time in seconds: We measure start time, end time, and subtract them. The resulting error depends on the arbitrary magnitude of the time since epoc

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); jsji wrote: > `micro` unsed. Sorry I missed this comment. I agree t

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

everton.constantino added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( Shouldn't a test for half floating point be added here as well? Repository: rG LLVM Github Monorep

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); stevewan wrote: > jsji wrote: > > `micro`

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Add a new clang-tblgen flag `-gen-clang-opencl-builtin-tests` that generates a .cl file containing calls to every builtin function defined in

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2600160 , @azabaznov wrote: > Check 'isEnabled' is now private: it is used only for non-core or > non-optional core features; > creation of implicit type definitions is guarder with extension support > check; minor re

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. If possible to add a fragment of what is generated it would be great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327825. stevewan added a comment. Reflect varible is unused in its name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonArg

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: clang/test/CoverageMapping/switch.cpp:62 default: // CHECK-NEXT: File 0, [[@LINE]]:3 -> [[@LINE+1]]:10 = #4 break; /

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. I tested this with `FLANG_BUILD_NEW_DRIVER` set to`On` and `Off` - all works fine. It's been a tricky patch @arnamoy10 , thank you for all the effort! I believe that you've addressed a

[PATCH] D97871: Update diagnostic groups for pre-compat warnings

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. As a follow-up to D95691 , add new diagnostic groups named `pre-c++N-compat` to replace the old di

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 327839. Conanap added a comment. Updated 2 test cases and some nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Options.td lld/ELF/Thunks.cpp

[PATCH] D97872: [clang] Don't assert in EmitAggregateCopy on trivial_abi types

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR42961. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97872 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGenC

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, NoQ, xazax.hun, vsavchenko, Eugene.Zelenko. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftw

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong added a comment. In D97849#2600220 , @steakhal wrote: > In D97849#2600201 , @aaron.ballman > wrote: > >> This looks reasonable to me (good catch!), but is there a way for us to add >> a regression test for

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong added a comment. In D97849#2600300 , @teemperor wrote: > We can (and do) run LIT tests under valgrind, so if you have a test that > triggers this valgrind error then that seems like the way to go. I don't > think the test has to deterministically

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

aaron.ballman added a comment. Just a few minor nits from me, but I'm mostly wondering: where are we at with this and are there still substantive changes required? (I looked through the comments, but there's a lot of back-and-forth since Oct and I'm not certain what's holding the patch back cur

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I don't think we have any tests that explicitly use valgrind and testing with valgrind enabled is an optional thing. I would be fine landing this as-is without a test case if it

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. So, what could be the futur of that patch? Would that be okay to merge with a `target_abi` Clang attribute? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 ___

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice, this actually looks like a good simplification in addition to fixing the specific problem. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4650 + // Itanium ABI cal

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 327853. ArcsinX added a comment. - use URIs as keys - create the file list from the keys Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/D97535 Files: clang-tools-extra/clan

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

Meinersbur added a comment. As a contributor to Polly, this makes me happy to see ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97819/new/ https://reviews.llvm.org/D97819 ___ cfe-commits mailing list

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu updated this revision to Diff 327859. zequanwu added a comment. use itanium abi in terminate-statements.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97101/new/ https://reviews.llvm.org/D97101 Files: clang/lib/CodeGen/CoverageMappin

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu added a comment. Thanks for reviewing. Comment at: clang/test/CoverageMapping/switch.cpp:62 default: // CHECK-NEXT: File 0, [[@LINE]]:3 -> [[@LINE+1]]:10 = #4 break; // CHECK-NEXT: Branch,File 0, [[@LINE-1]]:3 -> [[@LINE-1]]:10 = #4, (#0 - #4

[clang-tools-extra] 7d2fba8 - [clangd] ObjC fixes for semantic highlighting and xref highlights

Author: Sam McCall Date: 2021-03-03T20:16:08+01:00 New Revision: 7d2fba8ddb90cf018d9cfc852b68e4584b15678e URL: https://github.com/llvm/llvm-project/commit/7d2fba8ddb90cf018d9cfc852b68e4584b15678e DIFF: https://github.com/llvm/llvm-project/commit/7d2fba8ddb90cf018d9cfc852b68e4584b15678e.diff LO

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d2fba8ddb90: [clangd] ObjC fixes for semantic highlighting and xref highlights (authored by sammccall). Repository: rG LLVM Github Monorepo CHAN

  1   2   >