aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
I don't think we have any tests that explicitly use valgrind and testing with valgrind enabled is an optional thing. I would be fine landing this as-is without a test case if it turns out that testing this is too involved, so I'm accepting the review. However, if it turns out there is a way to test it that others can think of, I would appreciate adding the test coverage (even if it's post-commit). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97849/new/ https://reviews.llvm.org/D97849 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
