[PATCH] D93031: Enable fexec-charset option

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:3583 +def fexec_charset : Separate<["-"], "fexec-charset">, MetaVarName<"">, + HelpText<"Set the execution for string and character literals. " Could you switch to the optio

[clang] 588db1c - [clangd] Use flags from open files when opening headers they include

Author: Sam McCall Date: 2021-03-01T09:43:59+01:00 New Revision: 588db1ccff713332c1f9358f423e682f18c06e8e URL: https://github.com/llvm/llvm-project/commit/588db1ccff713332c1f9358f423e682f18c06e8e DIFF: https://github.com/llvm/llvm-project/commit/588db1ccff713332c1f9358f423e682f18c06e8e.diff LO

[PATCH] D97351: [clangd] Use flags from open files when opening headers they include

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG588db1ccff71: [clangd] Use flags from open files when opening headers they include (authored by sammccall

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek abandoned this revision. phosek added a comment. No longer needed with `-fcoverage-compilation-dir`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

awarzynski updated this revision to Diff 327048. awarzynski marked an inline comment as done. awarzynski added a comment. Move the call to setUpFrontendBasedOnAction after all options have been set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

awarzynski added inline comments. Comment at: flang/lib/Frontend/CompilerInvocation.cpp:88-95 +// Tweak the frontend configuration based on the frontend action +static void setUpFrontendBasedOnAction(FrontendOptions &opts) { + assert(opts.programAction_ != Fortran::frontend::Inv

[clang] 80e8efd - Use a fast path when initializing LineOffsetMapping

Author: serge-sans-paille Date: 2021-03-01T10:18:36+01:00 New Revision: 80e8efd563fda4d7b125b834d3243b3ef9a05270 URL: https://github.com/llvm/llvm-project/commit/80e8efd563fda4d7b125b834d3243b3ef9a05270 DIFF: https://github.com/llvm/llvm-project/commit/80e8efd563fda4d7b125b834d3243b3ef9a05270.d

[PATCH] D97320: Use a fast path when initializing LineOffsetMapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80e8efd563fd: Use a fast path when initializing LineOffsetMapping (authored by serge-sans-paille). Herald added a project: clang. Herald added a subs

[PATCH] D97615: [clangd] Include macro expansions in documentSymbol hierarchy

kadircet added a comment. thanks, LGTM. with a couple nits and asking for some extra clarifications :) Comment at: clang-tools-extra/clangd/FindSymbols.cpp:283 + public: +SymBuilder() = default; + nit: drop this one? Comment at: clang-to

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 created this revision. benshi001 added reviewers: dylanmckay, MaskRay, aykevl. Herald added a subscriber: Jim. benshi001 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. Herald added a subscriber: ormris. The wrong `stdio.h` (usr/include/stdio.h) is included with a simple a.c like #include ... However the expected one is avr-libc's `stdio.h`, and this patch add avr-libc's include/ to clang system include paths. Repository: rG

[clang] 965f24d - [Driver] Don't litter the source directory in test

Author: Benjamin Kramer Date: 2021-03-01T11:20:13+01:00 New Revision: 965f24d4dbd6bc8905de75150d36c693d4396bfd URL: https://github.com/llvm/llvm-project/commit/965f24d4dbd6bc8905de75150d36c693d4396bfd DIFF: https://github.com/llvm/llvm-project/commit/965f24d4dbd6bc8905de75150d36c693d4396bfd.dif

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks for noticing and fixing it! Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:41 E.setSymbolCategory(RandInt(

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); it feels weird to choose one or the other here, why not jus

[clang] 1b04bdc - [SEH] capture 'this'

Author: Olivier Goffart Date: 2021-03-01T11:57:35+01:00 New Revision: 1b04bdc2f3ffaa7a0e1e3dbdc3a0cd08f0b9a4ce URL: https://github.com/llvm/llvm-project/commit/1b04bdc2f3ffaa7a0e1e3dbdc3a0cd08f0b9a4ce DIFF: https://github.com/llvm/llvm-project/commit/1b04bdc2f3ffaa7a0e1e3dbdc3a0cd08f0b9a4ce.dif

[PATCH] D97534: SEH: capture 'this'

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b04bdc2f3ff: [SEH] capture 'this' (authored by ogoffart). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97534/new/ https://reviews.llvm.org/D97534 Files:

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I have serious concerns inline. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:20 int DoubleDerived::*ddf = &Base::field; int Base

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/reinterpret-cast-pointer-to-member.cpp:43-50 +struct A {}; +struct B : public A {}; +struct C { + int field; +}; +struct D : public C {}; +struct E : public B, public D {};

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

balazske abandoned this revision. balazske added a comment. Checks about code formatting are likely not to be accepted. Formatting can be done in external tool and is not subject for checks. The difference is that it is not possible to format separately for one rule only (with clang-format). But

[PATCH] D97630: [clang-tidy] Added option to uniqueptr delete release check

njames93 updated this revision to Diff 327077. njames93 added a comment. Add tests to ensure Parens are handled correctly. Add support for pointers to and smart pointers to unique_ptr objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97630/new/

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

AMDChirag added a comment. LGTM. I'll let someone else review the patch if required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 ___ cfe-commits mailing list

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: LLVM, clang, OpenMP. Herald added subscribers: jfb, guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. M

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

jhuber6 added a comment. Fixing tests is WIP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://reviews.llvm.org/D97680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D97681: [ASTMatchers] Add matchers for `CXXDeleteExpr`

njames93 created this revision. njames93 added reviewers: klimek, aaron.ballman, steveire. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `deletes` traveral matcher which matches on the expression being delete Extend `CXXNewEx

[PATCH] D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end).

ZarkoCA accepted this revision. ZarkoCA added a comment. It may be better to use `__builtin_va_list` and the like instead of the header inclusion but I don't want to make the test change too onerous if that turns out to be the case. Comment at: clang/test/CodeGen/aix-altivec-

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is the only remaining check that creates `std::move` includ

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); kadircet wrote: > it feels weird to choose one or the other

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

kbobyrev added a comment. In D96975#2594147 , @njames93 wrote: > Ping Hi Nathan! Thanks again for this patch and sorry for not taking time to review it yet. It is a busy week for me and my team, so I wasn't able to do much coding/reviewing, apologies fo

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: Tabs here instead of spaces. I think this is the right fix fo

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp:22 +: ClangTidyCheck(Name, Context), + Inserter(Options.getLocalOrGlobal("IncludeStyle", +utils::IncludeSorter::IS_L

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 __

[PATCH] D97614: [clang-tidy] Remove OptionError

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, nice cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97614/new/ https://reviews.llvm.org/D97614

[PATCH] D97681: [ASTMatchers] Add matchers for `CXXDeleteExpr`

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7621 +/// matches the expression 'delete Ptr'. +AST_MATCHER_P_OVERLOAD(CXXDeleteExpr, deletes, internal::Matcher, + InnerMatcher, 1) { Why add t

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp:22 +: ClangTidyCheck(Name, Context), + Inserter(Options.getLocalOrGlobal("IncludeStyle", +utils::IncludeSorter::IS_LLVM))

[PATCH] D97687: [SEH] Fix capture of this in lambda functions

ogoffart created this revision. ogoffart added a reviewer: rnk. ogoffart requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit 1b04bdc2f3ffaa7a0e1e3dbdc3a0cd08f0b9a4ce

[PATCH] D97688: clang-format: use `ph` as a canonical raw string delimiter for google style

krasimir created this revision. krasimir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97688 Files: clang/lib/Format/Format.cpp Index: clang/lib/Format/Format.cpp =

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

stefanp added a comment. Comments relate to just cleaning up the patch a little. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8593 + return !convertToNonDenormSingle(ArgAPFloat); +} + I'm wondering if it would not be better to just inline this. It's

[PATCH] D97491: [clang-tidy] Deprecate readability-deleted-default check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D97491#2589098 , @Eugene.Zelenko wrote: > In D97491#2589097 , @njames93 wrote: > >> In D97491

[PATCH] D97681: [ASTMatchers] Add matchers for `CXXDeleteExpr`

njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7621 +/// matches the expression 'delete Ptr'. +AST_MATCHER_P_OVERLOAD(CXXDeleteExpr, deletes, internal::Matcher, + InnerMatcher, 1) { aaron.ballman

[PATCH] D97688: clang-format: use `ph` as a canonical raw string delimiter for google style

krasimir updated this revision to Diff 327120. krasimir added a comment. clang-format: use `pb` as a canonical raw string delimiter for google style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97688/new/ https://reviews.llvm.org/D97688 Files:

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: erichkeane wrote: > Tabs here instead of spaces. > > I think this

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326980. khchen marked 17 inline comments as done. khchen added a comment. 1. address @jrtc27's suggestions, thanks. 2. fix several bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.l

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:56 +// +// e: type of "t" as is (identity) +// v: computes a vector type whose element type is "t" for the current LMUL jrtc27 wrote: > khchen wrote: > > jrtc27 wrote: > > > D

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:50 +Boolean, +SignInteger, +UnsignedInteger, Signed Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:58-62 + bool IsPointer = false; + // IsConstan

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: pmrao wrote: > erichkeane wrote: > > Tabs here instead of spac

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

pmrao marked an inline comment as not done. pmrao added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: erichkeane wrote: > pmr

[PATCH] D97681: [ASTMatchers] Add matchers for `CXXDeleteExpr`

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7621 +/// matches the expression 'delete Ptr'. +AST_MATCHER_P_OVERLOAD(CXXDeleteExpr, deletes, internal::Matcher, + InnerMatcher, 1) { njames93

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1946 +FunctionEmissionStatus FES = getEmissionStatus(FD); +switch (FES) { +case FunctionEmissionStatus::Emitted: pmrao wrote: > erichkeane wrote: > > pmrao wrote: > > > erichk

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop updated this revision to Diff 327123. russell.gallop added a comment. Update with suggested changes to MinGW.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96120/new/ https://reviews.llvm.org/D96120 Files: clang/lib/Driver/ToolChains/MSVC.cpp clang/lib/Driver/Tool

[PATCH] D96120: [scudo] Port scudo sanitizer to Windows

russell.gallop added a comment. In D96120#2591368 , @mstorsjo wrote: > Yes, it would need something similar - I tried whipping something together, > which after some tweaks seems to work: > Feel free to squash that into your patch (which saves me a bit of

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

ldionne added a comment. I don't have an opinion about the attribute itself. I do have an opinion about using that attribute in libc++ instead of fixing the underlying issue (I think we shouldn't do it). Can you confirm what the problematic types are? In another patch I saw `__hash_node`, `__ha

[PATCH] D97693: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: arphaman, mgorny. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA causes clang-tools-extra tools to be included

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2593229 , @timwoj wrote: > In D94500#2592448 , > @HazardyKnusperkeks wrote: > >> Do you need someone to push this? > > Yes I do. I don't have committer access. Please

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: jansvoboda11, dang. thakis requested review of this revision. https://reviews.llvm.org/D97695 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-option

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Probably worth explaining in the description why this is useful from clang-cl (it being on by default, and we'd like a nice way to turn it off). CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D97573: [OpenMP] Handle non-function context before checking for diagnostic emission

jdoerfert added a comment. looks reasonable to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97573/new/ https://reviews.llvm.org/D97573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 83feaa3 - [clang-cl] make -f(no-)ident a CoreOption

Author: Nico Weber Date: 2021-03-01T11:53:51-05:00 New Revision: 83feaa36ad53ce93ed808169d3316ed757703e47 URL: https://github.com/llvm/llvm-project/commit/83feaa36ad53ce93ed808169d3316ed757703e47 DIFF: https://github.com/llvm/llvm-project/commit/83feaa36ad53ce93ed808169d3316ed757703e47.diff LO

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83feaa36ad53: [clang-cl] make -f(no-)ident a CoreOption (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D97695: [clang-cl] make -f(no-)ident a CoreOption

thakis added a comment. Thanks! Landed with a more detailed commit description in https://reviews.llvm.org/rG83feaa36ad53ce93ed808169d3316ed757703e47 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97695/new/ https://reviews.llvm.org/D97695 ___

[PATCH] D97693: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97693/new/ https://reviews.llvm.org/D97693 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] 21280d3 - [clang] SimpleMFlag helper in Options.td

Author: Stanislav Mekhanoshin Date: 2021-03-01T09:00:30-08:00 New Revision: 21280d35d652788309176831bd88257b58f674f9 URL: https://github.com/llvm/llvm-project/commit/21280d35d652788309176831bd88257b58f674f9 DIFF: https://github.com/llvm/llvm-project/commit/21280d35d652788309176831bd88257b58f674

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze created this revision. zukatsinadze added reviewers: NoQ, vsavchenko, Charusso, Szelethus, martong. zukatsinadze added a project: clang. Herald added subscribers: steakhal, ASDenysPetrov, ormris, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xaz

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. Please suggest which package to use for the checker. CERT rules are ENV, however, it deals with non-ENV functions as well. Also, I am having a problem with `checkDeadSymbols`, it is similar to one xazax.hun faced here: http://reviews.llvm.org/D14203 (many many year

[PATCH] D97681: [ASTMatchers] Add matchers for `CXXDeleteExpr`

njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7621 +/// matches the expression 'delete Ptr'. +AST_MATCHER_P_OVERLOAD(CXXDeleteExpr, deletes, internal::Matcher, + InnerMatcher, 1) { aaron.ballman

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

int3 updated this revision to Diff 327145. int3 added a comment. keep around darwinnew link for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95204/new/ https://reviews.llvm.org/D95204 Files: clang/lib/Driver/ToolChain.cpp clang/test/Drive

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 327146. dgoldman added a comment. Add comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-too

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG415c0cd698a8: [lld-macho] Switch default to new Darwin backend (authored by int3). Herald added a project: lld-macho. Changed prior to commit: htt

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 327150. zukatsinadze added a comment. Fixed docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 Files: clang/docs/analyzer/checkers.rst clang/include/clang/S

[clang-tools-extra] 5a2141e - [clangd] Improve document symbols support for Objective-C categories and methods

Author: David Goldman Date: 2021-03-01T12:37:31-05:00 New Revision: 5a2141e3a08ccaacbdb8faf64a47347531b015e0 URL: https://github.com/llvm/llvm-project/commit/5a2141e3a08ccaacbdb8faf64a47347531b015e0 DIFF: https://github.com/llvm/llvm-project/commit/5a2141e3a08ccaacbdb8faf64a47347531b015e0.diff

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2141e3a08c: [clangd] Improve document symbols support for Objective-C categories and methods (authored by dgoldman). Repository: rG LLVM Github

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327155. ychen added a comment. - Add clang Diagnostic Category/Group/Kinds for SourceMgr errors - Add comments in MCContext - Simplify Clang handler - Implement DiagnosticInfoSrcMgr::print - Simplify DiagnosticInfoSrcMgr ctor Repository: rG LLVM Github Monor

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:477 + StringRef Message = D.getMessage(); + if (Message.startswith("error: ")) +Message = Message.substr(7); MaskRay wrote: > `StringRef::consume_front` > > I know you are moving

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen added inline comments. Comment at: llvm/lib/MC/MCContext.cpp:870 +std::function GetMessage) { + SourceMgr SM; + const SourceMgr *SMP = &SM; MaskRay wrote: > This looks a bit strange: we need to construct a fresh SourceMgr to print a > diagnostic. I'v

[PATCH] D86376: [HIP] Emit kernel symbol

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. So, to summarize how the patch changes the under-the-hood kernel launch machinery: - device-side is unchanged. Kernel function is generated with the real kernel name - host-side stub is still gener

[clang-tools-extra] 82289aa - [clang-tidy] Remove OptionError

Author: Nathan James Date: 2021-03-01T17:55:17Z New Revision: 82289aa6c88ad9840369db294cc66ed829e8c435 URL: https://github.com/llvm/llvm-project/commit/82289aa6c88ad9840369db294cc66ed829e8c435 DIFF: https://github.com/llvm/llvm-project/commit/82289aa6c88ad9840369db294cc66ed829e8c435.diff LOG:

[PATCH] D97614: [clang-tidy] Remove OptionError

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82289aa6c88a: [clang-tidy] Remove OptionError (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze added a comment. Attaching results of CodeChecker run on some projects.F15697529: cc_results.zip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 __

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen updated this revision to Diff 327162. ychen added a comment. - Use StringRef::consume_front Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97449/new/ https://reviews.llvm.org/D97449 Files: clang/include/clang/Basic/DiagnosticCategories.td

[PATCH] D97702: [clang][modules] Use extensible RTTI for ModuleFileExtension

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang exposes an interface for extending the PCM/PCH file format: `ModuleFileExtension`.

[PATCH] D97608: Move EntryExitInstrumentation pass location

aeubanks updated this revision to Diff 327164. aeubanks added a comment. Herald added subscribers: kerbowa, atanasyan, jrtc27, nhaehnle, jvesely, nemanjai, sdardis. missed non-x86 tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97608/new/ http

[PATCH] D97608: Move EntryExitInstrumentation pass location

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG040c1b49d7a7: Move EntryExitInstrumentation pass location (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 040c1b4 - Move EntryExitInstrumentation pass location

Author: Arthur Eubanks Date: 2021-03-01T10:08:10-08:00 New Revision: 040c1b49d7a7eaa23d883ca363744944f5597d92 URL: https://github.com/llvm/llvm-project/commit/040c1b49d7a7eaa23d883ca363744944f5597d92 DIFF: https://github.com/llvm/llvm-project/commit/040c1b49d7a7eaa23d883ca363744944f5597d92.diff

[clang] 3f40dbb - [PowerPC][AIX] Enable passing vectors in variadic functions.

Author: Sean Fertile Date: 2021-03-01T13:08:28-05:00 New Revision: 3f40dbbbc71d28f6ad0bd616fe009bde861362ed URL: https://github.com/llvm/llvm-project/commit/3f40dbbbc71d28f6ad0bd616fe009bde861362ed DIFF: https://github.com/llvm/llvm-project/commit/3f40dbbbc71d28f6ad0bd616fe009bde861362ed.diff

[PATCH] D97474: [PowerPC][AIX] Enable passing vectors in variadic functions (front-end).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f40dbbbc71d: [PowerPC][AIX] Enable passing vectors in variadic functions. (authored by sfertile). Changed prior to commit: https://reviews.llvm.o

[PATCH] D97510: [AArch64][Docs] Release notes 12.x on outline atomics

ilinpv closed this revision. ilinpv added a comment. Tim, thank you for review, noticed typos and overall support to outline atomics patches! Notes pushed rG98f06b16a313ece593f5711778d7da9037f3a2ef Repository: rG LLVM Gith

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

zukatsinadze updated this revision to Diff 327173. zukatsinadze added a comment. Removed code repetition from the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 Files: clang/docs/analyzer/checkers

[PATCH] D97632: [clang-tidy] Simplify diagnostics for UniqueptrResetRelease check

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit with the diagnostic wording. Comment at: clang-tools-extra/clang-tidy/misc/UniqueptrResetReleaseCheck.cpp:115 + auto D = diag(ResetMember

[PATCH] D91164: [clang-tidy] Improve C++ support in bugprone-signal-handler.

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:100-101 const LangOptions &LangOpts) const { - // FIXME: Make the checker useful on C++ code. - if (LangOpts.CPlusPlus) + // FIXME: Improve C++ support. + if (LangOpt

[PATCH] D87321: Fix -gz=zlib options for linker

emaste added a comment. I just ran into this issue on FreeBSD, bug report in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253942 clang/lib/Driver/ToolChains/FreeBSD.cpp needs updating for this change also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

poelmanc updated this revision to Diff 327174. poelmanc added a comment. Fix comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97620/new/ https://reviews.llvm.org/D97620 Files: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp Index: clang-tools

[clang-tools-extra] 52b8e10 - [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

Author: Nico Weber Date: 2021-03-01T13:21:59-05:00 New Revision: 52b8e10597315a96bc7cbc7cfe618e301c1e6e6c URL: https://github.com/llvm/llvm-project/commit/52b8e10597315a96bc7cbc7cfe618e301c1e6e6c DIFF: https://github.com/llvm/llvm-project/commit/52b8e10597315a96bc7cbc7cfe618e301c1e6e6c.diff LO

[PATCH] D97693: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA

This revision was automatically updated to reflect the committed changes. Closed by commit rG52b8e1059731: [libclang] Remove LIBCLANG_INCLUDE_CLANG_TOOLS_EXTRA (authored by thakis). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D97693?vs=327127&id=327175#toc

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

poelmanc marked an inline comment as done. poelmanc added a comment. Fixed comment as requested (keys()->size().) I don't have commit access so if you can push it that would be great, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97620/new/ https://reviews.llvm.org/D97620

[clang] 283db5f - BPF: fix enum value 0 issue for __builtin_preserve_enum_value()

Author: Yonghong Song Date: 2021-03-01T10:23:24-08:00 New Revision: 283db5f0837d55f91242812003adf6e189ba743e URL: https://github.com/llvm/llvm-project/commit/283db5f0837d55f91242812003adf6e189ba743e DIFF: https://github.com/llvm/llvm-project/commit/283db5f0837d55f91242812003adf6e189ba743e.diff

[PATCH] D97659: BPF: fix enum value 0 issue for __builtin_preserve_enum_value()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG283db5f0837d: BPF: fix enum value 0 issue for __builtin_preserve_enum_value() (authored by yonghong-song). Repository: rG LLVM Github Monorepo CH

[PATCH] D97706: Make -f[no-]split-dwarf-inlining CC1 default align with driver default (no inlining)

MaskRay created this revision. MaskRay added a reviewer: dblaikie. Herald added subscribers: jansvoboda11, dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Verified that the below is still true: - `clang -g` => `splitDebugInli

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

dgoldman added a comment. In D97617#2592424 , @sammccall wrote: > (not really sure why this suddenly seemed important to me, but if you don't > have semantic highlighting on, you're missing out!) Thanks! Comment at: clang-tools-extra/

[clang-tools-extra] 8adfb38 - [clang-tidy] Simplify diagnostics for UniqueptrResetRelease check

Author: Nathan James Date: 2021-03-01T18:40:37Z New Revision: 8adfb38224697afca205343c0e1a49bd03ecfc09 URL: https://github.com/llvm/llvm-project/commit/8adfb38224697afca205343c0e1a49bd03ecfc09 DIFF: https://github.com/llvm/llvm-project/commit/8adfb38224697afca205343c0e1a49bd03ecfc09.diff LOG:

  1   2   3   >