ldionne added a comment.

I don't have an opinion about the attribute itself. I do have an opinion about 
using that attribute in libc++ instead of fixing the underlying issue (I think 
we shouldn't do it). Can you confirm what the problematic types are? In another 
patch I saw `__hash_node`, `__hash_value_type`, `__tree_node` and 
`__value_type`. Is that it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97411/new/

https://reviews.llvm.org/D97411

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to