kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292
+ for (const auto &Sym : *Slab) {
+ if (Sym.Definition)
+ Files.insert(Sym.Definition.FileURI);
----------------
it feels weird to choose one or the other here, why not just insert both (after
checking if definition exists, ofc).
We are likely to have a merged symbol information anyway, and the logic here
will likely result in no index owning the header files, unless there are some
symbols *defined* (not just declared) in it.
This will likely result in some overshooting as knowing about a symbols
declaration location doesn't mean indexing that particular file. But so does
the current version, as knowing about definition location might be because of a
merged symbol, rather than indexing of particular file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97535/new/
https://reviews.llvm.org/D97535
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
