[PATCH] D97223: Add Alignment argument to IRBuilder CreateAtomicRMW and CreateAtomicCmpXchg.

gchatelet accepted this revision. gchatelet added a comment. LGTM as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97223/new/ https://reviews.llvm.org/D97223 ___ cfe-commits mailing list cfe-commits

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

whisperity added a comment. In D97297#2583391 , @Eugene.Zelenko wrote: > Please mention new option in Release Notes. The base check is not yet accepted or in. I plan to land the entire thing in one go once everything is accepted because a partial landin

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap updated this revision to Diff 326000. Conanap marked 6 inline comments as done. Conanap added a comment. Addressed some nits and a problem where sometimes the compiler would spill half way through materialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https:/

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.h:1321 bool convertToNonDenormSingle(APFloat &ArgAPFloat); + bool checkNonDenormCannotConvertToSingle(APInt &ArgAPInt); + bool checkNonDenormCannotConvertToSingle(APFloat &ArgAPFloat); ---

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 updated this revision to Diff 326002. LiuChen3 added a comment. Address Pengfei and Yuanke's comments. We don't need more tile type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews.llvm.org/D97358 Files: clang/i

[PATCH] D82547: [Debugify] Expose original debug info preservation check as CC1 option

djtodoro updated this revision to Diff 326005. djtodoro retitled this revision from "[VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option" to "[Debugify] Expose original debug info preservation check as CC1 option". djtodoro added a comment. Herald added subscribers: jans

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `-Wreturn-std-move-in-c++11` has been removed in fbee4a0c79cc4ee87c34e51342742a5bc6fcf872

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. In D88220#2583486 , @aaronpuchert wrote: > In D88220#2581538 , @aaron.ballman > wrote: > >> We usually rely on the release notes to say something, but we didn't do that >> here. > > P

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews.llvm.org/D97358 __

[clang] 85eb12e - [OpenCL] Add declarations with enum/typedef args

Author: Sven van Haastregt Date: 2021-02-24T09:27:35Z New Revision: 85eb12eefdf6a95afc49bc66df41738d19702977 URL: https://github.com/llvm/llvm-project/commit/85eb12eefdf6a95afc49bc66df41738d19702977 DIFF: https://github.com/llvm/llvm-project/commit/85eb12eefdf6a95afc49bc66df41738d19702977.diff

[clang] 0344aea - [OpenCL] Add ndrange builtin functions to TableGen

Author: Sven van Haastregt Date: 2021-02-24T09:27:36Z New Revision: 0344aea6ea379d945d1de1f5c258414dc61ccacd URL: https://github.com/llvm/llvm-project/commit/0344aea6ea379d945d1de1f5c258414dc61ccacd DIFF: https://github.com/llvm/llvm-project/commit/0344aea6ea379d945d1de1f5c258414dc61ccacd.diff

[PATCH] D96860: [OpenCL] Add declarations with enum/typedef args

This revision was automatically updated to reflect the committed changes. Closed by commit rG85eb12eefdf6: [OpenCL] Add declarations with enum/typedef args (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96860/new/ https://review

[PATCH] D97060: [OpenCL] Add ndrange builtin functions to TableGen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0344aea6ea37: [OpenCL] Add ndrange builtin functions to TableGen (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D61112: AMDGPU: Enable _Float16

foad added a comment. Herald added a subscriber: kerbowa. Should have updated https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point "_Float16 is currently only supported on the following targets, with further targets pending ABI standardization: ..." CHANGES SINCE

[PATCH] D97366: [clangd] Fix a race

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo http

[PATCH] D97366: [clangd] Fix a race

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97366/new/ https://reviews.llvm.org/D97366

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326022. zero9178 added a comment. Undid refactoring of getCompilerRTBasename. Previous diffs introduced a new internal function that built the basename. In that version getCompilerRTBasename simply called getCompilerRT and extracted the filename component.

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

svenvh added a comment. Some minor typos and requests for clarifications, looks like reasonable guidelines other than that. Comment at: clang/docs/OpenCLSupport.rst:175 + +If extensions modifies the standard parsing they need to be added to +the clang frontend source code. Thi

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

darwin added a comment. Hi guys, thanks for accepting the change. But I don't have have commit access of LLVM. Can someone commit it for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137

[PATCH] D97370: [clang][cli] Remove marshalling from Opt{In, Out}FFlag

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can now express all marshalling semantics in `Opt{In,O

[PATCH] D97371: [clang][parser] Remove questionable ProhibitAttributes() call in objc parsing

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang uses GNU-style attributes in objc code in (for example, I guess?) `tests/Parser/stmt-attributes.m`

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 requested review of this revision. zero9178 added a comment. I think this change, while functionality fixing the same as my previous diff, but also fixing the test failure, does deviate a bit from the original review, so I'd like it to be reviewed again if that isn't a problem. CHANGE

[PATCH] D97366: [clangd] Fix a race

This revision was automatically updated to reflect the committed changes. Closed by commit rGc94ecf3f81ca: [clangd] Fix a race (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97366/new/ https://reviews.llvm.org/D97366 Files:

[clang-tools-extra] c94ecf3 - [clangd] Fix a race

Author: Kadir Cetinkaya Date: 2021-02-24T12:15:16+01:00 New Revision: c94ecf3f81ca42a98b3b279a7b210b67715f1c41 URL: https://github.com/llvm/llvm-project/commit/c94ecf3f81ca42a98b3b279a7b210b67715f1c41 DIFF: https://github.com/llvm/llvm-project/commit/c94ecf3f81ca42a98b3b279a7b210b67715f1c41.dif

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

LiuChen3 added a comment. I don't know why pre-merge-checks failed. I can check-all successfully locally in redhat8. I don't have debian mainchine to reproduce this problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97358/new/ https://reviews

[PATCH] D97375: [clang][cli] Add MarshallingInfoEnum multiclass

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch introduces a tablegen multic

[PATCH] D97351: [clangd] Use flags from open files when opening headers they include

sammccall updated this revision to Diff 326042. sammccall added a comment. Herald added a subscriber: jfb. Record memory usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97351/new/ https://reviews.llvm.org/D97351 Files: clang-tools-extra/clan

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:148 + // If HasMask, this flag states that this builtin has a maskedoff operand. It + // is always the first operand. + bit HasMaskedOffOperand = true; Isn't mask the fir

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:567 + // Compute type transformers + for (char I : Transformer.take_front(Transformer.size() - 1)) { +switch (I) { Can we do Transformer = Transformer.drop_back() right b

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added a comment. In D95691#2572114 , @aaron.ballman wrote: > In D95691#2545808 , @aaron.ballman > wrote: > >> Updated based on review feedback. > > Ping Ping CHANGES SINCE LAST ACTION https://re

[clang] abbdb56 - [OpenCL] Allow taking address of functions as an extension.

Author: Anastasia Stulova Date: 2021-02-24T12:32:02Z New Revision: abbdb5639c70d167bd66cd62296927330782c3b4 URL: https://github.com/llvm/llvm-project/commit/abbdb5639c70d167bd66cd62296927330782c3b4 DIFF: https://github.com/llvm/llvm-project/commit/abbdb5639c70d167bd66cd62296927330782c3b4.diff

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGabbdb5639c70: [OpenCL] Allow taking address of functions as an extension. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10252 namespace { -void CheckFreeArgumentsOnLvalue(Sema &S, const std::string &CalleeName, -const UnaryOperator *UnaryExpr, -const Var

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; rnk wrote: > aaron.ballman wrote: > > Quuxplusone wrote: > > > aaron.ballman wrote: > > > > ahatanak

[PATCH] D97251: [llvm] Add assertions for the smart pointers with the possibility to be null in ClangAttrEmitter

aaron.ballman added a comment. In D97251#2583843 , @OikawaKirie wrote: > @aaron.ballman > > My only concern is the recursive call to this function on line 1359. If you > think it is also OK for the recursive call on line 1359, I will update the > patch a

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

pengfei added inline comments. Comment at: llvm/include/llvm/CodeGen/Passes.h:496 + + /// The pass transform amx intrinsics to scalar operation if the function has + /// optnone attribute or it is O0. transforms Comment at: llvm/lib/Target/X8

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia updated this revision to Diff 326055. Anastasia added a comment. Added suggestions from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97072/new/ https://reviews.llvm.org/D97072 Files: clang/docs/OpenCLSupport.rst Index: clang/docs/OpenCLSupport.rst =

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

Anastasia added inline comments. Comment at: clang/docs/OpenCLSupport.rst:196 +If an extension adds the functionality that does not modify standard language +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via librar

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. Should this be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D97322: [clang-tidy][test] Allow specifying potentially unused suffixes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97322/new/ https://reviews.llvm.org/D97322 __

[PATCH] D96209: [clang-tidy] Fix readability-avoid-const-params-in-decls removing const in template paramaters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, what a nice simplification! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96209/new/ https://reviews.llvm.org/D96209 __

[PATCH] D61112: AMDGPU: Enable _Float16

arsenm added inline comments. Comment at: test/CodeGenCXX/amdgpu-float16.cpp:7 + _Float16 x, y, z; + // CHECK: v_add_f16_e64 + // NOF16: v_add_f32_e64 I thought clang tests were supposed to stop at the IR CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4050 << ", mem=" << ProcStat->PeakMemory << " Kb\n"; - } - if (!StatReportFile.empty()) { + } else { // CSV format. vvereschaka wrote: > aganea wrote:

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini added a comment. Some relatively minor comments, overall direction seems good to me. Comment at: clang/include/clang/Basic/OpenCLOptions.h:67 public: struct OpenCLOptionInfo { // Option starts to be available in this OpenCL version In OpenCL

[PATCH] D61112: AMDGPU: Enable _Float16

yaxunl marked an inline comment as done. yaxunl added a comment. In D61112#2584279 , @foad wrote: > Should have updated > https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point > "_Float16 is currently only supported on the fol

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

t.p.northover added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:304 + if (llvm::Error E = Context.getTargetInfo().isValidSectionSpecifier(SecName)) +Diag(PragmaLoc, diag::err_pragma_section_invalid_for_target) Shouldn't this block return so th

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan added a comment. @ASDenysPetrov are you running python inside MSYS bash that is installed by > pacman -S --needed base-devel mingw-w64-x86_64-toolchain ? I learned that the python should give different output >>> sys.platform msys >>> platform.system() MSYS_NT-10

[PATCH] D97297: [clang-tidy] Suppress reports to patternedly named parameters in 'bugprone-easily-swappable-parameters'

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-easily-swappable-parameters.rst:89 +warning about the two parameters are silenced. +Defaults to ``1``. +Might be any positive integer. whisperity wrot

[clang-tools-extra] b90fdb7 - [clang-tidy][test] Allow specifying potentially unused suffixes

Author: Nathan James Date: 2021-02-24T15:22:54Z New Revision: b90fdb7c117fab83a8a2d1c95ed468c47e480f89 URL: https://github.com/llvm/llvm-project/commit/b90fdb7c117fab83a8a2d1c95ed468c47e480f89 DIFF: https://github.com/llvm/llvm-project/commit/b90fdb7c117fab83a8a2d1c95ed468c47e480f89.diff LOG:

[PATCH] D97322: [clang-tidy][test] Allow specifying potentially unused suffixes

This revision was automatically updated to reflect the committed changes. Closed by commit rGb90fdb7c117f: [clang-tidy][test] Allow specifying potentially unused suffixes (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97322/new

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @abhina.sreeskantharajan wrote: > @ASDenysPetrov are you running python inside MSYS bash? that is installed by No, I installed Python as usual via Windows msi got from official site. Here is what I've got from Python: >>> sys.platform 'win32' >>> platform.syste

[PATCH] D97361: [clang-tidy] Add misc-redundant-using check

Eugene.Zelenko added a comment. I think this check belongs to `readability` module. Comment at: clang-tools-extra/clang-tidy/misc/RedundantUsingCheck.cpp:1 +//===--- RedundantUsingCheck.cpp - clang-tidy +//===// Please make singl

[PATCH] D97386: update AMDGPU _Float16 support in clang doc

yaxunl created this revision. yaxunl added reviewers: foad, arsenm, rampitec. Herald added subscribers: t-tye, tpr, dstuttard, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D97386 Files: clang/docs/LanguageExtensions.rst Index: c

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, xazax.hun, NoQ, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. ASDenysPetro

[PATCH] D97375: [clang][cli] Add MarshallingInfoEnum multiclass

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97375/new/ https://reviews.llvm.org/D97375

[PATCH] D97370: [clang][cli] Remove marshalling from Opt{In, Out}FFlag

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97370/new/ https://reviews.llvm.org/D97370

[clang-tools-extra] a34532c - [clang-tidy] Fix readability-avoid-const-params-in-decls removing const in template paramaters

Author: Nathan James Date: 2021-02-24T15:54:10Z New Revision: a34532c330f61c35612bb0c4b753979307020608 URL: https://github.com/llvm/llvm-project/commit/a34532c330f61c35612bb0c4b753979307020608 DIFF: https://github.com/llvm/llvm-project/commit/a34532c330f61c35612bb0c4b753979307020608.diff LOG:

[PATCH] D96209: [clang-tidy] Fix readability-avoid-const-params-in-decls removing const in template paramaters

This revision was automatically updated to reflect the committed changes. Closed by commit rGa34532c330f6: [clang-tidy] Fix readability-avoid-const-params-in-decls removing const in… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326104. khchen marked 10 inline comments as done. khchen added a comment. 1. Rebase 2. Address Craig's comments. 3. Change the operand orders of builtin to the same order of IR intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:899 +// (operand) in ProtoSeq. ProtoSeq[0] is output operand. +SmallVector ProtoSeq; +const StringRef Primaries("evwqom0ztc"); craig.topper wrote: > I think this is somet

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97364/new/ https://reviews.llvm.org/D97364

[PATCH] D97361: [clang-tidy] Add misc-redundant-using check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantUsingCheck.cpp:23 + Finder->addMatcher( + usingDecl(isExpansionInMainFile()).bind("using-declaration"), this); + Finder->addMatcher( Why restrict these to main file only

[PATCH] D88220: [C++20] P1825R0: More implicit moves

amccarth added a comment. The option is used in the wild, but not as widely as I first believed. We've already fixed a couple projects that were using it. I think the Release Note is the right solution. Thanks for doing that. I withdraw my suggestion to allow and ignore. Repository: rG

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:304 + if (llvm::Error E = Context.getTargetInfo().isValidSectionSpecifier(SecName)) +Diag(PragmaLoc, diag::err_pragma_section_invalid_for_target) t.p.northover wrote: > Shouldn't this

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326107. khchen marked 2 inline comments as done. khchen added a comment. address https://reviews.llvm.org/D95016?id=324197#inline-912573 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.l

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

mantognini added a comment. Some minor comments. Comment at: clang/docs/OpenCLSupport.rst:197 +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via libraries (by adding new non-native +types or functions) parsed reg

[PATCH] D96838: Add GNU attribute 'retain'

probinson added a comment. Aha; attribute `used` *by itself* is not sufficient to preserve sections in the output. But the `__start_/__stop_` symbols implicitly create a reference to each of the named sections, and that implicit reference can preserve them in the output (assuming gc roots etc)

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Replacing `CC1Args.push_back("-emit-llvm-bc");` with `CC1Args.push_back("-emit-llvm-bc");` as suggested on the call does not work. This hook is downstream of the clang driver, so all it does under save temps is lead to `clang -E -emit-llvm`, which generated llvm

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:192 CC1Args.push_back("-fcuda-is-device"); - CC1Args.push_back("-emit-llvm-bc"); vaguely interesting that `-emit-llvm` here appears to generate the same code as

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay added a comment. We have two implementation choices. 1. Lift the source language restriction (it is currently discouraged) on llvm.compiler.used, let llvm.used use `SHF_GNU_RETAIN` on ELF, and change `__attribute__((used))` to use llvm.compiler.used on ELF. 2. Don't touch the backend se

[PATCH] D97273: OpenMP: Fix object clobbering issue when using save-temps

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, assuming it doesn't break support the reasoning makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97273/new/ https://review

[PATCH] D97273: OpenMP: Fix object clobbering issue when using save-temps

JonChesterfield added a comment. Works everywhere we have tried it. Fundamentally it renames a temporary file, so shouldn't break much. Will be great to have -save-temps working for nvptx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97273/new/ h

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

svenvh added inline comments. Comment at: clang/docs/OpenCLSupport.rst:196 +If an extension adds the functionality that does not modify standard language +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via libraries

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs updated this revision to Diff 326126. jroelofs added a comment. Mark section invalid if the target doesn't like how it's spelled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 Files: clang/incl

[PATCH] D97226: [clangd] Show hex value of numeric constants

kadircet accepted this revision. kadircet added a comment. still lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97226/new/ https://reviews.llvm.org/D97226 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 added a comment. > @jansvoboda11 Thanks. If it's okay with you I'll make the change to use the > new marshalling infrastructure in a separate patch > (https://reviews.llvm.org/D97327) because I may need to back port this patch > to an older LLVM branch. That's fine by me. Reposi

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM. If you don't get around committing this today, please rebase this on top of D97375 that I'm going to commit tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D97400: [clang][NFC] Remove unnecessary string copies in CustomDiagInfo

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lookup the map using a string ref and store indexed diag info using a StringRef to the map. It may be

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:25-31 +// Look for sub-directory starts with Prefix under Path. If there is one and +// only one matching sub-directory found, append the sub-directory to Path. If +// there is no matching sub-directory

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 326144. ABataev added a comment. Fixes and updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, could you please review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:555 +auto Insert = Lexer::getSourceText(FixIt.InsertFromRange, M, L, &Invalid); +if (!Invalid) + Result.newText = Insert.str(); njames93 wrote: > kadircet wrote: > >

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere added a comment. In D95119#2584709 , @haampie wrote: > Should this be merged? Do you have commit access? If not I can land this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. I don't have commit access, would be great if you could do that for me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; aaron.ballman wrote: > rnk wrote: > > aaron.ballman wrote: > > > Quuxplusone wrote: > > > > aaron.ballman wrote

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

rnk added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:446 case ToolChain::FT_Shared: -Suffix = TT.isOSWindows() - ? (TT.isWindowsGNUEnvironment() ? ".dll.a" : ".lib") +Suffix = Triple.isOSWindows() + ? (Triple.isWindowsGN

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326178. zero9178 added a comment. Addressed one of the reviewer requests and also uploaded additional files part of the patch that were accidently left out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:468-469 // Check for runtime files in the new layout without the architecture first. - std::string CRTBasename = - buildCompilerRTBasename(*this, Args, C

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; rnk wrote: > aaron.ballman wrote: > > rnk wrote: > > > aaron.ballman wrote: > > > > Quuxplusone wrote

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Something we should probably check is the interaction between -save-temps and whether we are trying to compile a single file or an executable, e.g. the difference between clang and clang -c. If trying to compile foo.c directly to an executable, -save-temps shoul

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, rsmith. Herald added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was motivated by the fact that constructor type homing (debu

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:143-148 + /// CheckDefaultArgumentVisitorODR - C++ [dcl.fct.default] Traverses + /// the default argument of a parameter to determine whether it + /// contains ODR violations. These violations cannot be c

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

rnk added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:468-469 // Check for runtime files in the new layout without the architecture first. - std::string CRTBasename = - buildCompilerRTBasename(*this, Args, Component, Type, /*AddArch=*/false); - for (cons

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

rnk added a comment. To help bikeshed the name, I can imagine a few other use cases: - an attribute to suppress type info emission, never emit full type info for this type (similar to nodebug / artificial attributes for functions) -- this could help optimize debug info size - an attribute to al

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 326194. varungandhi-apple added a comment. Address review feedback; remove centralized target check for CC_SwiftAsync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

aganea added a comment. Thanks for the update @vvereschaka ! Just a few minor things and it should be good to go. Also please use `git diff -U9` next time to add context to the patch. Comment at: clang/docs/UsersManual.rst:783 It is possible to specify this option witho

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. Generally OK with this, as it seemed the libc++ issue might be a bit thorny to solve. Though I'd like to hear from libc++ maintainers about how they feel to ensure they're comfortable adding this attribute in the interim (or if this might be a motivation to fix libc++

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:349 "source, and associated run script.\n"); - SmallVector argv(argv_, argv_ + argc_); + SmallVector ArgValues(Argv, Argv + Argc); What about just `Args`? "Values

  1   2   >