yaxunl marked an inline comment as done. yaxunl added a comment. In D61112#2584279 <https://reviews.llvm.org/D61112#2584279>, @foad wrote:
> Should have updated > https://clang.llvm.org/docs/LanguageExtensions.html#half-precision-floating-point > "_Float16 is currently only supported on the following targets, with further > targets pending ABI standardization: ..." will update the doc ================ Comment at: test/CodeGenCXX/amdgpu-float16.cpp:7 + _Float16 x, y, z; + // CHECK: v_add_f16_e64 + // NOF16: v_add_f32_e64 ---------------- arsenm wrote: > I thought clang tests were supposed to stop at the IR If you 'grep -- '-S ' clang/test/CodeGen/* | grep -v emit-llvm | grep clang', there are plenty of clang codegen tests checks assembly code. In this test we want to make sure f16 instructions are emitted for specific GPUs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
