sepavloff added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:4050
<< ", mem=" << ProcStat->PeakMemory << " Kb\n";
- }
- if (!StatReportFile.empty()) {
+ } else {
// CSV format.
----------------
vvereschaka wrote:
> aganea wrote:
> > The previous behavior was printing both the output and the CSV file when
> > specifying `-fproc-stat-report -fproc-stat-report=file.csv`, now it would
> > only emit the CSV, is that intended? @sepavloff what do you think?
> >now it would only emit the CSV, is that intended?
>
> yes, I thought in that way. I dоn't think that usage of both options at the
> same time was specially designed. I don't see a reasonable usage case for
> that for now actually, but I could be wrong. @sepavloff ?
> > now it would only emit the CSV, is that intended?
> yes, I thought in that way. I dоn't think that usage of both options at the
> same time was specially designed. I don't see a reasonable usage case for
> that for now actually, but I could be wrong. @sepavloff ?
The previous behavior (printing both the output and the CSV file) was not
intentional, it was the implementation peculiarity. I don't see real use case
for both outputs.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97094/new/
https://reviews.llvm.org/D97094
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
