[PATCH] D95753: Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 323231. phosek added a comment. Documentation updated and test included. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOption

[PATCH] D96578: [clangd] Remove the cross-file-rename option.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. and simplify the code. Repository: rG LLVM Githu

[PATCH] D96578: [clangd] Remove the cross-file-rename option.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:405 +// prepareRename is latency-sensitive: we deliberately pass a nullptr index +// to save the cost, thus the result may be incomplete as it only contains +// main-file occurrence

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

eandrews accepted this revision. eandrews added a comment. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96538/new/ https://reviews.llvm.org/D96538 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D96578: [clangd] Remove the cross-file-rename option.

hokein updated this revision to Diff 323250. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96578/new/ https://reviews.llvm.org/D96578 Files: clang-tools-ext

[PATCH] D96578: [clangd] Remove the cross-file-rename option.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:237 -IsMainFileOnly = false; - // If the symbol is not indexable, we disallow rename. - if (!SymbolCollector::shouldCollectSymbol( sammccall wrote: > I don't understand w

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, What is the difference between the

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[clang] 18a7079 - [OpenCL][Docs] Describe internals of TableGen builtins

Author: Sven van Haastregt Date: 2021-02-12T09:56:32Z New Revision: 18a70797e798ade57a3deb017692d4c47d12d6f0 URL: https://github.com/llvm/llvm-project/commit/18a70797e798ade57a3deb017692d4c47d12d6f0 DIFF: https://github.com/llvm/llvm-project/commit/18a70797e798ade57a3deb017692d4c47d12d6f0.diff

[clang] 18f16c9 - [OpenCL][Docs] Clean up trailing characters

Author: Sven van Haastregt Date: 2021-02-12T09:58:18Z New Revision: 18f16c945f52c1125b2f92a51f9dc159cb0875d1 URL: https://github.com/llvm/llvm-project/commit/18f16c945f52c1125b2f92a51f9dc159cb0875d1 DIFF: https://github.com/llvm/llvm-project/commit/18f16c945f52c1125b2f92a51f9dc159cb0875d1.diff

[PATCH] D96150: [OpenCL][Docs] Describe internals of TableGen BIFs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18a70797e798: [OpenCL][Docs] Describe internals of TableGen builtins (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D9615

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

steakhal created this revision. steakhal added reviewers: martong, balazske, Szelethus, NoQ, vsavchenko, gamesh411. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested r

[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

steakhal added a comment. I'm ok with this on my part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D96588: [OpenCL] Remove FIXME in getOpenCLFeatureDefines

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. The suggestion in D92277 was to move `O

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

svenvh added a comment. It probably makes sense to update `clang/docs/UsersManual.rst` as part of this change. In particular the following sentence is no longer true after this patch: "By default the OpenCL headers are not loaded and therefore certain builtin types and most of builtin function

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. >> FWIW I would prefer denylist as well. (Also uses of whitelist should be >> allowlist, but also incremental :) I feel like existing and proposed value do match the meaning of this list. maybe ignorelist, skiplist (can be confused with data structure?), or just asan

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:157 + // Is OpenCL C feature (OpenCL C 3.0, 6.2.1. Features) + bool isFeature(llvm::StringRef Ext) const; + The argument "Ext" suggests "Extension", so perhaps rename if this is

[clang] fdb640e - Mark output as text if it is really text

Author: Abhina Sreeskantharajan Date: 2021-02-12T07:14:21-05:00 New Revision: fdb640ea30d416368b76b68b106deda580c6aced URL: https://github.com/llvm/llvm-project/commit/fdb640ea30d416368b76b68b106deda580c6aced DIFF: https://github.com/llvm/llvm-project/commit/fdb640ea30d416368b76b68b106deda580c6

[PATCH] D96363: Mark output as text if it is really text

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfdb640ea30d4: Mark output as text if it is really text (authored by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, the fix looks good. > This patch was tested manually. The clang tidy unit test framework does not > support testing changes to header files. Given that this is a bug fix for a > live >

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry updated this revision to Diff 323289. kuzkry marked 2 inline comments as done. kuzkry added a comment. Rebased to the tip of the main branch, merged similar tests (requested by @curdeius) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/n

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

kuzkry marked 2 inline comments as done. kuzkry added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1162 + + EXPECT_EQ(DefaultUnwrappedLines, Style.ShortNamespaceLines); + EXPECT_EQ("namespace ShortNamespace {\n" curdeius

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4163 defm d_lines_as_comments : BooleanFFlag<"d-lines-as-comments">, Group; -defm default_double_8 : BooleanFFlag<"default-double-8">, Group; -defm default_integer_8 : BooleanFFlag<"default-inte

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 323290. kadircet marked 7 inline comments as done. kadircet added a comment. - Define destruction order - Get rid of Module.cpp and Module::id - Define begin/end iterators for ModuleSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D96244: [clangd] Introduce Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Module.h:25 +/// - module hooks can be called afterwards. +/// - modules can be destroyed before/after ClangdServer and ClangdLSPServer +///FIXME: Once we make server facilities available to modules, we'll

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Although I would put it in one test, this is fine by me. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1201-1206 +} + +TEST_F(ShortNamespaceLinesTest, + MultipleUnwrapped

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); rsmit

[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

ikudrin created this revision. ikudrin added reviewers: ayermolo, MaskRay, wenlei, dblaikie. ikudrin added projects: LLVM, clang, debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. ikudrin requested review of this revision. This allows the option to affect the LTO output. `Module

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added a comment. Btw, could you clang-format your patch? I normally use `git -lang-format HEAD~`. Thank you! Comment at: flang/lib/Frontend/CompilerInvocation.cpp:261 + diags.getCustomDiagID(clang::DiagnosticsEngine::Error, + "Use of `-fdefault

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 323305. whisperity added a comment. Make sure that overloadable binary operators are ignored properly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560 Files: clang

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir updated this revision to Diff 323307. saghir added a comment. Merged tests into one file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 Files: clang/lib/Basic/Targets/PPC.h clang/test/CodeGen/t

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

aaron.ballman added inline comments. Comment at: clang/test/Analysis/free.c:84 + // expected-warning@-1{{Argument to free() is a block, which is not memory allocated by malloc()}} + // expected-warning@-2{{attempt to call free on non-heap object : block expression}} } --

[PATCH] D96578: [clangd] Remove the cross-file-rename option.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee4dd0f87698: [clangd] Remove the cross-file-rename option. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96578/new/ https://reviews.l

[clang-tools-extra] ee4dd0f - [clangd] Remove the cross-file-rename option.

Author: Haojian Wu Date: 2021-02-12T15:38:55+01:00 New Revision: ee4dd0f87698330a8d86ed268d69c4fe9be49e6f URL: https://github.com/llvm/llvm-project/commit/ee4dd0f87698330a8d86ed268d69c4fe9be49e6f DIFF: https://github.com/llvm/llvm-project/commit/ee4dd0f87698330a8d86ed268d69c4fe9be49e6f.diff LO

[PATCH] D96244: [clangd] Introduce Modules

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.h:33 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/FunctionExtr

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

mibintc added a comment. In D96203#2559426 , @vitalybuka wrote: >>> FWIW I would prefer denylist as well. (Also uses of whitelist should be >>> allowlist, but also incremental :) > > I feel like existing and proposed value do match the meaning of this lis

[clang-tools-extra] cea9f05 - [clangd] Move command handlers into a map in ClangdLSPServer. NFC

Author: Sam McCall Date: 2021-02-12T15:57:43+01:00 New Revision: cea9f054327be2eb83093f0202a7814b904f1076 URL: https://github.com/llvm/llvm-project/commit/cea9f054327be2eb83093f0202a7814b904f1076 DIFF: https://github.com/llvm/llvm-project/commit/cea9f054327be2eb83093f0202a7814b904f1076.diff LO

[PATCH] D96507: [clangd] Move command handlers into a map in ClangdLSPServer. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked 3 inline comments as done. Closed by commit rGcea9f054327b: [clangd] Move command handlers into a map in ClangdLSPServer. NFC (authored by sammccall).

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323321. sammccall added a comment. Rebase and include commands after D96507 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files:

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

njames93 added a comment. Ping? It would be nice to get this fix in the release branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96508/new/ https://reviews.llvm.org/D96508 ___ cfe-commits mailing li

[clang] 33e731e - [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment

Author: Kirstóf Umann Date: 2021-02-12T16:19:20+01:00 New Revision: 33e731e62dae49d5143410248234963fc7a5e1db URL: https://github.com/llvm/llvm-project/commit/33e731e62dae49d5143410248234963fc7a5e1db DIFF: https://github.com/llvm/llvm-project/commit/33e731e62dae49d5143410248234963fc7a5e1db.diff

[PATCH] D87518: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that appear in an assignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33e731e62dae: [analyzer][Liveness][NFC] Remove an unneeded pass to collect variables that… (authored by Szelethus). Changed prior to commit: https

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

balazske created this revision. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, xazax.hun, whisperity, mgorny. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This check should warn if '*' character at pointer dec

[PATCH] D96608: [clangd] Delay binding LSP methods until initialize. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is NFC because the MessageHandler re

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think we should have the config mechanism available for one release cycle before removing the old one. So I think it's fine to retire the flag but we shouldn't pick this into the 12

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c5a800dc17: Improve hover scopes for Objective-C code (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llv

[clang-tools-extra] 07c5a80 - Improve hover scopes for Objective-C code

Author: David Goldman Date: 2021-02-12T10:27:32-05:00 New Revision: 07c5a800dc1769f3f684d4a864f3903ac9ffa9f3 URL: https://github.com/llvm/llvm-project/commit/07c5a800dc1769f3f684d4a864f3903ac9ffa9f3 DIFF: https://github.com/llvm/llvm-project/commit/07c5a800dc1769f3f684d4a864f3903ac9ffa9f3.diff

[clang] 053e61d - Relands "[HIP] Change default --gpu-max-threads-per-block value to 1024"

Author: Yaxun (Sam) Liu Date: 2021-02-12T10:53:59-05:00 New Revision: 053e61d54e63810b005adacf5e73a6465ca24bd2 URL: https://github.com/llvm/llvm-project/commit/053e61d54e63810b005adacf5e73a6465ca24bd2 DIFF: https://github.com/llvm/llvm-project/commit/053e61d54e63810b005adacf5e73a6465ca24bd2.dif

[PATCH] D96508: [clangd] Retire clang-tidy-checks flag.

njames93 added a comment. In D96508#2559936 , @sammccall wrote: > I think we should have the config mechanism available for one release cycle > before removing the old one. > > So I think it's fine to retire the flag but we shouldn't pick this into the >

[PATCH] D96204: [clangd] Fix clang tidy provider when multiple config files exist in directory tree

njames93 added a comment. @sammccall I meant to ping this one sorry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96204/new/ https://reviews.llvm.org/D96204 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 323340. balazske added a comment. Changed definition of size_t in test header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bu

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

njames93 added a comment. Seems that your test cases are failing on windows, I'm guessing this is a MSVC template compatibility issue. Probably need to add `-fno-delayed-template-parsing` to the clang driver args (after `-- --`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D96139: [clang-tidy] Simplify inaccurate erase check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG with nit. Comment at: clang-tools-extra/clang-tidy/bugprone/InaccurateEraseCheck.cpp:25-27 + 1, anyOf(cxxMemberCallExpr(callee(cxxMethodDecl(hasName("end"

[clang-tools-extra] 33f35a4 - [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

Author: Yitzhak Mandelbaum Date: 2021-02-12T16:23:53Z New Revision: 33f35a4b793bb53b830f8893110af57672e1dc79 URL: https://github.com/llvm/llvm-project/commit/33f35a4b793bb53b830f8893110af57672e1dc79 DIFF: https://github.com/llvm/llvm-project/commit/33f35a4b793bb53b830f8893110af57672e1dc79.diff

[PATCH] D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33f35a4b793b: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

Szelethus added a comment. I don't insist on this patch, though I will end up removing the FIXME even if I leave the actual code unchanged, as it seems to be outdated. Comment at: clang/lib/Analysis/LiveVariables.cpp:522 - // FIXME: we should enqueue using post order. - fo

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

awarzynski added a comment. Thank you for submitting this @FarisRehman ! Overall this looks good to me. I've left a few minor comments inline. Also, I think that it is worth adding a help message for `-finput-charset`. Lack of it in `clang` feels like an accidental omission. We can follow GCC h

[PATCH] D96223: [clang-tidy] Simplify static assert check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG with a few nits. Comment at: clang-tools-extra/clang-tidy/misc/StaticAssertCheck.cpp:49-51 + expr(anyOf(expr(anyOf(AssertExprRoot, +un

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added a comment. In D93110#2534690 , @aaron.ballman wrote: > In D93110#2529917 , @NoQ wrote: > >>> What I want to avoid is having a static analyzer-specific suppression >>> attribute, and a different on

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

sammccall added a comment. Sorry for the looong delay getting back to this :-\ I do think this should be nullable (and const-friendly) but otherwise this is good to land. Comment at: clang-tools-extra/clangd/HeuristicResolver.h:73 + std::vector + resolveDependentMember(cons

[PATCH] D96204: [clangd] Fix clang tidy provider when multiple config files exist in directory tree

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about dropping this (and others, i'm trying to get through them now) Agree about cherrypicking this. Regarding the extra test case... I'm not sure either. It's a nice test, but the

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9899 def err_opencl_requires_extension : Error< - "use of %select{type|declaration}0 %1 requires %2 extension to be enabled">; + "use of %select{type|declaration}0 %1 requires %2 %se

[clang] fb4d8fe - [clang] Update mustprogress tests.

Author: Florian Hahn Date: 2021-02-12T16:53:51Z New Revision: fb4d8fe807016fed221263d9a406e3856c8dfa4c URL: https://github.com/llvm/llvm-project/commit/fb4d8fe807016fed221263d9a406e3856c8dfa4c DIFF: https://github.com/llvm/llvm-project/commit/fb4d8fe807016fed221263d9a406e3856c8dfa4c.diff LOG:

[PATCH] D96507: [clangd] Move command handlers into a map in ClangdLSPServer. NFC

thakis added a comment. Looks like this doesn't build on Windows: http://45.33.8.238/win/33161/step_4.txt (clang-cl + msvc stdlib) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96507/new/ https://reviews.llvm.org/D96507 __

[PATCH] D96611: [analyzer][tests] Fix issue comparison script

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko requested review of this revision. Herald added a project:

[clang-tools-extra] ba3ea9c - [clangd] Fix clang tidy provider when multiple config files exist in directory tree

Author: Nathan James Date: 2021-02-12T16:55:46Z New Revision: ba3ea9c60f0f259f0ccc47e47daf8253a5885531 URL: https://github.com/llvm/llvm-project/commit/ba3ea9c60f0f259f0ccc47e47daf8253a5885531 DIFF: https://github.com/llvm/llvm-project/commit/ba3ea9c60f0f259f0ccc47e47daf8253a5885531.diff LOG:

[PATCH] D96204: [clangd] Fix clang tidy provider when multiple config files exist in directory tree

This revision was automatically updated to reflect the committed changes. Closed by commit rGba3ea9c60f0f: [clangd] Fix clang tidy provider when multiple config files exist in directory… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/test/CodeGen/debug-info-cc.c:60-66 +// [FIXME: swiftasynccc] Update debuginfo tag to SwiftAsync once LLVM support lands. +// LINUX: !DISubprogram({{.*}}"add_swiftasynccall", {{.*}}type: ![[FTY:[0-9]+]] +// LINUX: ![[FTY]

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Categories will now be printed

[clang-tools-extra] 8dd6dd9 - [clangd] Work around presumed MSVC stdlib bug

Author: Sam McCall Date: 2021-02-12T18:00:43+01:00 New Revision: 8dd6dd947c148515bbd5fc06c0b5786148038750 URL: https://github.com/llvm/llvm-project/commit/8dd6dd947c148515bbd5fc06c0b5786148038750 DIFF: https://github.com/llvm/llvm-project/commit/8dd6dd947c148515bbd5fc06c0b5786148038750.diff LO

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with -finclude-d

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal > In the upcoming days, I'm gonna schedule this on our CI. We will see the > results. Thank you. That would be great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 ___

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with -finclude-defa

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 323361. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96244/new/ https://reviews.llvm.org/D96244 Files: clang-tools-ex

[PATCH] D96244: [clangd] Introduce Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:33 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/FunctionExtras.h" sammccall wrote: > (include no longer used?) well it is still

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia updated this revision to Diff 323362. Anastasia added a comment. Changed command line option text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/ https://reviews.llvm.org/D96515 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/Types.h cl

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 323363. varungandhi-apple added a comment. Fix test case for debuginfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561 Files: clang/include/clang-c/Index.h

[PATCH] D95704: [CodeGen] Introduce DWARF tag for SwiftTail and emit it in CodeGen.

varungandhi-apple updated this revision to Diff 323364. varungandhi-apple added a comment. Tweak test case diff to adjust for change in previous commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95704/new/ https://reviews.llvm.org/D95704 Files

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2559424 , @svenvh wrote: > It probably makes sense to update `clang/docs/UsersManual.rst` as part of > this change. In particular the following sentence is no longer true after > this patch: "By default the OpenCL he

[PATCH] D96608: [clangd] Delay binding LSP methods until initialize. NFC

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:165 return false; -if (!Server.Server) { - elog("Notification {0} before initialization", Met

[clang-tools-extra] 2423a38 - [clangd] Introduce Modules

Author: Kadir Cetinkaya Date: 2021-02-12T18:37:16+01:00 New Revision: 2423a3863e0743635f76d30062413f21b2c59349 URL: https://github.com/llvm/llvm-project/commit/2423a3863e0743635f76d30062413f21b2c59349 DIFF: https://github.com/llvm/llvm-project/commit/2423a3863e0743635f76d30062413f21b2c59349.dif

[PATCH] D96244: [clangd] Introduce Modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2423a3863e07: [clangd] Introduce Modules (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. The pre-merge checks appear to have flagged some issues, but I don't anticipate any major revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added inline comments. Comment at: llvm/docs/CoverageMappingFormat.rst:277 +There is one difference between versions 6 and 5: + +There is one difference between versions 5 and 4: I think the above bullet point could go in this section? Repository: rG LLVM

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 323373. fhahn added a comment. Rebased the patch to apply wihtout D96418 . Will land soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D964

[clang] ed4718e - [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of

Author: Akira Hatanaka Date: 2021-02-12T09:51:57-08:00 New Revision: ed4718eccb12bd42214ca4fb17d196d49561c0c7 URL: https://github.com/llvm/llvm-project/commit/ed4718eccb12bd42214ca4fb17d196d49561c0c7 DIFF: https://github.com/llvm/llvm-project/commit/ed4718eccb12bd42214ca4fb17d196d49561c0c7.diff

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed4718eccb12: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of (authored by ahatanak). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 323378. njames93 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clan

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

njames93 updated this revision to Diff 323379. njames93 added a comment. Rebase and fix up tests after changes to rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95043/new/ https://reviews.llvm.org/D95043 Files: clang-tools-extra/clangd/Cl

[PATCH] D96611: [analyzer][tests] Fix issue comparison script

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx!~ Comment at: clang/utils/analyzer/CmpRuns.py:401-402 + +old = filter_issues(old, common) +new = filter_issues(new, common) +common = set()

[PATCH] D96616: [OpenCL][Docs] Change documentation for the OpenCL standard headers

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. After updating the user interface (https://reviews.llvm.org/D96515), make sure the doc reflects the change. https://reviews.llvm.org/D9661

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2560280 , @Anastasia wrote: > In D96515#2559424 , @svenvh wrote: > >> It probably makes sense to update `clang/docs/UsersManual.rst` as part of >> this change. In particular th

[clang] 1b5c291 - [DebugInfo] Add an attribute to force type info to be emitted for

Author: Amy Huang Date: 2021-02-12T10:16:49-08:00 New Revision: 1b5c2915a2318705727ada586290de15e2cad202 URL: https://github.com/llvm/llvm-project/commit/1b5c2915a2318705727ada586290de15e2cad202 DIFF: https://github.com/llvm/llvm-project/commit/1b5c2915a2318705727ada586290de15e2cad202.diff LOG

[clang] 3fe465f - Revert "[DebugInfo] Add an attribute to force type info to be emitted for"

Author: Amy Huang Date: 2021-02-12T10:18:17-08:00 New Revision: 3fe465fb2cd64cd7bd910c761920e3378fe8d1b0 URL: https://github.com/llvm/llvm-project/commit/3fe465fb2cd64cd7bd910c761920e3378fe8d1b0 DIFF: https://github.com/llvm/llvm-project/commit/3fe465fb2cd64cd7bd910c761920e3378fe8d1b0.diff LOG

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. Note this patch depends on https://reviews.llvm.org/D96571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, vitalybuka wrote: > What is the dif

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

njames93 added a comment. I'm not an objc guy, but can you add a test case demonstrating class(?) methods showing as `+name:`? Comment at: clang-tools-extra/clangd/AST.cpp:224-226 + if (const ObjCContainerDecl *C = dyn_cast(&ND)) +return printObjCContainer(*C); + if (con

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

RedDocMD added a comment. @vsavchenko, why did you chose NamedDecl instead of ValueDecl to account for the indirect fields? I couldn't quite follow it from the discussion above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://revi

[PATCH] D96588: [OpenCL] Remove FIXME in getOpenCLFeatureDefines

Anastasia added a comment. > The suggestion in D92277 was to move > OpenCLOptions into LanguageOptions, but > this is not viable. Sema's LangOpts is immutable, and embedding > OpenCLOptions into LangOpts would make OpenCLOptions immutable too. > This is incomp

  1   2   >