Anastasia added inline comments.

================
Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27
+  // expected-error@-3 0+{{no matching function for call to 'barrier'}}
+  // expected-error@* {{typedef type cl_mem_fence_flags not found; include the 
base header with -finclude-default-header}}
+}
----------------
Actually, could we remove the `typedef` from the diagnostic because it exposes 
the implementation details unnecessarily? I believe the spec doesn't say what 
the type is aside from enums?  As a matter of fact, we have some types 
implemented as typedefs that should have been a native types e.g. vector types 
that we might change one day.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96051/new/

https://reviews.llvm.org/D96051

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to