arnamoy10 added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:4163 defm d_lines_as_comments : BooleanFFlag<"d-lines-as-comments">, Group<gfortran_Group>; -defm default_double_8 : BooleanFFlag<"default-double-8">, Group<gfortran_Group>; -defm default_integer_8 : BooleanFFlag<"default-integer-8">, Group<gfortran_Group>; -defm default_real_8 : BooleanFFlag<"default-real-8">, Group<gfortran_Group>; +defm default_double_8 : BooleanFFlag<"default-double-8">, Group<gfortran_Group>, Flags<[FlangOption,FC1Option]>; +defm default_integer_8 : BooleanFFlag<"default-integer-8">, Group<gfortran_Group>, Flags<[FlangOption,FC1Option]>; ---------------- awarzynski wrote: > Could you add a help text? Note that once you add a help text, you will have > to add `FlangOnlyOption` flag to make sure this option doesn't show up in: > ``` > clang -help > ``` > > Some for other options here. Also, at that point, I suggest moving these > options near other Flang options: > https://github.com/llvm/llvm-project/blob/ec4fb5bcd3b92867156a5bd75fa0be4c74084f3c/clang/include/clang/Driver/Options.td#L4224-L4238. > > AFAIK, these options are no longer forwarded to `gfortran` anyway (since this > [[ > https://github.com/llvm/llvm-project/commit/6a75496836ea14bcfd2f4b59d35a1cad4ac58cee > | patch ]]). What should be the help text for `-flarge-sizes`, given we cannot take reference from gfortran Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
