[PATCH] D95244: [clang][AST] Handle overload callee type in CallExpr::getCallReturnType.

balazske added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95244/new/ https://reviews.llvm.org/D95244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D95871: [clang] Store the location for invalid type of a declarator.

sammccall added a comment. It would be nice to have a testcase with a nontrivial range so we can see the choice of location... Comment at: clang/lib/Sema/SemaType.cpp:5659 if (D.isInvalidType()) -return Context.getTrivialTypeSourceInfo(T); - +return Context.getTrivi

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 321022. tbaeder added a comment. Noticed similar/worse behavior for -rtlib. Expanded the patch to that and -unwindlib as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files: clang/lib/Driver/ToolC

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added a comment. Thanks, this looks right to me. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:338 + const CompoundStmt *EnclosingScope = ParentNode->get(); + if (const auto *If = ParentNode->get()) +if (const auto *Then = dyn_cast(If->getThen())) --

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signal-handler.rst:29-30 + `_ + for more information). This is not an extension of the minimal

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal added a comment. In D95860#2536721 , @balazske wrote: > In D95860#2536609 , @steakhal wrote: > >> Please, also add a regression test for Haoxin Tu's reproducer. >> >> // RUN: %clang %s >> >> // expec

[PATCH] D92270: [ConstantFold] Fold more operations to poison

RKSimon added a comment. https://bugs.llvm.org/show_bug.cgi?id=49005 seems to be due to this (either directly or it has unearthed an existing problem) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92270/new/ https://reviews.llvm.org/D92270 __

[PATCH] D62574: Add support for target-configurable address spaces.

danilaml added a comment. So is missing an in-tree user (like AMDGPU) the only thing that prevents from merging this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62574/new/ https://reviews.llvm.org/D62574 ___

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for working on this @FarisRehman ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95460/new/ https://reviews.llvm.org/D95460 _

[clang] d38973a - [clang][AVR] Improve avr-ld command line options

Author: Ben Shi Date: 2021-02-03T18:23:01+08:00 New Revision: d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d URL: https://github.com/llvm/llvm-project/commit/d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d DIFF: https://github.com/llvm/llvm-project/commit/d38973aa4d6a2c8be97b9781ca7325ca3eb0c40d.diff LOG:

[PATCH] D93579: [clang][AVR] Improve avr-ld command line options

This revision was automatically updated to reflect the committed changes. Closed by commit rGd38973aa4d6a: [clang][AVR] Improve avr-ld command line options (authored by benshi001). Changed prior to commit: https://reviews.llvm.org/D93579?vs=318881&id=321035#toc Repository: rG LLVM Github Mon

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9caf364d69db: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D95523?

[clang] 9caf364 - [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-03T10:23:49Z New Revision: 9caf364d69db3cd0ce0fba99dba95dbc2b646fbc URL: https://github.com/llvm/llvm-project/commit/9caf364d69db3cd0ce0fba99dba95dbc2b646fbc DIFF: https://github.com/llvm/llvm-project/commit/9caf364d69db3cd0ce0fba99dba95dbc2b646fbc.diff

[clang] e6a62ac - [OpenCL] Add cl_khr_subgroup_non_uniform_vote to TableGen BIFs

Author: Sven van Haastregt Date: 2021-02-03T10:23:52Z New Revision: e6a62ac62571229d941dfe81affabdbc47e478eb URL: https://github.com/llvm/llvm-project/commit/e6a62ac62571229d941dfe81affabdbc47e478eb DIFF: https://github.com/llvm/llvm-project/commit/e6a62ac62571229d941dfe81affabdbc47e478eb.diff

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett updated this revision to Diff 321037. DavidSpickett added a comment. - Added split -Wa test for -mthumb - Use `--check-prefix`/`--check-prefixes` - Comment at top of march/mcpu file to explain choice of test CPUs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 updated this revision to Diff 321038. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95852/new/ https://reviews.llvm.org/D95852 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

DavidSpickett marked 6 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/arm-target-as-march-mcpu.s:42 +/// We use the target CPU for both. +// RUN: %clang -target arm-linux-gnueabi -### -c -mcpu=cortex-a8 -Wa,-march=armv8a %s 2>&1 | \ +

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske updated this revision to Diff 321039. balazske added a comment. Existing test moved to Frontend, added new test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95860/new/ https://reviews.llvm.org/D95860 Files: clang/lib/Frontend/Diagnost

[PATCH] D95852: [clangd] Report xref for base methods.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1294 + OverriddenMethods.insert(ID); +getOverriddenMethods(Base, OverriddenMethods); + } The

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske updated this revision to Diff 321041. balazske added a comment. Reformatting test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95860/new/ https://reviews.llvm.org/D95860 Files: clang/lib/Frontend/DiagnosticRenderer.cpp clang/te

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia added a comment. In D95608#2537316 , @rjmccall wrote: > Thanks, LGTM. > > I think idiomatically we normally just use `(void)` instead of spelling it > out with `static_cast`, since there's only one possible meaning for a cast to > `void`. I do

[clang-tools-extra] 54afcad - [clangd] Report xref for base methods.

Author: Utkarsh Saxena Date: 2021-02-03T12:07:43+01:00 New Revision: 54afcade3bbcf4a085c8a8c3c22429921420e54d URL: https://github.com/llvm/llvm-project/commit/54afcade3bbcf4a085c8a8c3c22429921420e54d DIFF: https://github.com/llvm/llvm-project/commit/54afcade3bbcf4a085c8a8c3c22429921420e54d.diff

[PATCH] D95852: [clangd] Report xref for base methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54afcade3bbc: [clangd] Report xref for base methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal added a comment. In D95860#2538802 , @balazske wrote: > Existing test moved to Frontend, added new test. Awesome, thanks! On the functional side of things, I'm not sure if we should skip or not. But simply skipping those seems like you are treat

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. I realized that the added test cases show different problems: One is when one of `Begin` or `End` is invalid, other if the FileID's are different. Probably we can find a better solution for the second problem. So the patch needs to be splitted and the case with the **c

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

kadircet created this revision. kadircet added a reviewer: hokein. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95935 Files: clang/lib/Sema/SemaCodeComplete.cpp

[clang] 3fda262 - [clang][AVR][NFC] Fix a typo

Author: Ben Shi Date: 2021-02-03T20:00:06+08:00 New Revision: 3fda262b7d7bdbf9db5b1d6602602733b4cf4f35 URL: https://github.com/llvm/llvm-project/commit/3fda262b7d7bdbf9db5b1d6602602733b4cf4f35 DIFF: https://github.com/llvm/llvm-project/commit/3fda262b7d7bdbf9db5b1d6602602733b4cf4f35.diff LOG:

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321050. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-to

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:339 + if (const auto *If = ParentNode->get()) +if (const auto *Then = dyn_cast(If->getThen())) + EnclosingScope = Then; hokein wrote: > thinking more about the `if`

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321052. kbobyrev added a comment. Save few LOCs by checking for nullptr in CheckDeclStmt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-tools-extra/cl

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321053. kbobyrev added a comment. Don't spell out DynTypedNodeList and don't include ParentMapContext.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-

[PATCH] D95935: [clang][CodeComplete] Fix crash on ParenListExprs

kadircet updated this revision to Diff 321054. kadircet added a comment. - Also handle memberrefexpr case. Fixes https://github.com/clangd/clangd/issues/676. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95935/new/ https://reviews.llvm.org/D95935

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321055. kbobyrev added a comment. Revert last change: leads to incomplete types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-tools-extra/clangd/refa

[clang] e635feb - [OpenCL] Fix address space in binding of initializer lists to referencs

Author: Anastasia Stulova Date: 2021-02-03T12:48:21Z New Revision: e635feb15a91e6eeb77876031be2811e63d542f3 URL: https://github.com/llvm/llvm-project/commit/e635feb15a91e6eeb77876031be2811e63d542f3 DIFF: https://github.com/llvm/llvm-project/commit/e635feb15a91e6eeb77876031be2811e63d542f3.diff

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

This revision was automatically updated to reflect the committed changes. Closed by commit rGe635feb15a91: [OpenCL] Fix address space in binding of initializer lists to referencs (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D95608?vs=

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added a comment. thanks, looks better now, just some nits to improve the code readability. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:332 + DynTypedNodeList Parents = Ctx.getParents(RenamedDecl); + if (Parents.size() != 1 || !Parents.begin()->get()) +

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo http

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

svenvh added inline comments. Comment at: clang/docs/UsersManual.rst:2835 `_ -to produce SPIR-V binary. - +to produce SPIR-V binary. More detail are provided in the following +online resource - `the offline compilation from

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321074. RedDocMD added a comment. Remoevd the use of std::list with llvm::SmallVector. Removed the need to delete elements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D9

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre created this revision. thopre added reviewers: efriedma, kpn, mibintc, sepavloff, rjmccall. Herald added subscribers: dexonsmith, pengfei. thopre requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. __builtin_isnan currently generat

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321078. RedDocMD added a comment. Made assertion more verbose Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 Files: clang/include/clang/StaticAnalyzer/Core/PathSens

[clang] e48f444 - [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

Author: Ilya Mirsky Date: 2021-02-03T07:50:50-06:00 New Revision: e48f444751cf781c42934b242b81f549da77bad0 URL: https://github.com/llvm/llvm-project/commit/e48f444751cf781c42934b242b81f549da77bad0 DIFF: https://github.com/llvm/llvm-project/commit/e48f444751cf781c42934b242b81f549da77bad0.diff L

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

This revision was automatically updated to reflect the committed changes. Closed by commit rGe48f444751cf: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array… (authored by ilya, committed by einvbri ). Repository: rG LLVM Github Monorepo

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. @vsavchenko could you please see the current logic if it is better now? Comment at: clang/test/Analysis/pointer-to-member.cpp:304 + grandpa.field = 10; + int Grandfather::*gpf1 = static_cast(sf); + int Grandfather::*gpf2 = static_cast(static_cast(sf

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a comment. Thanks @rsmith, will do. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. But I do not know if there is a better solution, if the file ID is different these are in different files, one included from the other. If the "include locations" are not accessible in the same way as macro locations we can not get the place (of the #include statement)

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers added a comment. Abandoning this change request in favor of @steakhal 's more comprehensive change @ https://reviews.llvm.org/D93222 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___

[PATCH] D95695: [clang-tblgen] AnnotateAttr::printPretty has spurious comma when no variadic argument is specified

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you for the fix, the changes LGTM! Do you need me to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

vabridgers abandoned this revision. vabridgers added a comment. Abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___ cfe-commits mailing list cfe-commi

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added a comment. Also, all these `PathRange` and `PathList` don't really reflect what they stand for semantically and talk more about implementation. It's not the problem of this patch, but it doesn't make your logic easier to comprehend. Comment at: clang/lib/Sta

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans updated this revision to Diff 321080. hans marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95876/new/ https://reviews.llvm.org/D95876 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D95876: [clang-cl] Remove the /fallback option

hans added a comment. Please take another look. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:669 const InputInfoList &Inputs, const ArgList &Args, const char *LinkingOutput) const { ArgStringList CmdArgs; thakis wrote: > Doesn't this whole func

[clang] 7a45f27 - [OpenCL][Docs] Fix command line flag in the example.

Author: Anastasia Stulova Date: 2021-02-03T14:07:46Z New Revision: 7a45f27ba156e311bf1deaa42761ec08d8e34d05 URL: https://github.com/llvm/llvm-project/commit/7a45f27ba156e311bf1deaa42761ec08d8e34d05 DIFF: https://github.com/llvm/llvm-project/commit/7a45f27ba156e311bf1deaa42761ec08d8e34d05.diff

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321086. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Resolve most comments but one: some comments & examples in the code incoming in the next diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D95951: [OpenCL] Add cl_khr_subgroup_non_uniform_arithmetic to TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added a subscriber: yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the builtin functions brought by the cl_khr_subgroup_non_uniform_arithmetic ext

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:226 +llvm::make_range(BaseList.begin(), BaseList.end()), +[](const auto &I) -> bool { return I.second; }); + vsavchenko wrote: > I think it's all a bit to

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:355 + // This helper checks if there is a condition variable has NewName. + auto CheckConditionVariable = [&](const auto *Scope) -> const NamedDecl * { +if (!Scope) hok

[clang] e59d336 - [test] Use host platform specific error message substitution in lit tests - continued

Author: Abhina Sreeskantharajan Date: 2021-02-03T09:53:22-05:00 New Revision: e59d336e75f4670b1a702c2281b3fed27ba4c426 URL: https://github.com/llvm/llvm-project/commit/e59d336e75f4670b1a702c2281b3fed27ba4c426 DIFF: https://github.com/llvm/llvm-project/commit/e59d336e75f4670b1a702c2281b3fed27ba4

[PATCH] D95808: [test] Use host platform specific error message substitution in lit tests - continued

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe59d336e75f4: [test] Use host platform specific error message substitution in lit tests… (authored by abhina.sreeskantharajan). Repository: rG LLV

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:226 +llvm::make_range(BaseList.begin(), BaseList.end()), +[](const auto &I) -> bool { return I.second; }); + RedDocMD wrote: > vsavchenko wrote: > >

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321095. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 Files: clang-tools-extra/c

[PATCH] D89870: [clangd] Drop template argument lists from completions followed by

kbobyrev added a comment. @sammccall Ping, this is a real patch :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89870/new/ https://reviews.llvm.org/D89870 ___ cfe-commits mailing list cfe-commits@lists.

[clang] 0682903 - Revert "[ConstantFold] Fold more operations to poison"

Author: Juneyoung Lee Date: 2021-02-04T00:24:02+09:00 New Revision: 06829034ca64b8c83a5b20d8abe5ddbfe7af0004 URL: https://github.com/llvm/llvm-project/commit/06829034ca64b8c83a5b20d8abe5ddbfe7af0004 DIFF: https://github.com/llvm/llvm-project/commit/06829034ca64b8c83a5b20d8abe5ddbfe7af0004.diff

[PATCH] D92270: [ConstantFold] Fold more operations to poison

aqjune added a comment. In D92270#2538713 , @RKSimon wrote: > https://bugs.llvm.org/show_bug.cgi?id=49005 seems to be due to this (either > directly or it has unearthed an existing problem) I reverted this commit; I'll reland this after the underlying pr

[PATCH] D88299: [clang-format] Add MacroUnexpander.

sammccall added a comment. Thanks a lot for all the time explaining, I get this at least at a high level now. I have trouble following the ins and outs of the algorithm, but I think I understand most of it and tests cover the rest. Regarding tests: I have trouble reasoning about whether all cas

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

mibintc added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2988 CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); -// FIXME: for strictfp/IEEE-754 we need to not trap on SNaN here. Value *V = EmitScalarExpr(E->getArg(0)); What a

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:322 - Scopes.push_back(""); + std::set Scopes; + Scopes.insert(""); nit: sort+erase-uniq

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

steakhal added a comment. In D93787#2539111 , @vabridgers wrote: > Abandoning this change request in favor of @steakhal 's more comprehensive > change @ https://reviews.llvm.org/D93222 Let me know if that patch-stack resolves your crash. I don't mind e

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. > Anastasia added a comment. > In D89909#2536331 > https://reviews.llvm.org/D89909#2536331, @bader wrote: > >> In D89909#2536157 >> https://reviews.llvm.org/D89909#2536157, @Anastasia wrote

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2988 CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); -// FIXME: for strictfp/IEEE-754 we need to not trap on SNaN here. Value *V = EmitScalarExp

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre marked 2 inline comments as done. thopre added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2995 +Builder.getDefaultConstrainedExcept() == fp::ebIgnore || +!Ty->isIEEE()) { + V = Builder.CreateFCmpUNO(V, V, "cmp"); I'm

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. For me this patch breaks building llvm. Before this patch, I successfully built llvm using a llvm/10 installation on the system. What is probably special with our llvm installation is that we by default use libc++ rather than libstdc++. FAILED: projects/openmp

[PATCH] D95790: [WIP][clang][cli] Documentation of CompilerInvocation parsing/generation

jansvoboda11 updated this revision to Diff 321103. jansvoboda11 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Polish, document ImpliedByAnyOf and ShouldParse Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D86295: [analyzer] Reorder the layout of MemRegion and cache by hand for optimal size

steakhal added a comment. In D86295#2519851 , @ASDenysPetrov wrote: > What about this change? Did you make more measurements? IMO it needs more justification and measurement to land it. If my measurement was correct then it would decrease the readabilit

[PATCH] D95168: [clang-format] Add InsertBraces option

njames93 added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17996 +format(ForSourceLong, Style)); +} + MyDeveloperDay wrote: > MyDeveloperDay wrote: > > MyDeveloperDay wrote: > > > are you testing do/while? > > whilst people dis

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdoerfert added a comment. This seems sensible. The clang parts look OK but I haven't thought everything through to the last detail. I left some questions below, I guess we can go down this road and slowly transition to the new scheme. Comment at: clang/lib/AST/Stmt.cpp:1275

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

jdoerfert added a comment. In D94745#2539405 , @protze.joachim wrote: > For me this patch breaks building llvm. Before this patch, I successfully > built llvm using a llvm/10 installation on the system. What is probably > special with our llvm installat

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

balazske added a comment. Probably it is not worth to find a better solution. In the case of CloneChecker the range starts and ends on different line that is not possible to print on a single line in the output. This code could work: // Then, crawl the expansion chain for the end of the range

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

JonChesterfield added a comment. I think there's a bug report about this. Sycl (iirc) introduced a change that caught invalid things with types that were previously ignored. @jdoerfert is on point I think. `-DLLVM_ENABLE_PROJECTS="clang;compiler-rt;libcxxabi;libcxx;libunwind;openmp" ` ^ That wo

[PATCH] D95918: [Coverage] Propogate counter to condition of conditional operator

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95918/new/ https://reviews.llvm.org/D95918 __

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

jdoerfert added a comment. Drive by: I don't believe a static variable is a good idea. Also the name is not really informative. A member in `ToolChain` with a proper name would be nicer (IMHO). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 _

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

thopre updated this revision to Diff 321107. thopre marked 2 inline comments as done. thopre added a comment. - Fix order of sub operands in comments and use fully parenthesized expression - Explain how LShr is equivalent to < 0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 81b6987 - [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

Author: Kevin P. Neal Date: 2021-02-03T11:49:17-05:00 New Revision: 81b69879c946533c71cc484bd8d9202bf1e34bfe URL: https://github.com/llvm/llvm-project/commit/81b69879c946533c71cc484bd8d9202bf1e34bfe DIFF: https://github.com/llvm/llvm-project/commit/81b69879c946533c71cc484bd8d9202bf1e34bfe.diff

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG81b69879c946: [FPEnv][X86] Platform builtins edition: clang should get from the AST the… (authored by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D946

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2536661 , @arsenm wrote: > In D78979#2536590 , @Anastasia wrote: > >> @arsenm I would like to see if we can finalize this patch soon. Do you think >> you will have a capacity fo

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet updated this revision to Diff 321118. kadircet added a comment. Herald added a subscriber: mgrang. - sort+unique+erase instead of using a set - Inline visitor and directly collect scopes there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D95581: Frontend: Refactor compileModuleAndReadAST, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95581/new/ https://reviews.llvm.org/D95581 _

[PATCH] D95942: [clangd] Deduplicate scopes in IncludeFixer queries

kadircet updated this revision to Diff 321120. kadircet added a comment. - add back the global scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95942/new/ https://reviews.llvm.org/D95942 Files: clang-tools-extra/clangd/IncludeFixer.cpp Ind

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

yaxunl added a comment. In D95915#2539483 , @jdoerfert wrote: > I don't believe a static variable is a good idea. Also the name is not really > informative. Members in `ToolChain` with a proper names would be nicer (IMHO). > > Tests missing. Also, now you

[PATCH] D95793: [clang][cli] Generate and round-trip language options

jansvoboda11 updated this revision to Diff 321131. jansvoboda11 added a comment. Fix failures of tests that invoke -cc1 directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95793/new/ https://reviews.llvm.org/D95793 Files: clang/include/clang/

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

russell.gallop added a comment. I've focussed on the test test-global-init-nonzero-sm-pic.ll which fails writing to an address which (I believe) should be in the .data section but isn't. With some breakpoints in SectionMemoryManager.cpp it appears that this fails when the top 32bits of the .te

[PATCH] D95793: [clang][cli] Generate and round-trip language options

jansvoboda11 updated this revision to Diff 321135. jansvoboda11 added a comment. Revert reporting failure when parsing sanitizers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95793/new/ https://reviews.llvm.org/D95793 Files: clang/include/clang

[PATCH] D95792: [clang][cli] Report result of ParseLangArgs

jansvoboda11 updated this revision to Diff 321136. jansvoboda11 added a comment. Rely on DiagnosticsEngine when reporting parsing result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95792/new/ https://reviews.llvm.org/D95792 Files: clang/includ

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. In D94745#2539454 , @JonChesterfield wrote: > I think there's a bug report about this. Sycl (iirc) introduced a change that > caught invalid things with types that were previously ignored. @jdoerfert is > on point I think

[PATCH] D95901: [CUDA][HIP] Fix device variable linkage

tra added a comment. > For -fgpu-rdc, shadow variables should not be internalized, otherwise they > cannot be accessed by other TUs. > This is necessary because the shadow variable of external device variables > are always emitted as undefined symbols, which need to resolve to a global > symbo

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 321137. jansvoboda11 added a comment. Herald added a subscriber: mgorny. Don't round-trip when the driver says so. Round-trip all the time when built to do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Looks great. Thanks again David. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95872/new/ https://reviews.llvm.org/D95872 ___

[PATCH] D94745: [OpenMP][deviceRTLs] Build the deviceRTLs with OpenMP instead of target dependent language

protze.joachim added a comment. Sorry, I meant to disable building of the cuda device-runtime, or whatever is breaking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/D94745 _

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321139. RedDocMD added a comment. Cleaner implementation of the popping logic, using STL/LLVM algorithms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 Files: clang

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD marked 2 inline comments as done. RedDocMD added a comment. @vsavchenko , I have used the logic that you suggested and put in a better assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 __

  1   2   3   >