[PATCH] D95635: [CMake] Actually require python 3.6 or greater

JDevlieghere added a comment. > However, the project claims to require 3.6 or greater, and 3.6 features are > being used. Can you link to where it says that? I'm not opposed to making 3.6 minimally required version, but at least for LLDB we don't have that requirement and we have documentation

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

dexonsmith added a comment. In D95514#2528407 , @Bigcheese wrote: > In D95514#2528324 , @jansvoboda11 > wrote: > >> I've looked through all option classes in `CompilerInvocation`, and >> `AnalyzerOptions::Config`

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, unless @MaskRay has any other concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally required ve

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. This is getting close! A few more comments inline. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:584-589 +static bool Equal(const ArgStringList &A,

[PATCH] D95366: [clang][cli] Generate and round-trip preprocessor options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3093 + +static bool ParsePreprocessorArgs(PreprocessorOptions &Opts, ArgList &Args,

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 319929. serge-sans-paille added a comment. Back to the previous version, as suggested by @rsmith . I made a few updates to `NamedDecl::isReserved` which get me close to the expected result, without too much overhead. CHANGES SINCE LAST ACTION h

[PATCH] D95629: [clang][analyzer] Own string keys in AnalyzerOptions::ConfigTable

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. > This patch replaces StringMap<...> with std::map in > AnalyzerOptions::ConfigTable. It seems to be the only non-owning reference to > command line arguments in the whole Co

[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822 + static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args,

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319936. thakis edited the summary of this revision. thakis added a comment. Seems like there are no strong opinions, so now with actual code. I went with "VC/Tools/MSVC/XXX" and "Windows Kits/10" since that seems like the obvious thing. CHANGES SINCE LAST A

[PATCH] D95634: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Conanap marked 4 inline comments as done. Closed by commit rG2e470e03b49f: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases (authored by Conana

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +LookupResult IdentifierLookup(*this, II, SourceLocation(), +

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319938. thakis added a comment. add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/MSVC.cpp clang/test/Driver/cl-sysroot.cp

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 319940. Charusso marked 6 inline comments as done. Charusso added a comment. - Fix everything. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/ https://reviews.llvm.org/D69726 Files: clang/docs/analyzer/developer-docs/DebugChecks.rst c

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso added a reviewer: vsavchenko. Charusso added a comment. Hey, I am back. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h:41-44 +/// Set the dynamic size of a CXXNewExpr \p NE by its region \p MR. +ProgramStateRef setDynamicSize(ProgramSt

[clang] 6f0df3c - [ASTMatchers] Avoid pathological traversal over nested lambdas

Author: Stephen Kelly Date: 2021-01-28T20:45:45Z New Revision: 6f0df3cddb3e3f38df1baa7aa4d743a74bb46688 URL: https://github.com/llvm/llvm-project/commit/6f0df3cddb3e3f38df1baa7aa4d743a74bb46688 DIFF: https://github.com/llvm/llvm-project/commit/6f0df3cddb3e3f38df1baa7aa4d743a74bb46688.diff LOG:

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f0df3cddb3e: [ASTMatchers] Avoid pathological traversal over nested lambdas (authored by stephenkelly). Changed prior to commit: https://reviews.

[clang] 3c79734 - [ASTMatchers] Add invocation matcher

Author: Stephen Kelly Date: 2021-01-28T20:47:09Z New Revision: 3c79734f29284d6b54f1867a03428a3d9fd338d9 URL: https://github.com/llvm/llvm-project/commit/3c79734f29284d6b54f1867a03428a3d9fd338d9 DIFF: https://github.com/llvm/llvm-project/commit/3c79734f29284d6b54f1867a03428a3d9fd338d9.diff LOG:

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c79734f2928: [ASTMatchers] Add invocation matcher (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94865?vs=319672&id=319943#toc Repository: rG LLVM Github Monorepo CH

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille marked an inline comment as done. serge-sans-paille added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +LookupResu

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

hans added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:75 + for (llvm::sys::fs::directory_iterator DirIt(Directory, EC), DirEnd; + DirIt != DirEnd && !EC; DirIt.increment(EC)) { +if (!llvm::sys::fs::is_directory(DirIt->path())) fo

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau added a comment. In D95635#2528851 , @JDevlieghere wrote: >> However, the project claims to require 3.6 or greater, and 3.6 features are >> being used. > > Can you link to where it says that? I'm not opposed to making 3.6 the > minimally requir

[PATCH] D94880: Add clang-query support for mapAnyOf

steveire added a comment. @aaron.ballman Please review this again as I've merged some more needed changes into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94880/new/ https://reviews.llvm.org/D94880 __

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis updated this revision to Diff 319949. thakis marked an inline comment as done. thakis added a comment. address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95534/new/ https://reviews.llvm.org/D95534 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Tool

[PATCH] D95534: clang-cl: Invent a /winsysroot concept

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:75 + for (llvm::sys::fs::directory_iterator DirIt(Directory, EC), DirEnd; + DirIt != DirEnd && !EC; DirIt.increment(EC)) { +if (!llvm::sys::fs::is_directory(DirIt->path()))

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

vabridgers added a subscriber: lattner. vabridgers added a comment. Gentle and polite ping :) Could someone have a look at this? @rsmith , or @lattner ? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71714/new/ https://reviews.llvm.org/D71

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2527437 , @vitalybuka wrote: > Our Android build bot is broken after this patch > http://lab.llvm.org:8011/#/builders/77/builds/3234 Shouldn't that build be using lld? In D95166#2526839

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

ilinpv updated this revision to Diff 319951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93585/new/ https://reviews.llvm.org/D93585 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChai

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

rsmith added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2063-2065 + if (const auto *MD = dyn_cast(D)) { +if (const CXXRecordDecl *RD = MD->getParent()) { + if (RD->isLambda()) { This is incorrectly skipping the bodies of

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Herald added a reviewer: jansvoboda11. Hi, John, sorry for the delay. I'm still in the middle of something. will context-switch a little bit latter. thanks, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire created this revision. steveire added a reviewer: rsmith. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95644 Files: clang/include/clang/AST/RecursiveAS

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:485 + A a; + auto l = [a] { }; + auto lCopy = l; I don't know how to create a lambda with a default ctor body. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

steveire added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2063-2065 + if (const auto *MD = dyn_cast(D)) { +if (const CXXRecordDecl *RD = MD->getParent()) { + if (RD->isLambda()) { rsmith wrote: > This is incorrectly skipp

[PATCH] D95614: [clang-tidy] Applied clang-tidy fixes. NFC

alexfh updated this revision to Diff 319979. alexfh added a comment. Manually cleaned up suboptimal fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95614/new/ https://reviews.llvm.org/D95614 Files: clang-tools-extra/clang-tidy/abseil/TimeSu

[PATCH] D95614: [clang-tidy] Applied clang-tidy fixes. NFC

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/abseil/TimeSubtractionCheck.cpp:96 void TimeSubtractionCheck::registerMatchers(MatchFinder *Finder) { - for (auto ScaleName : + for (const auto *ScaleName : {"Hours", "Minutes", "Seconds", "Millis",

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaChecking.cpp:13384 case Stmt::MemberExprClass: { expr = cast(expr)->getBase(); break; ilya wrote:

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

rsmith added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2065 if (const CXXRecordDecl *RD = MD->getParent()) { - if (RD->isLambda()) { + if (RD->isLambda() && RD->getLambdaCallOperator() == MD) { VisitBody = VisitBody && getD

[PATCH] D95166: Disable rosegment for old Android versions.

dmajor added a comment. It does feel kind of awkward to me that _this_ is the patch that ends up breaking the builds, versus something at the cmake level that says "you are explicitly unsupported". Also it's unfortunate that this landed just hours before 12.0.0 branched. Had it landed slightly

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire updated this revision to Diff 319987. steveire added a comment. Use helper method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95644/new/ https://reviews.llvm.org/D95644 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/unit

[PATCH] D95166: Disable rosegment for old Android versions.

glandium added a comment. Firefox CI is using a custom clang, but uses a NDK otherwise (an old-ish one, clearly older than r22 which is the first that defaults to lld). And we do pass -fuse-ld=bfd at the moment for $reasons. If clang _really_ wants to assume lld as the linker for android, then i

[clang] d73564c - [DebugInfo][CodeView] Use as the display name for lambdas.

Author: Amy Huang Date: 2021-01-28T16:30:38-08:00 New Revision: d73564c510036b2d4f5858effdcd23fe54fc1063 URL: https://github.com/llvm/llvm-project/commit/d73564c510036b2d4f5858effdcd23fe54fc1063 DIFF: https://github.com/llvm/llvm-project/commit/d73564c510036b2d4f5858effdcd23fe54fc1063.diff LOG

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2065 if (const CXXRecordDecl *RD = MD->getParent()) { - if (RD->isLambda()) { + if (RD->isLambda() && RD->getLambdaCallOperator() == MD) { VisitBody = VisitBody && ge

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd73564c51003: [DebugInfo][CodeView] Use as the display name for lambdas. (authored by akhuang). Changed prior to commit: https://review

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

steveire updated this revision to Diff 319992. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95644/new/ https://reviews.llvm.org/D95644 Files: clang/include/clang/AST/RecursiveASTVisitor.h clang/unittests/ASTMa

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

rsmith added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:485 + A a; + auto l = [a] { }; + auto lCopy = l; steveire wrote: > rsmith wrote: > > steveire wrote: > > > I don't know how to create a lambda with a default cto

[clang] 9b21d4b - Revert "[DebugInfo][CodeView] Use as the display name for lambdas."

Author: Amy Huang Date: 2021-01-28T16:41:26-08:00 New Revision: 9b21d4b9434d2d4796b0d60d64f6ded9bac95441 URL: https://github.com/llvm/llvm-project/commit/9b21d4b9434d2d4796b0d60d64f6ded9bac95441 DIFF: https://github.com/llvm/llvm-project/commit/9b21d4b9434d2d4796b0d60d64f6ded9bac95441.diff LOG

Re: [clang] 9b21d4b - Revert "[DebugInfo][CodeView] Use as the display name for lambdas."

On Thu, 28 Jan 2021 at 16:41, Amy Huang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Amy Huang > Date: 2021-01-28T16:41:26-08:00 > New Revision: 9b21d4b9434d2d4796b0d60d64f6ded9bac95441 > > URL: > https://github.com/llvm/llvm-project/commit/9b21d4b9434d2d4796b0d60d64f6ded9bac95

[clang] 43cc4f1 - Ensure that we traverse non-op() method bodys of lambdas

Author: Stephen Kelly Date: 2021-01-29T00:49:28Z New Revision: 43cc4f15008f8c700497d3d2b7020bfd29f5750f URL: https://github.com/llvm/llvm-project/commit/43cc4f15008f8c700497d3d2b7020bfd29f5750f DIFF: https://github.com/llvm/llvm-project/commit/43cc4f15008f8c700497d3d2b7020bfd29f5750f.diff LOG:

[PATCH] D95644: Ensure that we traverse non-op() method bodys of lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43cc4f15008f: Ensure that we traverse non-op() method bodys of lambdas (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getLocation(), "_Static_assert"); I don't thin

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 320001. ahatanak added a comment. Herald added a subscriber: laytonio. Teach `markTails` to ignore operand bundle `clang.arc.rv` when determining whether a call can be marked as tail. `ObjCARCOpt::OptimizeReturn` cannot eliminate the retainRV/autoreleaseRV

[PATCH] D95017: [clang-format] Add case aware include sorting.

kentsommer updated this revision to Diff 320007. kentsommer added a comment. NFC rebase to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs

[PATCH] D95653: [cte] [clang-tidy] Fix linking tests to LLVMTestingSupport

mgorny created this revision. mgorny added reviewers: njames93, aaron.ballman. Herald added subscribers: usaxena95, kadircet, xazax.hun. mgorny requested review of this revision. Herald added a subscriber: ilya-biryukov. LLVMTestingSupport is not part of libLLVM, and therefore can not be linked to

[PATCH] D95607: Fix traversal with hasDescendant into lambdas

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95607/new/ https://reviews.llvm.org/D95607 __

[PATCH] D95562: [ASTMatchers] Fix traversal below range-for elements

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95562/new/ https://reviews.llvm.org/D95562 __

[PATCH] D89380: [clang-tidy] Fix for cppcoreguidelines-prefer-member-initializer to handle classes declared in macros

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Herald added a subscriber: shchenz. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-prefer-member-initializer.cpp:6 +//of this

[PATCH] D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--)

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Apologies again for the long delay. A diff with full context would still be appreciated. Please read https://llvm.org/docs/Phabricator.html for instructions. The clang-tools-extra/t

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2529412 , @dmajor wrote: > It does feel kind of awkward to me that _this_ is the patch that ends up > breaking the builds, versus something at the cmake level that says "you are > explicitly unsupported". If you're u

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic created this revision. rsanthir.quic added reviewers: t.p.northover, pbarrio. Herald added subscribers: hiraditya, kristof.beyls. rsanthir.quic requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This adds SM3 an

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang updated this revision to Diff 320020. akhuang added a comment. Fix test / string code after test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95187/new/ https://reviews.llvm.org/D95187 Files: clang/include/clang/AST/Mangle.h

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5f5deee9ee9: Reland "[DebugInfo][CodeView] Use as the display name for lambdas" (authored by akhuang). Repository: rG LLVM Github Mono

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

alexfh added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:54-60 +#include "../../clang-tools-extra/clang-tidy/ClangTidyCheck.h" +#include "../../clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h" +#include "../../clang-tools-extra/c

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem updated this revision to Diff 320025. gulfem added a comment. 1. Simplified test cases and increased readibility of the tables 2. Added x86_64 and aarch64 check and tiny or small code modes check to ensure 32 offsets 3. Modified single value test case Repository: rG LLVM Github Monorep

[PATCH] D95655: Adding Neon Sm3 & Sm4 Intrinsics

rsanthir.quic added a comment. This is the first in a series of patches that will address the following: https://bugs.llvm.org/show_bug.cgi?id=47828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95655/new/ https://reviews.llvm.org/D95655 _

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

phosek created this revision. phosek added reviewers: mgorny, davidxl, vsk. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses PR48930. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95658 Files: cl

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem marked 9 inline comments as done. gulfem added inline comments. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1 %s -triple=aarch64-unknown-fuchsia -O2 -fno-PIC -S -emit-llvm -o

[clang] 7ef79bb - Fix typo in "[DebugInfo][CodeView] Use as the display name for lambdas."

Author: Amy Huang Date: 2021-01-28T19:03:41-08:00 New Revision: 7ef79bb8e240aafab265107b8b7d63d3e32ddb93 URL: https://github.com/llvm/llvm-project/commit/7ef79bb8e240aafab265107b8b7d63d3e32ddb93 DIFF: https://github.com/llvm/llvm-project/commit/7ef79bb8e240aafab265107b8b7d63d3e32ddb93.diff LOG

[PATCH] D95653: [cte] [clang-tidy] Fix linking tests to LLVMTestingSupport

njames93 added a comment. I think I introduced this failure due to my abysmal knowledge of CMake and LLVM's library structure, So I'm definitely not qualified to say if this is a good fix, but seeing as it fixes the linker error I'll give it a tentative LG. CHANGES SINCE LAST ACTION https://

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mtrofin created this revision. Herald added subscribers: kerbowa, mstorsjo, nhaehnle, jvesely. mtrofin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95660 Files: clang/te

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

NoQ added inline comments. Comment at: clang/include/clang/Basic/Features.def:256 EXTENSION(pragma_clang_attribute_external_declaration, true) +EXTENSION(statement_attributes_with_gnu_syntax, true) EXTENSION(gnu_asm, LangOpts.GNUAsm) People seem to occasionally

[PATCH] D95128: [clang-format] [NFC] Remove unused arguments

HazardyKnusperkeks closed this revision. HazardyKnusperkeks added a comment. Commited but forgot the Differential Link in the Message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95128/new/ https://reviews.llvm.org/D95128 ___

[clang] 078f30e - [clang-format] Add option to control the spaces in a line comment

Author: Björn Schäpers Date: 2021-01-29T07:00:08+01:00 New Revision: 078f30e04d1fcb5a05d8e340f3178f3478075541 URL: https://github.com/llvm/llvm-project/commit/078f30e04d1fcb5a05d8e340f3178f3478075541 DIFF: https://github.com/llvm/llvm-project/commit/078f30e04d1fcb5a05d8e340f3178f3478075541.diff

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

This revision was automatically updated to reflect the committed changes. Closed by commit rG078f30e04d1f: [clang-format] Add option to control the spaces in a line comment (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D92257?vs=317294&id=320046#toc Reposi

[PATCH] D95128: [clang-format] [NFC] Remove unused arguments

curdeius added a comment. Could you please note here the git hash please? For the record. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95128/new/ https://reviews.llvm.org/D95128 ___ cfe-commits mailing

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

NoQ added a comment. > What I want to avoid is having a static analyzer-specific suppression > attribute, and a different one for clang-tidy, and a third one for the > frontend. Given that there are already multiple suppression mechanisms circulating around (clang-tidy's `// NOLINT`, frontend

[clang-tools-extra] ec81289 - [clang-tidy] bugprone-assert-side-effect: Improve warning message.

Author: Artem Dergachev Date: 2021-01-28T22:31:49-08:00 New Revision: ec812898318036f6c33579b1d35c1a7f83cf112f URL: https://github.com/llvm/llvm-project/commit/ec812898318036f6c33579b1d35c1a7f83cf112f DIFF: https://github.com/llvm/llvm-project/commit/ec812898318036f6c33579b1d35c1a7f83cf112f.dif

[clang-tools-extra] b92a39a - [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default.

Author: Artem Dergachev Date: 2021-01-28T22:31:49-08:00 New Revision: b92a39ac1319c796777bca19a3af2856acbc69c1 URL: https://github.com/llvm/llvm-project/commit/b92a39ac1319c796777bca19a3af2856acbc69c1 DIFF: https://github.com/llvm/llvm-project/commit/b92a39ac1319c796777bca19a3af2856acbc69c1.dif

[PATCH] D95515: [clang-tidy] bugprone-assert-side-effect: Improve warning message.

This revision was automatically updated to reflect the committed changes. Closed by commit rGec8128983180: [clang-tidy] bugprone-assert-side-effect: Improve warning message. (authored by dergachev.a). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Git

[PATCH] D95519: [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb92a39ac1319: [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default. (authored by dergachev.a). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

jdoerfert created this revision. jdoerfert added reviewers: tra, hliao, yaxunl, ldionne, compnerd, Fznamznon, erichkeane, rsmith, mclow.lists. Herald added subscribers: kerbowa, nhaehnle, jvesely, jholewinski. Herald added a reviewer: bollu. jdoerfert requested review of this revision. Herald adde

[PATCH] D78513: [hip] Claim builtin type `__float128` supported if the host target supports it.

jdoerfert added a comment. In D78513#1993210 , @hliao wrote: > In D78513#1993115 , @yaxunl wrote: > >> Currently if instructions of float128 get to amdgpu backend, are we going to >> crash? > > As `Float128Format`

[PATCH] D95403: [clang-tidy][analyzer][WIP] Clang-tidy reverse integration into Static Analyzer.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:54-60 +#include "../../clang-tools-extra/clang-tidy/ClangTidyCheck.h" +#include "../../clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h" +#include "../../clang-tools-extra/clan

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 320058. HazardyKnusperkeks added a comment. Rebased and Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93844/new/ https://reviews.llvm.org/D93844 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:10117 +TSK == TSK_ExplicitInstantiationDefinition && Prev && +!Context.hasSameTypeIgnoreLifetime(Prev->getType(), R)) { + Diag(T->getTypeLoc().getBeginLoc(), nomanous

[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

mstorsjo added a comment. Ok for the fsanitize.c bits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95660/new/ https://reviews.llvm.org/D95660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D95670: [clangd] Don't rely on builtin headers for document-link.test.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. This test seems to be failing at HEAD. Repository: rG LLVM

[clang-tools-extra] f25a57e - [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

Author: Haojian Wu Date: 2021-01-29T08:22:23+01:00 New Revision: f25a57e248a095054a6088b4ffc060e87cd42bc7 URL: https://github.com/llvm/llvm-project/commit/f25a57e248a095054a6088b4ffc060e87cd42bc7 DIFF: https://github.com/llvm/llvm-project/commit/f25a57e248a095054a6088b4ffc060e87cd42bc7.diff LO

[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf25a57e248a0: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

<    1   2