dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822
+
static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args,
DiagnosticsEngine &Diags) {
----------------
Can you rename this `ParseAnalyzerArgsImpl` for better readability?
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1002
+
+ return RoundTrip(Parse, Generate, Swap, Res, Args, Diags, "AnalyzerOptions");
+}
----------------
I wonder if these lambdas could/should just be defined inline in the call to
`RoundTrip`, but up to you to decide.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95369/new/
https://reviews.llvm.org/D95369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
