[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

This revision was automatically updated to reflect the committed changes. Closed by commit rG127091bfd5ed: [CUDA] Normalize handling of defauled dtor. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94732/new/ https://reviews.llvm.o

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 318257. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/LangOptions.h clang/include/clang/Bas

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

jrtc27 added a comment. There are a lot of "Resolve for v1.0" issues open against the spec still. Are we sure we want to brand this as 1.0? It will end up as such in the ELF attributes and thus be deemed compatible with future "real" 1.0 binaries. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851 +return "csllvm"; + default: +llvm_unreachable("unknown instrumentation type"); vsk wrote: > If we add an instrumenta

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

dexonsmith added a comment. Thanks for splitting this out! The looks good, just a few nits in line below. I also have a question about the test. Comment at: clang/lib/Tooling/Tooling.cpp:440 + // names. + auto ArgsEnd = Args.end(); + for (auto I = Args.begin(), E = Args.end

[PATCH] D95154: [WIP][clang][Fuchsia] Add the *-fuchsia-gnu arch and multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added subscribers: s.egerton, simoncook, mgorny. leonardchan requested review of this revision. Create libraries that are GCC compaitble. Repository: rG LLVM Github Mono

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

dexonsmith added a comment. In D92191#2512960 , @saudi wrote: > Removed the support for "--" command lines, it was extracted to patch D95099 > . > Applied suggested fixes. Thanks! @Bigcheese, since you reviewed the origi

[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in CCGExprConstant. NFC

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Clang has generally made a point of trying to be as neutral about `CHAR_BITS` as it can be, even though LLVM has not. As the code owner of this code, I view this as a fix consistent with

[PATCH] D94633: [FunctionAttrs] Infer willreturn for functions without loops

This revision was automatically updated to reflect the committed changes. Closed by commit rG65fd034b95d6: [FunctionAttrs] Infer willreturn for functions without loops (authored by nikic). Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Changed prior to commit:

[clang] 65fd034 - [FunctionAttrs] Infer willreturn for functions without loops

Author: Nikita Popov Date: 2021-01-21T20:29:33+01:00 New Revision: 65fd034b95d69fa0e634861ee165b502ceb92a12 URL: https://github.com/llvm/llvm-project/commit/65fd034b95d69fa0e634861ee165b502ceb92a12 DIFF: https://github.com/llvm/llvm-project/commit/65fd034b95d69fa0e634861ee165b502ceb92a12.diff

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

akyrtzi created this revision. Herald added subscribers: dang, arphaman. Herald added a reviewer: jansvoboda11. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses an issue with how the PCH preable works, specifically: 1

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak marked an inline comment as done. ahatanak added a comment. Add helper functions to ObjCARCRVAttr.h for adding, removing, or looking up attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight updated this revision to Diff 318277. jyknight marked 8 inline comments as done. jyknight added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93922/new/ https://reviews.llvm.org/D93922 Files: clang/lib/AST/I

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4010 +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) { + Out << "u8__uuidof"; rsmith wrote: > Should this be `>= Ver12` /

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 318278. ahatanak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/lib/CodeGen/CGObjC.cpp clang/test/CodeGenObjC/arc-rv-a

[PATCH] D95145: [clang] Fix a nullptr dereference bug on invalid code

hokein added inline comments. Comment at: clang/test/SemaCXX/subst-func-type-invalid-ret-type.cpp:2 +// RUN: %clang -fsyntax-only -std=c++17 %s -Xclang -verify +#include + A common practice is to avoid depending on STL in tests. I think we need to pull out (eve

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ABataev. Herald added subscribers: dang, guansong, yaxunl. Herald added a reviewer: jansvoboda11. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Hera

[PATCH] D95147: [clang][cli] Port visibility LangOptions to marshalling system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95147/new/ https://reviews.llvm.org/D95147

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end It's hard to tell what Clang makes of this, I t

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert created this revision. danalbert added a reviewer: srhines. danalbert added a project: clang. danalbert requested review of this revision. The unwinder used by the crash handler on versions of Android prior to API 29 did not correctly handle binaries built with rosegment, which is enable

[PATCH] D95168: Add InsertBraces option

tiagoma created this revision. tiagoma requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. InsertBraces will insert braces for single line control flow statements (currently if/else/for). It currently accepts the following options: - Never -

[PATCH] D92136: [clang] Enhanced test for --relocatable-pch, and corresponding fixes for Windows

rnk added a comment. Seems reasonable Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:534 +#ifdef _WIN32 +// Support special case of Windows absolute file paths rnk wrote: > I think looking for a slash after the colon is a bit more robust,

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307 + // Only alphanumeric and underscore is allowed in -cuid option. + if (auto *A = Args.getLastArg(OPT_cuid_EQ)) { +const char *V = A->getValue()

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

rjmccall added a comment. Okay, so it's important that we emit both attributes? I'll take your word for it. Comment at: llvm/include/llvm/Analysis/ObjCARCRVAttr.h:56 + if (hasRetainRVOrClaimRVAttr(CB)) +CB->removeAttribute(llvm::AttributeList::ReturnIndex, getRVAttrKeySt

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi updated this revision to Diff 318304. saudi marked 5 inline comments as done. saudi added a comment. Updated for suggested modifications CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95099/new/ https://reviews.llvm.org/D95099 Files: clang/lib/Tooling/Tooling.cpp clang/test/Cl

[PATCH] D95099: [clang-scan-deps] : Support -- in clang command lines.

saudi added inline comments. Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:12-16 { "directory": "DIR", - "command": "clang -E DIR/regular_cdb_input.cpp -IInputs -o adena.o", + "command": "clang -E -IInputs -o adena.o -- DIR/regular_cdb_input.cpp", "file":

[PATCH] D95070: Fix crash when emitting NullReturn guards for functions returning BOOL

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oops. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95070/new/ https://reviews.llvm.org/D95070 _

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

rnk added a comment. I guess the spelling -fc++-abi= is intuitive, discoverable, and easy to use. I'd be OK going back to that, as long as the compiler knows which ABIs work on which targets and rejects the unsupported configurations. Regarding the idea of separating the platform ABI from the C

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93668/new/ https://reviews.llvm.org/D93668 ___ c

[PATCH] D95154: [WIP][clang][Fuchsia] Add the *-fuchsia-gnu arch and multilibs

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:148 + + foreach(name i386;x86_64;aarch64;riscv64;x86_64_gnu;aarch64_gnu) +if(${name} MATCHES ".*_gnu$") I'd just iterate over full triples rather than doing the `.*_gnu` replac

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

akyrtzi updated this revision to Diff 318314. akyrtzi added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159 Files: clang/include/clang/Driver/Options.td clang/include/cla

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM, just the one minor comment Comment at: clang/lib/Serialization/ASTReader.cpp:2221- + // validation for the PCH and the modules it loads. + ModuleKind K = Curr

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 318315. njames93 added a comment. Split up the code a little more. Fix a few malformed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/ https://reviews.llvm.org/D94942 Files: clang-tools-e

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ImplementAbstract.cpp:38-40 + // If we have any pure virtual methods declared in the root (The class + // this tweak was invoked on), assume the user probably doesn't want to + //

[PATCH] D95168: Add InsertBraces option

curdeius added a comment. There's a clang-tidy check for it. And clang-format should not, IMO, add not remove tokens but only handle whitespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168

[PATCH] D95128: [clang-format] [NFC] Remove unsued arguments

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Thanks for tidying up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95128/new/ https://reviews.llvm.org/D95128 _

[PATCH] D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Just an assert is ok IMO. We may fix it when LLVM will be compiled with C++20 but this code may change before it happens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 1deee5c - Fix crash when emitting NullReturn guards for functions returning BOOL

Author: Jon Roelofs Date: 2021-01-21T14:29:36-08:00 New Revision: 1deee5cacbb76578367186d7ff2937b6fa79b827 URL: https://github.com/llvm/llvm-project/commit/1deee5cacbb76578367186d7ff2937b6fa79b827 DIFF: https://github.com/llvm/llvm-project/commit/1deee5cacbb76578367186d7ff2937b6fa79b827.diff L

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. I do not have commit access. Full Name: Kent Sommer Email: w...@kentsommer.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___ cf

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2342 +attrs = attrs.addAttribute(CGF.getLLVMContext(), + llvm::AttributeList::ReturnIndex, "rv_marker"); +callBase->setAttributes(attrs); rjmccall wrote

[PATCH] D95181: [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver check

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, jkorous. ahatanak requested review of this revision. This patch fixes a bug in `emitARCOperationAfterCall` where it inserts the fall-back call after a bitcast

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2342 +attrs = attrs.addAttribute(CGF.getLLVMContext(), + llvm::AttributeList::ReturnIndex, "rv_marker"); +callBase->setAttributes(attrs); ahatanak wrote

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

modimo added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } wenlei wrote: > modimo wrote: > > wenlei wrote: > > > nit: any special reason for adding this? doesn't seem consistent with > > > other remarks we have. > >

[PATCH] D95181: [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver check

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This looks good, but in the long term it would be great if we could eliminate the need for `emitARCOperationAfterCall` and just emit the call properly in the first place. Please add a tes

[PATCH] D95168: Add InsertBraces option

tiagoma added a comment. Some background might be useful. I work at Microsoft (Office to be precise). We have our own fork of LLVM internally and I am starting to upstream some of the changes in our fork. > There's a clang-tidy check for it. Yes - readability-braces-around-statements. I would

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

akyrtzi updated this revision to Diff 318333. akyrtzi added a comment. Use `getValueOr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159 Files: clang/include/clang/Driver/Options.td clang/include/clang/F

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

akyrtzi updated this revision to Diff 318335. akyrtzi edited the summary of this revision. akyrtzi added a comment. Fix typo in commit message, 'state' -> 'stale' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

HsiangKai added a comment. In D94583#2513070 , @jrtc27 wrote: > There are a lot of "Resolve for v1.0" issues open against the spec still. Are > we sure we want to brand this as 1.0? It will end up as such in the ELF > attributes and thus be deemed compat

[PATCH] D95182: [clang][Fuchsia] Turn on Relative VTables for Fuchsia

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a reviewer: jansvoboda11. leonardchan requested review of this revision. And also remove `-fexperimental-relative-c++-abi-vtables` from tests that already have fuchsi

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

joewholden updated this revision to Diff 318343. joewholden added a comment. I think this is better (we've been using it for a while successfully), I haven't had time to understand the tests enough to add some yet, but I'll take a look as soon as I can CHANGES SINCE LAST ACTION https://revie

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

joewholden updated this revision to Diff 318346. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80421/new/ https://reviews.llvm.org/D80421 Files: clang/lib/Driver/ToolChains/Linux.cpp Index: clang/lib/Driver/ToolChains/Linux.cpp

[PATCH] D95161: [Clang][OpenMP][NVPTX] Replace `libomptarget-nvptx-path` with `libomptarget-nvptx-bc-path`

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95161/new/ https://reviews.llvm.org/D95161 __

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

MaskRay added a comment. Such driver tests are in `clang/test/Driver/`. You may want to read a few existing mips driver tests and musl tests to figure out whether reusing an existing file or creating a new file makes more sense. You can run a test with `$build/bin/llvm-lit -vv test.c`. `check-c

[PATCH] D70701: Fix more VFS tests on Windows

dexonsmith added a comment. @rnk / @amccarth, I've been looking at the history of `makeAbsolute` being virtual, since it's a bit awkward that `RedirectingFileSystem` behaves differently from the others. I'm hoping you can give me a bit more context. I'm wondering about an alternative implementa

[PATCH] D95187: [DebugInfo][CodeView] Use as the display name for lambdas.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently (for codeview) lambdas have a string like `` in their mangled name, and don't have any display name. Th

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

mcgrathr added a comment. I am also a C++ programmer working on C++ ABI support. I'm glad to be working on a platform that made many intentional design decisions to enable keeping the C++ ABI out of the platform ABI. It makes it vastly easier to do interesting work on C++ ABIs such as what Le

Re: [PATCH] D70701: Fix more VFS tests on Windows

I didn't design VFS. I just fixed a bunch of portability bugs that prevented us from running most of the VFS tests on Windows. If I were designing it, I (hope) I wouldn't have done it this way. But the horse is already out of the barn. Here's my background with VFS (and, specifically, the redi

[PATCH] D95181: [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver check

ahatanak updated this revision to Diff 318366. ahatanak added a comment. Add a test for invoke and a FIXME for eliminating the need for emitARCOperationAfterCall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95181/new/ https://reviews.llvm.org/D9

[clang] 3d349ed - [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver

Author: Akira Hatanaka Date: 2021-01-21T17:38:46-08:00 New Revision: 3d349ed7e1108686271a09314dafaa356df4006d URL: https://github.com/llvm/llvm-project/commit/3d349ed7e1108686271a09314dafaa356df4006d DIFF: https://github.com/llvm/llvm-project/commit/3d349ed7e1108686271a09314dafaa356df4006d.diff

[PATCH] D95181: [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d349ed7e110: [CodeGen][ObjC] Fix broken IR generated when there is a nil receiver (authored by ahatanak). Repository: rG LLVM Github Monorepo CH

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

dexonsmith added a comment. I don't see a test for a case where the mapped directory already exists in the external FS, something like: # external fs /d1/f1 /d2/f2 # redirect fs from yaml (fallthrough: true) /d1 -> /d2 Unless I just missed it, can you add one? My intuition is we'd

[PATCH] D94355: [SimplifyCFG] Add relative switch lookup tables

gulfem updated this revision to Diff 318372. gulfem added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. Apply relative lookup table generation in fPIC mode 2. Add a test case for single value case 3. Remove hard-coding 64 bit pointers 4. Improve implementatio

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318377. tianshilei1992 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added changes in the driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https:/

[PATCH] D70701: Fix more VFS tests on Windows

dexonsmith added a comment. Thanks for the quick and detailed response! Your explanation of hybrid behaviour on Windows was especially helpful, as I didn't fully understand how that worked before. One thing I see, but wasn't obvious from your description, is that the mixed/hybrid separator beh

[PATCH] D94745: [OpenMP][WIP] Build the deviceRTLs with OpenMP instead of target dependent language - NOT FOR REVIEW

tianshilei1992 updated this revision to Diff 318398. tianshilei1992 added a comment. Droped the forward declaration and rewrote CUDA intrinsics with LLVM instrinsics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94745/new/ https://reviews.llvm.org/

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

jrtc27 added a comment. In D94583#2513915 , @HsiangKai wrote: > In D94583#2513070 , @jrtc27 wrote: > >> There are a lot of "Resolve for v1.0" issues open against the spec still. >> Are we sure we want to brand this

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

jrtc27 added a comment. (Their problem stems from having 1.0 drafts before they've resolved all the outstanding issues and frozen the instruction set; if they didn't jump the gun then things would be saner for people implementing it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

kito-cheng added a comment. @jrtc27 just let you know I have same concern too, that's one major reason why we don't upstream those extension on GNU toolchain... we are intend to introduce an internal revision number on ELF attribute in near future, e.g. v-ext 0.9.1 / v0p9p1 to prevent compatibl

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. In D88220#2495071 , @Quuxplusone wrote: > I notice a lack of any explicitly `co_return`-related tests and/or code in > this patch. I'm just going to assume that is fine. `co_return` related implicit move is implemented by @aa

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 318406. nullptr.cpp added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4669 << A->getSpelling() << RawTriple.str(); -if (!Args.hasArg(options::OPT_maltivec)) - D.Diag(diag::err_aix_altivec); +if (Args.hasArg(options::OPT_mabi_EQ_ve

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0e89906f5b7: [ASTReader] Allow controlling separately whether validation should be disabled… (authored by akyrtzi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] b0e8990 - [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

Author: Argyrios Kyrtzidis Date: 2021-01-21T20:45:54-08:00 New Revision: b0e89906f5b7e505a1ea315ab4ff612b1607fda8 URL: https://github.com/llvm/llvm-project/commit/b0e89906f5b7e505a1ea315ab4ff612b1607fda8 DIFF: https://github.com/llvm/llvm-project/commit/b0e89906f5b7e505a1ea315ab4ff612b1607fda8.

[PATCH] D95202: ADT: Use 'using' to inherit assign and append in SmallString

dexonsmith created this revision. dexonsmith added a reviewer: dblaikie. Herald added subscribers: ributzka, hiraditya. dexonsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Rather than reimplement, use a `using` declaration to br

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 318420. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/c

[PATCH] D95204: [lld-macho] switch default to new Darwin port

gkm created this revision. gkm added a reviewer: lld-macho. Herald added subscribers: pengfei, steven_wu, hiraditya, kristof.beyls, mgorny. gkm requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. In advance of the LLV

[PATCH] D95206: [clangd][SwapIndex] ensure that the old index is alive while we are using it via the function returned by `SwapIndex::indexedFiles()` call

ArcsinX created this revision. ArcsinX added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch the old index coul

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. > I may be over-reacting to the way the patch seemed to be touching on the C++ > ABI in multiple places. My understanding is that `ms_abi` is just a > calling-convention attribute; it's basically "use the (default) calling > convention that MSVC would use for this func

[PATCH] D95168: Add InsertBraces option

curdeius added a comment. True, I was aware of the presence of some of these options, thank you for indicating others. I'm not yet entirely convinced, especially that clang-tidy behaviour would be possibly different. Anyway, a few comments just from the first glance. Comment

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:642-649 +const internal::VariadicDynCastAllOfMatcher cxxFoldExpr; + +AST_MATCHER_P(CXXFoldExpr, hasOperator, BinaryOperatorKind, Op) { + return Node.getOperator() == Op; +} +AST_MATCHER(CXXFoldEx

[PATCH] D94844: [VFS] Add support to RedirectingFileSystem for mapping a virtual directory to one in the external FS.

nathawes planned changes to this revision. nathawes added a comment. Thanks for reviewing @dexonsmith! > I don't see a test for a case where the mapped directory already exists in > the external FS ... Unless I just missed it, can you add one? I believe the `clang/test/VFS/directory.c` regressi

[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

FreddyYe updated this revision to Diff 318128. FreddyYe added a comment. Fix Lint: Pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94466/new/ https://reviews.llvm.org/D94466 Files: clang/lib/CodeGen/CGStmt.cpp clang/test/CodeGen

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 318132. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/LangOptions.h clang/include/clang/Bas

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as not done. phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2591 + } + return false; +} davidxl wrote: > phosek wrote: > > davidxl wrote: > > > If the profile list contains only one line of exclude

[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in ConstantAggregateBuilderUtils. NFC

bjope updated this revision to Diff 318135. bjope added a comment. Updated to add CharTy to the CodeGenTypeCache (based on review feedback). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94979/new/ https://reviews.llvm.org/D94979 Files: clang/li

[clang-tools-extra] facea4a - [clangd] Fix a missing override keyword, NFC.

Author: Haojian Wu Date: 2021-01-21T11:06:43+01:00 New Revision: facea4a2d4fa543da2241fb4268c34e9c019fca6 URL: https://github.com/llvm/llvm-project/commit/facea4a2d4fa543da2241fb4268c34e9c019fca6 DIFF: https://github.com/llvm/llvm-project/commit/facea4a2d4fa543da2241fb4268c34e9c019fca6.diff LO

[PATCH] D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis

steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/lib/Analysis/MacroExpansionContext.cpp:210 +} \ No newline at end of file martong wrote: > Missing newline? I honestly don't know why was that not addressed by clang-for

[PATCH] D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix

HazardyKnusperkeks updated this revision to Diff 318151. HazardyKnusperkeks added a comment. Now with `assert`. We could do a `static_assert`, but then we would have to write our own `is_sorted`, since the `std` is only `constexpr` in C++20. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 317919. khchen added a comment. apply clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/include/c

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Paul-C-Anagnostopoulos added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:144 + // This builtin has a masked form. + bit HasMask = 1; + May I recommend that you use 'true' and 'false' for boolean literals. Comment at

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

liaolucy added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:157 + // Reads or writes "memory" or has other side-effects. + bit HasSideEffects = 0; + Where will it be used？Will just marking sideeffect in the llvm/include/llvm/IR/Intri

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:881 +if (!Def->hasSideEffects()) + OS << "\"n\")\n"; +else "n" refers to "nothrow" which means the builtin doesn't throw a C++ exception. None of our builtins thr

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 318102. khchen marked 74 inline comments as done. khchen added a comment. 1. use exponent LMUL. 2. address @Paul-C-Anagnostopoulos 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://rev

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added a comment. marked some inline comments as done except the test generator related part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.llvm.org/D95016 ___ cfe-commit

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie created this revision. haampie added a reviewer: JDevlieghere. Herald added a reviewer: bollu. haampie requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-comm

[PATCH] D95017: [clang-format] add case aware include sorting

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017

[PATCH] D95081: [clang-format] [NFC] Restructure getLineCommentIndentPrefix

HazardyKnusperkeks updated this revision to Diff 318156. HazardyKnusperkeks added a comment. Empty lines removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95081/new/ https://reviews.llvm.org/D95081 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D95128: [clang-format] [NFC] Remove unsued arguments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LL

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 318159. vsavchenko added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: clang/lib/Parse/ParseStmt.cpp clang/test/Parser/stmt-at

  1   2   >