rjmccall added a comment. Okay, so it's important that we emit both attributes? I'll take your word for it.
================ Comment at: llvm/include/llvm/Analysis/ObjCARCRVAttr.h:56 + if (hasRetainRVOrClaimRVAttr(CB)) + CB->removeAttribute(llvm::AttributeList::ReturnIndex, getRVAttrKeyStr()); + ---------------- This is just doing the lookup twice, right? You can just unconditionally remove the attribute, here and below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
