bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land.
LGTM, just the one minor comment ================ Comment at: clang/lib/Serialization/ASTReader.cpp:2221-2222 + // validation for the PCH and the modules it loads. + ModuleKind K = CurrentDeserializingModuleKind.hasValue() ? + CurrentDeserializingModuleKind.getValue() : M.Kind; + ---------------- There's a `getValueOr` method that you could use instead (ie. `CurrentDeserializingModuleKind.getValueOr(M.Kind)`). ================ Comment at: clang/test/Index/preamble-reparse-changed-module.m:8 + +// RUN: env CINDEXTEST_EDITING=1 CINDEXTEST_EXECUTE_COMMAND="cp %S/Inputs/preamble-reparse-changed-module/new-head.h %t/mod/head.h" CINDEXTEST_EXECUTE_AFTER_TRIAL=1 \ +// RUN: c-index-test -test-load-source-reparse 3 local %s -I %t -I %t/mod -fmodules -fmodules-cache-path=%t/mcp 2>&1 | FileCheck %s ---------------- For some reason I was expecting the trial's to be 1 based, not 0. I'm not sure why though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
