[clang] b86e7ae - [clang][driver][NFC][obvious] Remove obsolete unistd.h include

Author: Timm Bäder Date: 2021-01-19T09:22:40+01:00 New Revision: b86e7ae66cb988dda33445c29fa64f93e7ca9c3c URL: https://github.com/llvm/llvm-project/commit/b86e7ae66cb988dda33445c29fa64f93e7ca9c3c DIFF: https://github.com/llvm/llvm-project/commit/b86e7ae66cb988dda33445c29fa64f93e7ca9c3c.diff LO

[PATCH] D94873: [clang] [driver] Remove obsolete unistd.h include

tbaeder added a comment. Pushed as b86e7ae66cb988dda33445c29fa64f93e7ca9c3c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94873/new/ https://reviews.llvm.org/D94873 ___

[PATCH] D94950: [clang] Speculative fix for buffer overrun on raw string parse

jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This attempts to fix a (non-deterministic) buffer overrun when parsing raw string literals during modular build. Similar fix to 4e5b5c36f47c9

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Current indexes merge logic skip data from the static index if the file i

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. Initial discussion https://reviews.llvm.org/D93683?id=313280#inline-875666 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94952/new/ https://reviews.llvm.org/D94952

[clang] 39a2a23 - [clang][cli] Parse Lang and CodeGen options separately

Author: Jan Svoboda Date: 2021-01-19T09:52:46+01:00 New Revision: 39a2a233f88443e865758ba73c156787c77ead2c URL: https://github.com/llvm/llvm-project/commit/39a2a233f88443e865758ba73c156787c77ead2c DIFF: https://github.com/llvm/llvm-project/commit/39a2a233f88443e865758ba73c156787c77ead2c.diff L

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39a2a233f884: [clang][cli] Parse Lang and CodeGen options separately (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 added a comment. Committed with the parsing macro moved to the top of the file as discussed with Michael. This will make following patches cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94682/new/ https://reviews.llvm.org/D946

[PATCH] D94930: [RISCV] Add support for Zvamo/Zvlsseg to driver

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94930/new/ https://reviews.llvm.org/D94930 __

[clang] 7e1d222 - [X86][AMX] Fix the typo.

Author: Luo, Yuanke Date: 2021-01-19T16:57:34+08:00 New Revision: 7e1d2224b42b411acf2d3cb20e3cf5a564ef79bb URL: https://github.com/llvm/llvm-project/commit/7e1d2224b42b411acf2d3cb20e3cf5a564ef79bb DIFF: https://github.com/llvm/llvm-project/commit/7e1d2224b42b411acf2d3cb20e3cf5a564ef79bb.diff L

[PATCH] D94943: [X86][AMX] Fix the typo.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e1d2224b42b: [X86][AMX] Fix the typo. (authored by LuoYuanke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D94403: [RISCV] Implement new architecture extension macros

kito-cheng added a comment. Just note how current GCC implemented, GCC implement that like implied extension, e.g. `V` implied `Zvamo` and `Zvlsseg`, so `__riscv_zvamo` is naturally defined when `V`-ext is enabled. Comment at: clang/lib/Basic/Targets/RISCV.cpp:148 + if (HasB

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein added a comment. mostly good. I think we'd better bump the index version, even though this is not a breaking change, but we will collect more data. Not bumping the index version may lead to a half-completed state of the index (e.g. only newly-changed files will get completed index data

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

GoBigorGoHome created this revision. GoBigorGoHome added a reviewer: MyDeveloperDay. GoBigorGoHome requested review of this revision. Herald added a project: clang. TT_ForEachMacro should be considered in rules AllowShortBlocksOnASingleLine and AllowShortLoopsOnASingleLine. This fixes bug-46087.

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille added inline comments. Comment at: clang/lib/AST/Decl.cpp:1099 +const DeclContext *CurrentContext = getDeclContext(); +while (true) { + if (isa(CurrentContext)) aaron.ballman wrote: > Rather than trying to manually decide whether th

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux abandoned this revision. yroux added a comment. All patches are now committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054 ___ cfe-commits mailing list

[PATCH] D94957: [clang][cli] Port more options to new parsing system

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: dang, jfb. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds marshalling information to more optio

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInfo(

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki added a comment. I will wait until the end of this week to see if anyone has objections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94599/new/ https://reviews.llvm.org/D94599 ___ cfe-commits ma

[clang] 87dfd5e - [flang][driver] Add support for `-I` in the new driver

Author: Faris Rehman Date: 2021-01-19T11:20:56Z New Revision: 87dfd5e012e147f4bfa3a9a4564e9cbc167278ff URL: https://github.com/llvm/llvm-project/commit/87dfd5e012e147f4bfa3a9a4564e9cbc167278ff DIFF: https://github.com/llvm/llvm-project/commit/87dfd5e012e147f4bfa3a9a4564e9cbc167278ff.diff LOG:

[PATCH] D93453: [flang][driver] Add support for `-I`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87dfd5e012e1: [flang][driver] Add support for `-I` in the new driver (authored by FarisRehman, committed by awarzynski). Changed prior to commit:

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal created this revision. pdhaliwal added reviewers: jdoerfert, grokos, JonChesterfield, ronlieb, ABataev. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-comm

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

simon_tatham added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:81 + union { +SourceRange SingleRange; +unsigned NumRanges; This surely relies on `SourceRange` having no destructor (or rather, a trivial

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

Anastasia added inline comments. Comment at: clang/lib/Basic/TargetInfo.cpp:360 +// Set core features based on OpenCL version +for (auto CoreExt : clang::getCoreFeatures(Opts)) + getTargetOpts().OpenCLFeaturesMap[CoreExt] = true; azabaznov wrote: > a

[PATCH] D94606: [clangd] Move DirBasedCDB broadcasting onto its own thread.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:496 + std::condition_variable CV; + std::atomic ShouldStop = {false}; // Must notify CV

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

JonChesterfield added a comment. This patch was written, roughly, by: - copying the known-working openmp driver from rocm into the trunk source tree - deleting lots of stuff that didn't look necessary - deleting some stuff that is broadly necessary, but the specifics are up for debate The idea

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX updated this revision to Diff 317521. ArcsinX added a comment. Prevent crash in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94952/new/ https://reviews.llvm.org/D94952 Files: clang-tools-extra/clangd/index/BackgroundRebuild.

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 marked an inline comment as done. usaxena95 added a comment. In D94785#2506186 , @hokein wrote: > I think we'd better bump the index version, even though this is not a > breaking change, but we will collect more data. Not bumping the index versi

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317522. usaxena95 added a comment. Index all member functions instead of only polymorphic functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clang-to

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 317523. njames93 added a comment. Update printing policy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94942/new/ https://reviews.llvm.org/D94942 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.

[clang] 2c4f6be - [SystemZ][z/OS] Fix No such file or directory expression error

Author: Abhina Sreeskantharajan Date: 2021-01-19T07:25:24-05:00 New Revision: 2c4f6be86c14c28243915ab9eb3a2ff1902fee99 URL: https://github.com/llvm/llvm-project/commit/2c4f6be86c14c28243915ab9eb3a2ff1902fee99 DIFF: https://github.com/llvm/llvm-project/commit/2c4f6be86c14c28243915ab9eb3a2ff1902f

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316854. HsiangKai added a comment. According to "9. Vector Memory Alignment Constraints" in V specification, change the alignment of RVV types to the element size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

nikic added a comment. As the discussion is spread out across multiple threads, do I understand correctly that the current consensus is to introduce the `-disable-noundef-analysis` flag, and explicitly add it to all the relevant tests (rather than adding it to the substitutions)? In any case,

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added a comment. Ping. If we all agree to use builtin types to model RVV types, is there any other issues we need to address in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

tambre marked an inline comment as done. tambre added a comment. ldionne: ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374 ___ cfe-commits mailing list cfe-co

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://reviews.llvm.org/D94374

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317525. usaxena95 added a comment. Herald added a subscriber: wenlei. Updated index tests's input files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clan

[PATCH] D94933: [clang] Check for nullptr when instantiating late attrs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6f9077b16da: [clang] Check for nullptr when instantiating late attrs (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94933/new/ https:/

[clang] a6f9077 - [clang] Check for nullptr when instantiating late attrs

Author: Adam Czachorowski Date: 2021-01-19T13:43:15+01:00 New Revision: a6f9077b16da90204b296acd4f840769e83460ac URL: https://github.com/llvm/llvm-project/commit/a6f9077b16da90204b296acd4f840769e83460ac DIFF: https://github.com/llvm/llvm-project/commit/a6f9077b16da90204b296acd4f840769e83460ac.d

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

simon_tatham added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:81 + union { +SourceRange SingleRange; +unsigned NumRanges; simon_tatham wrote: > This surely relies on `SourceRange` having no destructor

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added inline comments. Comment at: clang/test/Parser/stmt-attributes.c:5 + + __attribute__((unknown_attribute));// expected-warning {{unknown attribute 'unknown_attribute' ignored}} + __attribute__((unknown_attribute)) {} // expected-warning {{u

[PATCH] D94067: [clang][ASTImporter] Fix a possible assertion failure `NeedsInjectedClassNameType(Decl)'.

martong added a comment. @balazske Thanks Balázs! Great work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94067/new/ https://reviews.llvm.org/D94067 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2504758 , @vsavchenko wrote: > I'll clean up the tests! But, unfortunately, I couldn't proceed with GCC > folks. I asked around and I'm not allowed to do that (company rules). Ah, that's unfortunate. When I get

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2506604 , @aaron.ballman wrote: > In D93630#2504758 , @vsavchenko > wrote: > >> I'll clean up the tests! But, unfortunately, I couldn't proceed with GCC >> folks. I asked a

[PATCH] D94864: [ASTMatchers] Re-order the internals to allow another use-case

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though it would have been a bit easier to review had the rearranging been done in a separate NFC patch. Comment at: clang/unittests/ASTMatchers/ASTMatche

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + I'm not super keen on this name. It's certainly descriptive, but I do wonder if it's a bit too spe

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks good! if you don't mind, could you rerun the benchmark (we have a behavior changes from original version, I guess it won't not change significantly)? and update the data in the

[PATCH] D94876: Remove TypedMatcherOps from VariantValue

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I did some digging to see why this was added in the first place and it came with the original commit of AST matchers. Thank you for the cleanup, LGTM! Repository: rG LLVM Gith

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. In D92797#2505254 , @compnerd wrote: > Ping x 3 Sorry, just came back from holidays. Generally, I have no major concerns. My minor concern is that i

[PATCH] D94877: Add API to retrieve a clade kind from ASTNodeKind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the use of `auto`. Comment at: clang/lib/AST/ASTTypeTraits.cpp:67 +ASTNodeKind ASTNodeKind::getCladeKind() const { + auto LastId = KindId; + w

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12268 + case X86::BI__builtin_ia32_cvtqq2pd512_mask: { +CodeGenFunction::CGFPOptionsRAII FPOptsRAII(*this, E); return EmitX86ConvertIntToFp(*this, Ops, /*IsSigned*/true); pengfei wro

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

aaron.ballman added a comment. I assume the test coverage for this change is from existing tests that are being updated as part of another patch? Or is there test coverage missing for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9487

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2506685 , @hokein wrote: > if you don't mind, could you rerun the benchmark (we have a behavior changes > from original version, I guess it won't not change significantly)? and update > the data in the description bef

[PATCH] D94786: [clang][ASTImporter] Add support for importing CXXFoldExpr.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! Comment at: clang/lib/AST/ASTImporter.cpp:8019 + auto ToType = importChecked(Err, E->getType()); + auto ToCallee = importChecked(Err, E->getCall

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

pdhaliwal updated this revision to Diff 317553. pdhaliwal added a comment. Fix clang-tidy error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp clang/

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

jdoerfert added a comment. Won't this just prevent us from building clang due to the missing cmake changes? We need somewhat testable chunks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94961/new/ https://reviews.llvm.org/D94961 ___

[PATCH] D94961: [OpenMP] Add OpenMP offloading toolchain skeleton for AMDGPU

ABataev added a comment. In D94961#2506460 , @JonChesterfield wrote: > This patch was written, roughly, by: > > - copying the known-working openmp driver from rocm into the trunk source tree > - deleting lots of stuff that didn't look necessary > - deleti

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948 + return {}; +auto VM = Arg.Value.getMatcher(); +if (VM.hasTypedMatcher(NK)) { Note, this is an example of why use of `auto` is discouraged i

[PATCH] D94880: Add clang-query support for mapAnyOf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:1081 +if (NodeKinds.empty()) { + // Set error + return {}

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Quality.cpp:477 + if (MainFileRefs >= 2) { +// E.g.: (2, 1.12), (9, 2.0), (48, 3.0). Can you add a comment ex

[clang-tools-extra] 8bf7116 - [clangd] Index local classes, virtual and overriding methods.

Author: Utkarsh Saxena Date: 2021-01-19T16:18:48+01:00 New Revision: 8bf7116d50bfe8cb881273798ff384ed965c05e9 URL: https://github.com/llvm/llvm-project/commit/8bf7116d50bfe8cb881273798ff384ed965c05e9 DIFF: https://github.com/llvm/llvm-project/commit/8bf7116d50bfe8cb881273798ff384ed965c05e9.diff

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf7116d50bf: [clangd] Index local classes, virtual and overriding methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/

[libunwind] 480643a - [CMake] Remove dead code setting policies to NEW

Author: Raul Tambre Date: 2021-01-19T17:19:36+02:00 New Revision: 480643a95cd157e654f4f97e8231b18850e7d79a URL: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a DIFF: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a.diff L

[clang] 480643a - [CMake] Remove dead code setting policies to NEW

Author: Raul Tambre Date: 2021-01-19T17:19:36+02:00 New Revision: 480643a95cd157e654f4f97e8231b18850e7d79a URL: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a DIFF: https://github.com/llvm/llvm-project/commit/480643a95cd157e654f4f97e8231b18850e7d79a.diff L

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D94624#2501894 , @tomrittervg wrote: > I started trying to work on a patch, but I'm still unpacking from a move and > don't have all m

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. In D94624#2506831 , @aaron.ballman wrote: > In D94624#2501894 , @tomrittervg > wrote: > >> I started trying to work on a patch, but I'm still unpacking from a move and >> don't have a

[PATCH] D94374: [CMake] Remove dead code setting policies to NEW

This revision was automatically updated to reflect the committed changes. Closed by commit rG480643a95cd1: [CMake] Remove dead code setting policies to NEW (authored by tambre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94374/new/ https://review

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEnt

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, AMDChirag, anchu-rajendran, kiranchandramohan, SouraVX, ftynse, kiranktp, fghanim, ABataev. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, rriddle, arphaman, guansong, hiraditya, yaxunl. Mein

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInf

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInfo(

[PATCH] D86465: [analyzer][solver] Redesign constraint ranges data structure

ASDenysPetrov added a comment. I didn't check correctness of each Factory function but if it passes all tests and improves performance, I think it's enough. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h:77-78 + // + // * Range

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D94403: [RISCV] Implement new architecture extension macros

simoncook updated this revision to Diff 317591. simoncook added a comment. Have 'b'/'v' features imply subfeatures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94403/new/ https://reviews.llvm.org/D94403 Files: clang/lib/Basic/Targets/RISCV.cpp

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! Would anybody have a chance to take a look at this? I'd like to submit this before the LLVM 12 branch, if possible? Thanks in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne added a comment. Gentle ping! Can we merge this? I'd love to move forward with https://reviews.llvm.org/D90257. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits mailing list cfe

[PATCH] D94391: CGDebugInfo: Drop Loc.isInvalid() special case from getLineNumber

MaskRay added a comment. In D94391#2495056 , @dblaikie wrote: > I'll leave this one to @aprantl @aprantl :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94391/new/ https://reviews.llvm.org/D94391 ___

[clang] cbdde49 - [clang-format] Apply Allman style to lambdas

Author: Björn Schäpers Date: 2021-01-19T18:17:01+01:00 New Revision: cbdde495ba28915d52b561e44aaba12db4cf724f URL: https://github.com/llvm/llvm-project/commit/cbdde495ba28915d52b561e44aaba12db4cf724f DIFF: https://github.com/llvm/llvm-project/commit/cbdde495ba28915d52b561e44aaba12db4cf724f.diff

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbdde495ba28: [clang-format] Apply Allman style to lambdas (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94906/new/ https:

[PATCH] D94977: [CodeGen] Honor getCharWidth() in CGRecordLowering

bjope created this revision. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using getByteArrayType the requested size was calculated in char units, but the type used for the array was hardcoded to the Int8Ty. Honor the size of c

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

bjope created this revision. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In CGExprConstant.cpp, when dealing with padding etc, some sizes are calculated as char units. But then the type used when creating the aggregate expression

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman added a comment. In D94624#2506906 , @tomrittervg wrote: > In D94624#2506831 , @aaron.ballman > wrote: > >> In D94624#2501894 , @tomrittervg >> wrote: >> >>>

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

lebedev.ri added subscribers: jfb, lebedev.ri. lebedev.ri added a comment. As far as i recall, all RFC's about LLVM support for non-8-bit char targets didn't end in favor of the proposal I'd say that until there's general consensus/buy-in (including testing path), cleaning stuff up will only con

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

bjope added a comment. In D94979#2507242 , @lebedev.ri wrote: > As far as i recall, all RFC's about LLVM support for non-8-bit char targets > didn't end in favor of the proposal > I'd say that until there's general consensus/buy-in (including testing path

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

usaxena95 updated this revision to Diff 317613. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added a comment about the calculation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94927/new/ https://reviews.llvm.org/D94927

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added a comment. Thanks for putting your time into the comment, @dexonsmith. I agree that adding a `-round-trip-args` flag to enable/disable round-tripping is more sensible than hard-coding it via something like `#ifndef NDEBUG`. Providing `-round-trip-args-debug-mode` to help with

[PATCH] D33029: [clang-format] add option for dangling parenthesis

blandcr added a comment. Hi, this is a pretty desirable feature for me and I see there hasn't been any work for a few months. Is this still being worked on and/or is there anything I can do to help it along? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, hubert.reinterpretcast, sfertile, Xiangling_L, etiotto. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we are not using vector code `-maltivec` should not b

[clang-tools-extra] 17846ed - [clangd] Use ASTSignals in Heuristics CC Ranking.

Author: Utkarsh Saxena Date: 2021-01-19T19:48:42+01:00 New Revision: 17846ed5af4a83334ef7d07f0b4a9d525e6ec0db URL: https://github.com/llvm/llvm-project/commit/17846ed5af4a83334ef7d07f0b4a9d525e6ec0db DIFF: https://github.com/llvm/llvm-project/commit/17846ed5af4a83334ef7d07f0b4a9d525e6ec0db.diff

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rsmith created this revision. rsmith added a reviewer: rjmccall. rsmith requested review of this revision. Herald added a project: clang. Under C++ core issue 39, the rules for class-scope name lookup were reworked so that name lookup no longer concerns itself with whether the names were found in

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki updated this revision to Diff 317627. miyuki edited the summary of this revision. miyuki added a comment. Added `static_assert`s that check that `SourceRange` and `SourceLocation` are trivially destructible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:40 +#ifdef __cplusplus #define __CUDA_DEVICE_BUILTIN(FIELD, INTRINSIC) \ Perhaps we should move all C++-related code under `#ifdef __cplusplus`

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

t.p.northover added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1087 FeatureNEON, + FeatureOutlineAtomics, FeaturePerfMon, ilinpv wrote: > t.p.northover wrote: > > I think this st

[clang] 987760b - [www] Fix background color in table cell.

Author: Richard Smith Date: 2021-01-19T11:04:31-08:00 New Revision: 987760b463c1303121fff8197c4ebc66b61f0616 URL: https://github.com/llvm/llvm-project/commit/987760b463c1303121fff8197c4ebc66b61f0616 DIFF: https://github.com/llvm/llvm-project/commit/987760b463c1303121fff8197c4ebc66b61f0616.diff

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCleanup.cpp:1341 + llvm::FunctionCallee SehCppScope = + CGM.CreateRuntimeFunction(FTy, "llvm.seh.scope.begin"); + EmitSehScope(*this, SehCppScope); We generally prefer to get intrinsic functio

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added a comment. How does this new rule work if we find overlapping but non-equal sets of declarations in different subobjects? I'm sure you can get that with `using` declarations. Comment at: clang/include/clang/AST/CXXInheritance.h:77 - CXXBasePath() = default;

[clang] 6f69f2e - Consider ASan messages interesting for creduce

Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: 6f69f2ed61ae805df496fc86ef22e7685573d556 URL: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556 DIFF: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556.diff

[clang] e678656 - Add bounds checking assertions to APValue, NFC

Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: e678656625a3e2b6a5f2849f4a6f7612ceeaed07 URL: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07 DIFF: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07.diff

  1   2   >