aaron.ballman added a comment. In D94624#2506906 <https://reviews.llvm.org/D94624#2506906>, @tomrittervg wrote:
> In D94624#2506831 <https://reviews.llvm.org/D94624#2506831>, @aaron.ballman > wrote: > >> In D94624#2501894 <https://reviews.llvm.org/D94624#2501894>, @tomrittervg >> wrote: >> >>> I started trying to work on a patch, but I'm still unpacking from a move >>> and don't have all my machines set up - trying to enable and build tests >>> filled up my hard drive (even after I removed the easy-to-remove stuff), so >>> I don't think I'm going to be able to create a test for this in the >>> short-term. >> >> Okay, I think this LGTM even without the test coverage. Thank you for the >> patch, do you need someone to commit it on your behalf? > > Yes, please. I'm not certain why, but the patch is not applying to a fresh pull for me. F:\llvm-project>git apply "F:\Aaron Ballman\Desktop\D94624.diff" error: patch failed: clang-tools-extra/clang-query/tool/ClangQuery.cpp:109 error: clang-tools-extra/clang-query/tool/ClangQuery.cpp: patch does not apply As usual, git's not being particularly helpful in stating what went wrong. Perhaps rebasing your patch on ToT and re-uploading it will cause the issue to go away? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
