aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor nits.
================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:1081
+ if (NodeKinds.empty()) {
+ // Set error
+ return {};
----------------
Is this a TODO comment?
================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:1095-1098
+ void getArgKinds(ASTNodeKind ThisKind, unsigned ArgNo,
+ std::vector<ArgKind> &ArgKinds) const override {
+ return;
+ }
----------------
================
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:1099-1100
+ }
+ bool isConvertibleTo(ASTNodeKind Kind, unsigned *Specificity = nullptr,
+ ASTNodeKind *LeastDerivedKind = nullptr) const override
{
+ return false;
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94880/new/
https://reviews.llvm.org/D94880
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
