[clang] 2b1e25b - [AArch64] Adding ACLE intrinsics for the LS64 extension

Author: Lucas Prates Date: 2021-01-14T09:43:58Z New Revision: 2b1e25befefc20f012aa49011f46e11e8530ee21 URL: https://github.com/llvm/llvm-project/commit/2b1e25befefc20f012aa49011f46e11e8530ee21 DIFF: https://github.com/llvm/llvm-project/commit/2b1e25befefc20f012aa49011f46e11e8530ee21.diff LOG:

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b1e25befefc: [AArch64] Adding ACLE intrinsics for the LS64 extension (authored by pratlucas). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:819 +Expanded.IndentCaseLabels = true; +Expanded.IndentCaseBlocks = false; break; I guess its fine to define these defaults here but what if people turn them off in their

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. My assumption is that you want to stick with the minimum and maximum is that correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D92257 ___

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi created this revision. Budovi added reviewers: MyDeveloperDay, rsmith. Budovi added a project: clang-format. Budovi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds support for coding styles that make a separate indentation level

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2497535 , @MyDeveloperDay wrote: > My assumption is that you want to stick with the minimum and maximum is that > correct? Otherwise I have to make a breaking change, or not achieve at all what I want. So e

[PATCH] D94554: [clangd][WIP] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 316599. njames93 added a comment. Refactor RefCntString out of DraftStore class Remove MTime from Draft, other users of DraftStore don't need to see it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

RKSimon added a reviewer: hfinkel. RKSimon added a comment. LGTM but a PPC-guru needs to signoff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 17f8c45 - [clang] Use SourceLocations in unions [NFCI]

Author: Mikhail Maltsev Date: 2021-01-14T10:56:53Z New Revision: 17f8c458de631c0311828931a5bdf72b1a13c29d URL: https://github.com/llvm/llvm-project/commit/17f8c458de631c0311828931a5bdf72b1a13c29d DIFF: https://github.com/llvm/llvm-project/commit/17f8c458de631c0311828931a5bdf72b1a13c29d.diff LO

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17f8c458de63: [clang] Use SourceLocations in unions [NFCI] (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94237: [clang] Use SourceLocations in unions [NFCI]

miyuki added a comment. > This revision was landed with ongoing or failed builds. The only failures were clang-format warnings, they looked bogus to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94237/new/ https://reviews.llvm.org/D94237

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

steakhal added a comment. It seems quite a challenge to hook the `Preprocessor` for all possible configurations for every `CompilerInvocation`. The underlying machinery is somewhat complex and spaghetti to me. Here is what I suggest: For now, this expansion is better than the previous was. Macro

[PATCH] D93942: [OpenCL] Improve online documentation.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 ___ cfe-commits mailing list cfe-co

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

HazardyKnusperkeks added a comment. I would add a test where you have a member before the first access modifier. Also this is not exactly what they wanted in the bug, as far as I can see members of structs or classes with no access modifier at all should only be indented once. Repository: rG

[PATCH] D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists

xazax.hun added a comment. In D93224#2497632 , @steakhal wrote: > Do you think it's acceptable? > @xazax.hun @NoQ It is fine by me. I believe, currently is Ericsson the biggest contributor and user of the CTU functionality. So in case they are onboard wi

[clang-tools-extra] 2e25be0 - [clangd] Add main file macros into the main-file index.

Author: Aleksandr Platonov Date: 2021-01-14T15:10:17+03:00 New Revision: 2e25be0b6134e9544f7cee7bb7b31a921ca37cc0 URL: https://github.com/llvm/llvm-project/commit/2e25be0b6134e9544f7cee7bb7b31a921ca37cc0 DIFF: https://github.com/llvm/llvm-project/commit/2e25be0b6134e9544f7cee7bb7b31a921ca37cc0.

[PATCH] D94477: [clangd] Add main file macros into the main-file index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e25be0b6134: [clangd] Add main file macros into the main-file index. (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94477/new/ https:

[clang] 3bccd87 - [clang][cli] NFC: Remove SSPBufferSize assignment

Author: Jan Svoboda Date: 2021-01-14T13:21:44+01:00 New Revision: 3bccd87a588b3c320b669686c8f006b92ff72182 URL: https://github.com/llvm/llvm-project/commit/3bccd87a588b3c320b669686c8f006b92ff72182 DIFF: https://github.com/llvm/llvm-project/commit/3bccd87a588b3c320b669686c8f006b92ff72182.diff L

[clang] fa2fe96 - [clang][cli] Port more CodeGenOptions to marshalling infrastructure

Author: Jan Svoboda Date: 2021-01-14T13:21:44+01:00 New Revision: fa2fe9608c1c1b402296960b1edc157230c30062 URL: https://github.com/llvm/llvm-project/commit/fa2fe9608c1c1b402296960b1edc157230c30062 DIFF: https://github.com/llvm/llvm-project/commit/fa2fe9608c1c1b402296960b1edc157230c30062.diff L

[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa2fe9608c1c: [clang][cli] Port more CodeGenOptions to marshalling infrastructure (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D94488?vs=316045&id=316619#toc Repository

[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

jansvoboda11 added a comment. Thanks for taking a look! Committed with more detailed message. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1146 - Opts.SSPBufferSize = - getLastArgIntValue(Args, OPT_stack_protector_buffer_size, 8, Diags); - dexons

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

aganea marked 8 inline comments as done. aganea added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:212 + /// Output filename used in the COFF debug information. + std::string COFFOutputFilename; + rnk wrote: > Let's bikeshed the name

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added a comment. In D92715#2495897 , @HsiangKai wrote: > @liaolucy RISC-V vector types are sizeless types. Sizeless is kind of > characteristic for builtin types. If we use attribute to declare RISC-V > vector types, the frontend does not know a

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

rnk added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:212 + /// Output filename used in the COFF debug information. + std::string COFFOutputFilename; + aganea wrote: > rnk wrote: > > Let's bikeshed the name a bit. This thing is the `

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316556. HsiangKai added a comment. Recover comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/cla

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai updated this revision to Diff 316553. HsiangKai added a comment. Refine debug info for RVV types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h cl

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. Thanks for reporting that, @rupprecht. I'll look into the issue in a couple of days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 __

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94601/new/ https://reviews.llvm.org/D94601 ___

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

njames93 accepted this revision. njames93 added a comment. Seems reasonable, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94601/new/ https://reviews.llvm.org/D94601 ___ cfe-commits mailing list cf

[PATCH] D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https:

[PATCH] D94675: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94675 Files: clang/lib

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

njames93 added a reviewer: aaron.ballman. njames93 added a comment. Is this just flagging all these functions, if so I don't think there's much value in here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 _

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

curdeius accepted this revision. curdeius added a comment. One last nit, otherwise LGTM. Comment at: clang/unittests/Format/FormatTest.cpp:8891 +TEST_F(FormatTest, FormatsAccessModifiers) { + verifyFormat("struct foo {\n" + "private:\n" For the e

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. I think it would be useful to run a functional test with a toolchain that has these library functions. That shouldn't gate this change though. CHANGES SINCE LAST ACTION https://re

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this! I think this change should have some test coverage in `clang-tools-extra/test/clang-query` where a test file that emits some output is run with and without the `--use-color` option enable

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94679 Files: clang/lib

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon added a comment. njames93, the purpose is to flag it indeed. This approach was found valueable in Yandex.Taxi, as it is very easy to forget that you're in a coroutine and may not use blocking API. The bug does affect performance (e.g. all coroutine threads wait for fs), it cannot be foun

[PATCH] D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94680 Files: clang/lib

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov updated this revision to Diff 316627. azabaznov added a comment. Changes in the latest patch: 1. Removed XFAIL and OpenCL C 2.0 test running for r600 and NVPTX target 2. Fixed comments. 3. Core features are being set in `TargetInfo::adjust`. CHANGES SINCE LAST ACTION https://revie

[PATCH] D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94681 Files: clang/inc

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

azabaznov marked 14 inline comments as done. azabaznov added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1431 /// Set supported OpenCL extensions and optional core features. + virtual void setSupportedOpenCLOpts(const LangOptions &Opts) {} --

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added a comment. In D94661#2497744 , @HazardyKnusperkeks wrote: > I would add a test where you have a member before the first access modifier. The very first unit test has no modifiers, the third one has a member before a modifier in the nested c

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

steveire added a comment. Can we make using color the default too? We already use colors for Decls I think, so this just adds colors for other Node types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 __

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; aaron.ballman wrote: > Does it make sense to return `true`

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

aaron.ballman added a comment. In D94624#2497992 , @steveire wrote: > Can we make using color the default too? We already use colors for Decls I > think, so this just adds colors for other Node types. I thought we already did? At least, for me on Windows

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

steveire added a comment. I also don't think we need to add unit tests for this, just because we can. The tests would be more complex than the code and wouldn't add much value. https://softwareengineering.stackexchange.com/a/147342 There are lots of resources about this. Repository: rG LLVM

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

steveire added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + Doesn't this set the default to false? Repository: rG LLVM Gi

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + steveire wrote: > Doesn't this set the default to false? It

[clang-tools-extra] 176f5e9 - [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

Author: Mikhail Maltsev Date: 2021-01-14T13:50:16Z New Revision: 176f5e95e1afad75ff045a00f0fa9c781bd5f54a URL: https://github.com/llvm/llvm-project/commit/176f5e95e1afad75ff045a00f0fa9c781bd5f54a DIFF: https://github.com/llvm/llvm-project/commit/176f5e95e1afad75ff045a00f0fa9c781bd5f54a.diff LO

[PATCH] D94601: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG176f5e95e1af: [clang-tidy] Use DenseSet in UpgradeDurationConversionsCheck… (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

steveire added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + aaron.ballman wrote: > steveire wrote: > > Doesn't this set the d

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + steveire wrote: > aaron.ballman wrote: > > steveire wrote: > >

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

ntesic added a comment. In D78105#2487169 , @nickdesaulniers wrote: > Compiler crash reported in: https://bugs.llvm.org/show_bug.cgi?id=48695 @nickdesaulniers Thanks for pointing this out! Fix patch proposal at D94685

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

steveire added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + tomrittervg wrote: > steveire wrote: > > aaron.ballman wrote: > >

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 updated this revision to Diff 316643. jansvoboda11 added a comment. Stop setting the default for LaxVectorConversions in CompilerInvocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94682/new/ https://reviews.llvm.org/D94682 Files

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + steveire wrote: > tomrittervg wrote: > > steveire wrote: > > >

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

steveire added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + tomrittervg wrote: > steveire wrote: > > tomrittervg wrote: > > >

[PATCH] D93453: [flang][driver] Add support for `-I`

sameeranjoshi added inline comments. Comment at: flang/test/Flang-Driver/include-header.f90:38 +!- +! EXPECTED OUTPUT FOR /Inputs/ FOLDER SPECIFIED FIRST +!- N

[clang] adb77a7 - [OpenCL] Improve online documentation.

Author: Anastasia Stulova Date: 2021-01-14T14:56:10Z New Revision: adb77a7456920a46908c7e20b2d3008789274975 URL: https://github.com/llvm/llvm-project/commit/adb77a7456920a46908c7e20b2d3008789274975 DIFF: https://github.com/llvm/llvm-project/commit/adb77a7456920a46908c7e20b2d3008789274975.diff

[PATCH] D93942: [OpenCL] Improve online documentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGadb77a745692: [OpenCL] Improve online documentation. (authored by Anastasia). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D93942?vs=315447&id=316648#toc Repository:

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-query/tool/ClangQuery.cpp:58 +standard output supports colors.)"), + cl::init(false), cl::cat(ClangQueryCategory)); + tomrittervg wrote: > steveire wrote: > > tomrittervg wrote:

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; steveire wrote: > aaron.ballman wrote: > > Does it mak

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query

tomrittervg updated this revision to Diff 316652. tomrittervg added a comment. Actually, I think I need to be smarter than changing the default. We want to let clang auto-detect the tty and behave that way by default if the option isn't specified. Otherwise you'd get ASNI color codes when you pi

[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

yaxunl added a comment. LGTM about r600 changes. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92277/new/ https://reviews.llvm.org/D92277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D82862: [ThinLTO] Always parse module level inline asm with At&t dialect

uweigand added a comment. Herald added a subscriber: pengfei. Hi @hans , we're having some issues with using the AssemblerDialect mechanism to support both the GNU assembler and the IBM HLASM assembler in the SystemZ back-end. See also the discussion started here: https://lists.llvm.org/pip

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman added a comment. In D94624#2498201 , @tomrittervg wrote: > Actually, I think I need to be smarter than changing the default. We want to > let clang auto-detect the tty and behave that way by default if the option > isn't specified. Otherwis

[PATCH] D94624: [PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

tomrittervg added a comment. In D94624#2498244 , @aaron.ballman wrote: > In D94624#2498201 , @tomrittervg > wrote: > >> Actually, I think I need to be smarter than changing the default. We want to >> let clang au

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst:6 + +Search for filesystem accesses that might block current system thread. +Asynchronous code may deal with it in numerous ways, the most widespread --

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; aaron.ballman wrote: > steveire wrote: > > aaron.ballman wr

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 316660. thezbyg added a comment. Improved default style tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 Files: clang/docs/ClangFormatStyleOptions.rst clang/i

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon updated this revision to Diff 316664. segoon edited the summary of this revision. segoon added a comment. - fix the first document line - add default values CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94622/new/ https://reviews.llvm.org/D94622 Files: clang-tools-extra/clang-

[PATCH] D94621: [clang-tidy] add concurrency-async-fs

segoon updated this revision to Diff 316667. segoon added a comment. - use back-ticks - fix the first document line - add default values CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 Files: clang-tools-extra/clang-tidy/concurrency/AsyncFsChe

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; steveire wrote: > aaron.ballman wrote: > > steveire wr

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius added a comment. That looks like a strange style option to me. Is there any bigger codebase formatting the code this way? Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class`

[PATCH] D94614: [FPEnv][X86] Platform builtins edition: clang should get from the AST the metadata for constrained FP builtins

kpn added a comment. This doesn't add metadata to llvm intrinsics that are not constrained. The metadata is added by the IRBuilder when the IRBuilder is used to add constrained intrinsics. When adding non-constrained intrinsics that have a direct mapping to constrained intrinsics, and constrain

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

steveire abandoned this revision. steveire added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; aaron.ballman wrote: > st

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316669. usaxena95 marked 13 inline comments as done. usaxena95 added a comment. Herald added a subscriber: mgorny. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:841 +void ASTWorker::updateASTSignals(ParsedAST &AST) { + ASTSignals Signals; sammccall wrote: > This implementation doesn't belong in TUScheduler, which is all about > mana

[clang-tools-extra] 17fb21f - [clangd] Remove another option that was effectively always true. NFC

Author: Sam McCall Date: 2021-01-14T17:19:47+01:00 New Revision: 17fb21f875f4aaf6ad2cf9499cb75d76588167f2 URL: https://github.com/llvm/llvm-project/commit/17fb21f875f4aaf6ad2cf9499cb75d76588167f2 DIFF: https://github.com/llvm/llvm-project/commit/17fb21f875f4aaf6ad2cf9499cb75d76588167f2.diff LO

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316670. usaxena95 added a comment. Removed unused headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tools-extra/clangd/ASTSignals.cpp clang-to

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

sammccall accepted this revision. sammccall added a comment. Thanks! Comment at: clang-tools-extra/clangd/ASTSignals.cpp:9 + ASTSignals Signals; + llvm::DenseMap> NSDToSymbols; + const SourceManager &SM = AST.getSourceManager(); this requires storing all the

[PATCH] D20689: [clang-tidy] Add 'readability-suspicious-call-argument' check

aaron.ballman added a comment. In D20689#2457808 , @whisperity wrote: > Right, let's bump. Thank you for all of the detailed information on the performance of the check! I worked on a similar check in a recent past life and my intuition is that over a l

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94655/new/ https://reviews.llvm.org/D94655 ___

[PATCH] D94126: [ASTMatchers] Make it possible to use empty variadic matchers

aaron.ballman added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402 ArrayRef InnerMatchers) { + if (InnerMatchers.empty()) +return true; steveire wrote: > aaron.ballman wrote: > > steveire wr

[PATCH] D94674: [clang][cli] NFC: Decrease the scope of ParseLangArgs parameters

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94674/new/ https://reviews.llvm.org/D94674 __

[PATCH] D94675: [clang][cli] NFC: Decrease the scope of ParseCodeGenArgs parameters

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94675/new/ https://reviews.llvm.org/D94675 __

[PATCH] D94676: [clang][cli] Specify KeyPath prefixes via TableGen classes

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94676/new/ https://reviews.llvm.org/D94676 __

[PATCH] D94678: [clang][cli] Parse & generate options necessary for LangOptions defaults manually

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM with the comment. Comment at: clang/include/clang/Driver/Options.td:5210-5213 def finclude_default_header : Flag<["-"], "finclude-default-header">, - HelpText<"I

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

dblaikie added a comment. Is there any way to condition this on the type of the output, rather than the input? (or, more specifically, on whether machine code is being generated) Or maybe we could always pass the split-dwarf-file down through LLVM and not need to conditionalize it at all? It'd

[PATCH] D94679: [clang][cli] NFC: Add PIE parsing for precompiled input and IR

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94679/new/ https://reviews.llvm.org/D94679 __

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1831 + MarshallingInfoString, +!strconcat(open_cl.KeyPath, " ? LangOptions::LaxVectorConversionKind::None" +" : Lan

[PATCH] D94680: [clang][cli] NFC: Parse some LangOpts after the defaults are set

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94680/new/ https://reviews.llvm.org/D94680 __

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. A better sampling strategy was used to gener

[PATCH] D94681: [clang][cli] NFC: Promote ParseLangArgs and ParseCodeGenArgs to members

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94681/new/ https://reviews.llvm.org/D94681 __

[PATCH] D94655: [Driver] -gsplit-dwarf: Produce .dwo regardless of -gN for IR input

MaskRay added a comment. In D94655#2498504 , @dblaikie wrote: > Is there any way to condition this on the type of the output, rather than the > input? (or, more specifically, on whether machine code is being generated) > > Or maybe we could always pass th

[PATCH] D94682: [clang][cli] Parse Lang and CodeGen options separately

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94682/new/ https://reviews.llvm.org/D94682 __

[PATCH] D93922: Mangle `__alignof__` differently than `alignof`.

jyknight added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:4009 +// mangling. Previously, it used a special-cased nonstandard extension. +if (Context.getASTContext().getLangOpts().getClangABICompat() >= +LangOptions::ClangABI::Ver11) { ---

[PATCH] D94699: [clangd] Set correct CWD when using compile_flags.txt

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This fixes a bug where clangd would attempt to set CWD to the compile_flags

  1   2   >