tomrittervg added a comment. In D94624#2498244 <https://reviews.llvm.org/D94624#2498244>, @aaron.ballman wrote:
> In D94624#2498201 <https://reviews.llvm.org/D94624#2498201>, @tomrittervg > wrote: > >> Actually, I think I need to be smarter than changing the default. We want to >> let clang auto-detect the tty and behave that way by default if the option >> isn't specified. Otherwise you'd get ASNI color codes when you pipe to a >> file. > > +1 to this, but also, you need to thread the option through to the > diagnostics engine as well. Let me fiddle with this, I think I have an idea of how to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94624/new/ https://reviews.llvm.org/D94624 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
