Eugene.Zelenko added inline comments.
================ Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst:6 + +Search for filesystem accesses that might block current system thread. +Asynchronous code may deal with it in numerous ways, the most widespread ---------------- Please make first statement same as in Release Notes. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst:10 + +* use asynchronous API like aio or io_uring +* delegate all filesystem access to a thread pool ---------------- Please highlight aio and io_uring with single back-ticks. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst:15 +a non-issue, e.g. it is known that all filesystem code doesn't block +system threads as it resides in memory (e.g. tmpfs), or blocking functions +are used in the startup code only, or asynchronous API/thread pool is not ---------------- Please highlight tmpfs with single back-ticks. ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/concurrency-async-fs.rst:32 + + Specifies additional functions to search for, separated with semicolon. + ---------------- Please add information about default value. Same below. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
