[clang] 4b6f294 - [clang][cli] Port Preprocessor and PreprocessorOutput option flags to new option parsing system

Author: Jan Svoboda Date: 2020-12-14T09:19:57+01:00 New Revision: 4b6f29413c59b1a016f127bc3c3e1c15c6bea2a9 URL: https://github.com/llvm/llvm-project/commit/4b6f29413c59b1a016f127bc3c3e1c15c6bea2a9 DIFF: https://github.com/llvm/llvm-project/commit/4b6f29413c59b1a016f127bc3c3e1c15c6bea2a9.diff L

[PATCH] D84018: [clang][cli] Port Preprocessor and PreprocessorOutput option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b6f29413c59: [clang][cli] Port Preprocessor and PreprocessorOutput option flags to new… (authored by jansvoboda11). Changed prior to commit: http

[PATCH] D84185: Better defaults for MarshallingInfoString

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84185/new/ https://reviews.llvm.org/D

[clang] e2fc85c - [clang][cli] Better defaults for MarshallingInfoString

Author: Jan Svoboda Date: 2020-12-14T09:59:56+01:00 New Revision: e2fc85c69b3f7aad89b5b59eca537bec96a24682 URL: https://github.com/llvm/llvm-project/commit/e2fc85c69b3f7aad89b5b59eca537bec96a24682 DIFF: https://github.com/llvm/llvm-project/commit/e2fc85c69b3f7aad89b5b59eca537bec96a24682.diff L

[PATCH] D84185: [clang][cli] Better defaults for MarshallingInfoString

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2fc85c69b3f: [clang][cli] Better defaults for MarshallingInfoString (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org

[PATCH] D84188: [clang][cli] Port FileSystem options to new option parsing system

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Changes involved moving `working_directory` and `working_directory_EQ` back to their original lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 16aa00b - [clang][cli] Port FileSystem options to new option parsing system

Author: Jan Svoboda Date: 2020-12-14T10:17:23+01:00 New Revision: 16aa00b6228533890cc108bc32871f36eb116e0e URL: https://github.com/llvm/llvm-project/commit/16aa00b6228533890cc108bc32871f36eb116e0e DIFF: https://github.com/llvm/llvm-project/commit/16aa00b6228533890cc108bc32871f36eb116e0e.diff L

[PATCH] D84188: [clang][cli] Port FileSystem options to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16aa00b62285: [clang][cli] Port FileSystem options to new option parsing system (authored by jansvoboda11). Changed prior to commit: https://revie

[PATCH] D84186: Convert Analyzer option string based options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Herald added a subscriber: steakhal. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 updated this revision to Diff 311527. jansvoboda11 added a comment. Rebase, remove `InlineMaxStackDepth` initialization from `AnalyzerOptions.h` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84186/new/ https://reviews.llvm.org/D84186

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson updated this revision to Diff 311529. tmatheson added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93101/new/ https://reviews.llvm.org/D93101 Files: clang/lib/AST/ExprConstant.cpp clang/test/CodeGenCXX/bitfield-la

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru added a comment. @serge-sans-paille ok to push this? :) merci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing list cfe-com

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

lebedev.ri added a comment. Out of curiocity, are all checkpatch diagnostics (and something else)? are planned to be ported into being clang-tidy checks? How many will checks will that be? I'll be slightly worried if `linuxkernel` module ends up having more checks than all other modules combined..

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

tmatheson updated this revision to Diff 311531. tmatheson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93102/new/ https://reviews.llvm.org/D93102 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/test/Sema/attr-section.c

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

davezarzycki added a comment. This change is causing second stage build failures on Fedora 33 (x86-64). I'll probably revert this soon, but in the mean time, here is a snippet of the build output: FAILED: lib/ExecutionEngine/JITLink/CMakeFiles/LLVMJITLink.dir/JITLinkGeneric.cpp.o /p/tllvm/

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

jansvoboda11 added a comment. Ready for a review. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:287 +static void +denormalizeString(SmallVectorImpl &Args, const char *Spelling, + CompilerInvocation::StringAllocator SA, unsigned, T &&Value) { --

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 added a comment. Thanks for catching these! Comment at: clang/include/clang/Driver/Options.td:1292-1303 def fdwarf_exceptions : Flag<["-"], "fdwarf-exceptions">, Group, - Flags<[CC1Option]>, HelpText<"Use DWARF style exceptions">; + Flags<[CC1Option]>, HelpText<

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311542. jansvoboda11 added a comment. Revert exceptions flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h cl

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

danielmarjamaki abandoned this revision. danielmarjamaki added a comment. No reviews => I will not contribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92634/new/ https://reviews.llvm.org/D92634 ___

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311545. jansvoboda11 added a comment. Revert ObjCAutoRefCount option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

Charusso added a reviewer: vsavchenko. Charusso added a comment. Hey! We are somewhat slow in reviews, please understand that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92634/new/ https://reviews.llvm.org/D92634 ___

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei added a comment. Yes, it is using maxpd/minpd here. Sorry for missing the nan cases. In fact, I doubt about the behavior when using fast math with target intrinsics. In my opinion, target intrinsics are always associated with given instructions (reduce* are exceptions). So the behavior o

[PATCH] D93206: [AArch64][NEON] Remove undocumented vceqz{,q}_p16, vml{a,s}q_n_f64 intrinsics

joechrisellis created this revision. joechrisellis added reviewers: bsmith, pbarrio, AshokBhat. Herald added subscribers: danielkiss, kristof.beyls. joechrisellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, Clang su

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

pengfei added a comment. What's the difference with the existing code? It looks to me that you just brought the warning out of loop, right? Comment at: llvm/utils/update_analyze_test_checks.py:128 raw_tool_output, prefixes, func_dict, func_order, args.verbose, Fals

[clang] 22ccdb7 - Revert "Consider reference, pointer, and pointer-to-member TemplateArguments to be different if they have different types."

Author: Raphael Isemann Date: 2020-12-14T14:03:38+01:00 New Revision: 22ccdb787024e954318e35fcf904fd4fa36f5679 URL: https://github.com/llvm/llvm-project/commit/22ccdb787024e954318e35fcf904fd4fa36f5679 DIFF: https://github.com/llvm/llvm-project/commit/22ccdb787024e954318e35fcf904fd4fa36f5679.dif

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

teemperor added a comment. I believe rsmith is in GMT-8, so I assume this won't get a fix soon and I went ahead and reverted in 22ccdb787024e954318e35fcf904fd4fa36f5679 Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

davezarzycki added a comment. Thanks. I just verified that reverting this change fixes the second stage regression and was about to commit the revert. @rsmith – If you need help testing a fix, please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 311557. llitchev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Merged in master. Removed unnecessary (now) code from D92189 . Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D93079: [OpenMP] Introduce an assumption to ignore possible external callers

JonChesterfield added a comment. Is this for cases where we are compiling a subset of the target code, i.e. without link time optimisation? It's interesting that we might want a static function on the gpu and an external one on the cpu. The user could presumably make it static and provide a di

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille added a comment. @sylvestre.ledru I: double checked and there's nothing in the original advisory against Darwin, but nothing that clearly states it's protected either (unlike Windows-based system). And there's also nothing specific to Darwin in the stack clash protection impl

[PATCH] D93023: Replace deprecated %T in 2 tests.

abidh added a comment. It seems that testcase I added has brought to surface a hidden issue. If you look at the end of Generic_GCC::GCCInstallationDetector::AddDefaultGCCPrefixes, it adds sysroot/usr to the Prefixes. If the sysroot is empty, this will end up using the toolchain that you installed

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

CarolineConcatto added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:87 + defaultKinds, features, ci.allCookedSources()}; + semanticsContext.set_moduleDirectory("."s); + Fortran::semantics::Semantics semantics{ Just a quick question:

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko updated this revision to Diff 311565. vsavchenko marked 4 inline comments as done. vsavchenko added a comment. Add documentation for new attribute and fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://re

[PATCH] D93214: [clang][cli] Create accessors for exception models in LangOptions

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This abstracts away the members that are being replaced in a follow-up patch. Repository:

[PATCH] D93215: [clang][cli] Squash exception model in LangOptions into one member

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a subscriber: dschuff. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This squashes multiple members in LangOptions into one.

[PATCH] D93216: [clang][cli] Squash multiple -fxxx-exceptions flags into single -exception-model=xxx option

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added subscribers: dang, mstorsjo, sbc100, dschuff, emaste. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This patch enables marsha

[PATCH] D93216: [clang][cli] Squash multiple -fxxx-exceptions flags into single -exception-model=xxx option

jansvoboda11 updated this revision to Diff 311585. jansvoboda11 added a comment. Remove accidental comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93216/new/ https://reviews.llvm.org/D93216 Files: clang/include/clang/Basic/DiagnosticFronte

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

mibintc resigned from this revision. mibintc added a comment. I don't have expertise in this area. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits

[PATCH] D93216: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option

jansvoboda11 updated this revision to Diff 311589. jansvoboda11 added a comment. Add possible values to HelpText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93216/new/ https://reviews.llvm.org/D93216 Files: clang/include/clang/Basic/Diagnostic

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. This didn't really address the comments, what is the point of the maximum? what if the maximum is > the ColumnLimit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D92257

[PATCH] D91245: [clang-format] Recognize c++ coroutine keywords as unary operator to avoid misleading pointer alignment

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7766 + verifyFormat("co_await *a;", PASLeftStyle); + verifyFormat("co_yield *a", PASLeftStyle); } maybe add, just to clarify it. verifyFormat("return *a", PASLeftStyle);

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin marked an inline comment as done. mtrofin added a comment. In D93078#2451747 , @pengfei wrote: > What's the difference with the existing code? It looks to me that you just > brought the warning out of loop, right? Oh true! we can just do the chec

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin updated this revision to Diff 311593. mtrofin marked 3 inline comments as done. mtrofin added a comment. fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 Files: clang/test/utils/update_cc_test_

[PATCH] D93078: [utils] Fix UpdateTestChecks case where 2 runs differ for last label

mtrofin added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93078/new/ https://reviews.llvm.org/D93078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93220 Fil

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

martong accepted this revision. martong added a comment. Thanks for the update. I checked it, still looks good to me. Some notes in parenthesis: > It looks like the problem is again due to delayed template parsing: the > templatized functions in the test both came out as nullptr. So, I added a

[PATCH] D93221: [ARM] Add clang command line support for -mharden-sls=

kristof.beyls created this revision. kristof.beyls added a reviewer: ostannard. Herald added a subscriber: danielkiss. kristof.beyls requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The command line syntax is identical to the -mharden-sls= c

[PATCH] D93222: [RFC] Introduce MacroExpansionContext to libAnalysis

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, xazax.hun, martong, balazske, Szelethus, ilya-biryukov, rsmith. Herald added subscribers: Charusso, mgrang, rnkovacs, mgorny. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D93223: [NFC] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, xazax.hun, martong, balazske, Szelethus. Herald added subscribers: Charusso, rnkovacs. steakhal requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pretty much the same

[PATCH] D93227: [clangd] Smarter hover on auto and decltype

qchateau created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Only show the keyword as the hover "Name". Show whether the type is de

[PATCH] D91806: [SVE] Change getTypeAllocationSizeInBits to return TypeSize

peterwaller-arm updated this revision to Diff 311612. peterwaller-arm added a comment. I've taken over the differential. Simplify things a bit more, remove an untested remnant created from before the patch split. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D91806: [InstCombine] Update valueCoversEntireFragment to use TypeSize

peterwaller-arm updated this revision to Diff 311614. peterwaller-arm retitled this revision from "[SVE] Change getTypeAllocationSizeInBits to return TypeSize" to "[InstCombine] Update valueCoversEntireFragment to use TypeSize". peterwaller-arm edited the summary of this revision. peterwaller-arm

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

JonChesterfield added reviewers: jdoerfert, hfinkel. JonChesterfield added a comment. Herald added a subscriber: dexonsmith. I concede that making the variables external, and trying to give them unique names, does work around static variables not working. I believe static variables are subjected

[PATCH] D92634: [Analyzer] Diagnose signed integer overflow

steakhal added a comment. This would be a serious change. Especially if we internally already depend on modulo arithmetic. For example, the `ArrayBoundV2` might exploit this fact - when it rearranges the inequality. I might be wrong on this though. Besides that checker, I can't mention any other

[clang] 640ad76 - [clang-scan-deps] Support clang-cl

Author: Sylvain Audi Date: 2020-12-14T12:06:05-05:00 New Revision: 640ad769110f76d3391667249478ece88c835529 URL: https://github.com/llvm/llvm-project/commit/640ad769110f76d3391667249478ece88c835529 DIFF: https://github.com/llvm/llvm-project/commit/640ad769110f76d3391667249478ece88c835529.diff

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rG640ad769110f: [clang-scan-deps] Support clang-cl (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D921

[PATCH] D92054: [Driver] Default Generic_GCC ppc/ppc64/ppc64le to -fasynchronous-unwind-tables

MaskRay added a comment. Gentle ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92054/new/ https://reviews.llvm.org/D92054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D91776: [ARM][AAarch64] Initial command-line support for v8.7-A

pratlucas updated this revision to Diff 311624. pratlucas added a comment. Rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91776/new/ https://reviews.llvm.org/D91776 Files: clang/lib/Basic/Targets/AArch64.cpp clang/lib/Basic/Targets/AA

[PATCH] D93231: [ARM] Adding v8.7-A command-line support for the ARM target

pratlucas created this revision. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This extends the command-line support for the 'armv8.7-

[PATCH] D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension

pratlucas created this revision. Herald added subscribers: danielkiss, jfb, hiraditya, kristof.beyls. pratlucas requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces the ARMv8.7-A LS64 extension's intrinsics for

[clang] 68f5396 - [ASTImporter] Fix import of a typedef that has an attribute

Author: Gabor Marton Date: 2020-12-14T18:27:05+01:00 New Revision: 68f53960e17d93c3a2727164dac4e54140bd98ba URL: https://github.com/llvm/llvm-project/commit/68f53960e17d93c3a2727164dac4e54140bd98ba DIFF: https://github.com/llvm/llvm-project/commit/68f53960e17d93c3a2727164dac4e54140bd98ba.diff

[PATCH] D92962: [ASTImporter] Fix import of a typedef that has an attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rG68f53960e17d: [ASTImporter] Fix import of a typedef that has an attribute (authored by martong). Repositor

[PATCH] D92962: [ASTImporter] Fix import of a typedef that has an attribute

martong added a comment. Shafik, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92962/new/ https://reviews.llvm.org/D92962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2452174 , @martong wrote: > Thanks for the update. I checked it, still looks good to me. > > Some notes in parenthesis: > >> It looks like the problem is again due to delayed template parsing: the >> templatized functio

[PATCH] D93216: [clang][cli] Squash multiple cc1 -fxxx-exceptions flags into single -exception-model=xxx option

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. I'll look at the prep commits in a moment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93216/new/ https://reviews.llvm.org/D9321

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

thakis added a comment. Looks like this breaks tests on mac: http://45.33.8.238/macm1/174/step_6.txt Ptal, and revert for now if it takes a while to fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM now. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:293 static T mergeForwardValue(T KeyPath, U Value) { - return Value; + return static_cast(Valu

[PATCH] D93214: [clang][cli] Create accessors for exception models in LangOptions

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM, just a whitespace request from `clang-format`. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:760-761 Builder.defineMacro("__SEH__"); - else if

[PATCH] D93215: [clang][cli] Squash exception model in LangOptions into one member

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93215/new/ https://reviews.llvm.org/D93215

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 311648. llitchev added a comment. Fixed a failing Windows test. The issue is that that the order of the operands for add operation has changed. I cant see how these changes could cause the issue, but it is a failing test that blocks push of this Diff. Rep

[clang] 5f53d28 - Revert "[clang-scan-deps] Support clang-cl"

Author: Sylvain Audi Date: 2020-12-14T13:32:38-05:00 New Revision: 5f53d28fa68142bbd9dfb2b33f955352b180d776 URL: https://github.com/llvm/llvm-project/commit/5f53d28fa68142bbd9dfb2b33f955352b180d776 DIFF: https://github.com/llvm/llvm-project/commit/5f53d28fa68142bbd9dfb2b33f955352b180d776.diff

[PATCH] D93181: [NFC][AMDGPU] Reformat AMD GPU targets in cuda.cpp

tra added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:75 SM(80), // Ampere -GFX(600), // tahiti -GFX(601), // pitcairn, verde -GFX(602), // oland, hainan -GFX(700), // kaveri -GFX(701), // hawaii -GFX(702), // 290,29

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:896 + if (S.CanPerformCopyInitialization(Entity, &AsRvalue)) +return true; +} else if (auto *FTD = dyn_cast(D)) { aaronpuchert wrote: > Quuxplusone wrote: > > aaronp

[PATCH] D91664: Add a less ambiguous macro for Android version.

danalbert closed this revision. danalbert added a comment. https://github.com/llvm/llvm-project/commit/0849047860a343d8bcf1f828a82d585e89079943 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91664/new/ https://reviews.llvm.org/D91664 __

[PATCH] D84186: [clang][cli] Convert Analyzer option string based options to new option parsing system

dexonsmith requested changes to this revision. dexonsmith added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:287 +static void +denormalizeString(SmallVectorImpl &Args, const char *Spelling, +

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

tra updated this revision to Diff 311657. tra added a comment. Use __device__ in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92893/new/ https://reviews.llvm.org/D92893 Files: clang/include/clang/Basic/Attr.td clang/test/SemaCU

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

jkorous added a comment. Thanks for working on this! Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2907 +// start with it. +llvm::SmallVector Stack{DynTypedNode::create(*BugStmt)}; + Since IIUC a node can have multiple parents - does that me

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 311662. ahatanak added a comment. Set the insert point before generating new instructions in `insertRetainOrClaimRVCalls`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92

[clang] 0936655 - [CUDA] Do not diagnose host/device variable access in dependent types.

Author: Artem Belevich Date: 2020-12-14T11:53:18-08:00 New Revision: 0936655bac78f6e9cb84dc3feb30c32012100839 URL: https://github.com/llvm/llvm-project/commit/0936655bac78f6e9cb84dc3feb30c32012100839 DIFF: https://github.com/llvm/llvm-project/commit/0936655bac78f6e9cb84dc3feb30c32012100839.diff

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0936655bac78: [CUDA] Do not diagnose host/device variable access in dependent types. (authored by tra). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added a reviewer: kadircet. dexonsmith added a comment. This revision now requires review to proceed. @kadircet, adding you explicitly as a blocking reviewer, since I suspect you've missed any emails generated from my previous pings. Please let me know whether you still have concerns.

[clang] 670686a - Add initial support for multilibs in Baremetal toolchain.

Author: Hafiz Abid Qadeer Date: 2020-12-14T20:49:45Z New Revision: 670686ad8ecc80158a6ff87fff55e0ffa6fdff5d URL: https://github.com/llvm/llvm-project/commit/670686ad8ecc80158a6ff87fff55e0ffa6fdff5d DIFF: https://github.com/llvm/llvm-project/commit/670686ad8ecc80158a6ff87fff55e0ffa6fdff5d.diff

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

This revision was automatically updated to reflect the committed changes. abidh marked 3 inline comments as done. Closed by commit rG670686ad8ecc: Add initial support for multilibs in Baremetal toolchain. (authored by abidh). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

spatel added a comment. If we're going by existing behavior/compatibility, gcc/icc use packed ops too: https://godbolt.org/z/9jEhaW ...so there's an implicit 'nnan nsz' in these intrinsics (and that should be documented in the header file (and file a bug for Intel's page at https://software.inte

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

bmahjour updated this revision to Diff 311678. bmahjour added a comment. fix formatting and use interleaveComma instead of interleave. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 Files: clang/lib/Stat

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks added a comment. In D92257#2452063 , @MyDeveloperDay wrote: > This didn't really address the comments, what is the point of the maximum? My goal is to remove all spaces between `//` and the content (with the exception of comment secti

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, klimek, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If ``false``

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

Meinersbur accepted this revision. Meinersbur added a comment. Thanks. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90159/new/ https://reviews.llvm.org/D90159 ___ cfe-commits mailing list cf

[clang] ef4da3c - clang: Add byval on x86_intrcc parameter 0

Author: Matt Arsenault Date: 2020-12-14T16:34:37-05:00 New Revision: ef4da3c2ba8a812a695361d786e3de8a8b2cd482 URL: https://github.com/llvm/llvm-project/commit/ef4da3c2ba8a812a695361d786e3de8a8b2cd482 DIFF: https://github.com/llvm/llvm-project/commit/ef4da3c2ba8a812a695361d786e3de8a8b2cd482.diff

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

arsenm closed this revision. arsenm added a comment. ef4da3c2ba8a812a695361d786e3de8a8b2cd482 +2e0e03c6a089da39039ec3f464f7cee5df86646b CHANGES SINCE LAST

[clang] fd4a107 - [DDG] Data Dependence Graph - DOT printer

Author: Bardia Mahjour Date: 2020-12-14T16:41:14-05:00 New Revision: fd4a10732c8bd646ccc621c0a9af512be252f33a URL: https://github.com/llvm/llvm-project/commit/fd4a10732c8bd646ccc621c0a9af512be252f33a DIFF: https://github.com/llvm/llvm-project/commit/fd4a10732c8bd646ccc621c0a9af512be252f33a.diff

[PATCH] D90159: [DDG] Data Dependence Graph - DOT printer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd4a10732c8b: [DDG] Data Dependence Graph - DOT printer (authored by bmahjour). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 3b3eb7f - Speculative fix for build bot failures

Author: Philip Reames Date: 2020-12-14T13:44:40-08:00 New Revision: 3b3eb7f07ff97feb64a1975587bb473f1f3efa6b URL: https://github.com/llvm/llvm-project/commit/3b3eb7f07ff97feb64a1975587bb473f1f3efa6b DIFF: https://github.com/llvm/llvm-project/commit/3b3eb7f07ff97feb64a1975587bb473f1f3efa6b.diff

[PATCH] D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel

llitchev updated this revision to Diff 311698. llitchev added a comment. Added separate tests for Windows for specific tests. On Windows the registers for the add operation are swapped. This test is completely unrelated to this change, but it fails. Repository: rG LLVM Github Monorepo CHANG

[clang] a29ecca - Revert "[DDG] Data Dependence Graph - DOT printer"

Author: Bardia Mahjour Date: 2020-12-14T16:54:20-05:00 New Revision: a29ecca7819a6ed4250d3689b12b1f664bb790d7 URL: https://github.com/llvm/llvm-project/commit/a29ecca7819a6ed4250d3689b12b1f664bb790d7 DIFF: https://github.com/llvm/llvm-project/commit/a29ecca7819a6ed4250d3689b12b1f664bb790d7.diff

[PATCH] D93244: Remove the ast_type_traits namespace.

alexfh created this revision. alexfh added reviewers: aaron.ballman, rnk. alexfh requested review of this revision. Herald added a project: clang. This is the final cleanup after https://reviews.llvm.org/D74499 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93244 Files: clan

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311706. tmroeder added a comment. Change the DeclMatcher.h test code to expose the ability to not assert on null Nodes from a match. This allows the tests for GenericSelectionExpr to handle the null case on Windows themselves without crashing, and to still

[PATCH] D93244: Remove the ast_type_traits namespace.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93244/new/ https://reviews.llvm.org/D93244 _

[PATCH] D93247: [Sema] Fix a miscompile by retaining array qualifiers when folding VLAs to constant arrays

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, rjmccall, arphaman. Herald added subscribers: ributzka, jkorous. erik.pilkington requested review of this revision. Fixes rdar://72243125. https://reviews.llvm.org/D93247 Files: clang/lib/Sema/SemaDecl.cpp clang

  1   2   >