JonChesterfield added a comment.

Is this for cases where we are compiling a subset of the target code, i.e. 
without link time optimisation?

It's interesting that we might want a static function on the gpu and an 
external one on the cpu. The user could presumably make it static and provide a 
different, host-only function which calls it as a workaround.

I'm nervous about this one because it looks like a property the compiler should 
already be able to derive (given LTO, anyway), and I don't see how we can 
diagnose when the user annotation is inaccurate, e.g. because of changes 
elsewhere in the codebase after it was added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93079/new/

https://reviews.llvm.org/D93079

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to