tmroeder added a comment. In D92600#2452174 <https://reviews.llvm.org/D92600#2452174>, @martong wrote:
> Thanks for the update. I checked it, still looks good to me. > > Some notes in parenthesis: > >> It looks like the problem is again due to delayed template parsing: the >> templatized functions in the test both came out as nullptr. So, I added a >> check for nullptr in the case that expects the two values to be different. >> The test only tries to compare them if at least one is not null. > > Ideally, we should have parameterized structural equivalency tests (similarly > to what we have in ASTImporterTest with INSTANTIATE_TEST_CASE_P). The > parameters could be the compiler options, i.e. in this case I think we would > be able to explicitly emit the delayed template parsing option. Anyway, let's > keep that as a future update if we bump into more similar cases. Thanks! Unfortunately, my fix didn't solve the whole problem on Windows, because I forgot to build with assertions when repro'ing the failure, so I fixed one problem but not the other. I'm now working on fixing the test under assertions as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
