[PATCH] D92827: [clang][cli] CompilerInvocationTest: split enum test into two

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5afff86d2616: [clang][cli] CompilerInvocationTest: split enum test into two (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D92828: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4894e423e7b4: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments (authored by jansvoboda11). Repository: rG LLVM Githu

[PATCH] D92829: [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03692bae1fc9: [clang][cli] CompilerInvocationTest: check arg parsing does not produce… (authored by jansvoboda11). Repository: rG LLVM Github Mono

[PATCH] D92830: [clang][cli] CompilerInvocationTest: join and add test cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG216d43053b4e: [clang][cli] CompilerInvocationTest: join and add test cases (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35621cc2e3b3: [clang][cli] CompilerInvocationTest: add tests for boolean options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D92915: [Driver] Add -f[no-]new-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay updated this revision to Diff 310438. MaskRay added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92915/new/ https://reviews.llvm.org/D92915 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolCha

[PATCH] D92917: [Driver] Pass -plugin-opt=no-new-pass-manager to the linker

MaskRay updated this revision to Diff 310439. MaskRay edited the summary of this revision. MaskRay added a comment. Improve Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92917/new/ https://reviews.llvm.org/D92917 Files: clang/lib/Driver/ToolChai

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko added a comment. @aaron.ballman Can you please take a look at the attribute side of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92039/new/ https://reviews.llvm.org/D92039 ___ cfe-commi

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

kiranchandramohan added a comment. A few comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:43-44 } else if (isa(JA) || isa(JA)) { -CmdArgs.push_back("-triple"); -CmdArgs.push_back(Args.MakeArgString(TripleStr)); if (JA.getType() == types::TY_Nothing) {

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

hokein updated this revision to Diff 310450. hokein added a comment. address comments - add a allowRecovery flag to avoid bad side-effect on other callsides; - recover more cases; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92298/new/ https://re

[PATCH] D92494: [clangd] Bundle code completion items when the include paths differ, but resolve to the same file.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:187 + if (auto Header = headerToInsertIfAllowed(Opts)) +if (auto HeaderFile = toHeaderFile(*Header, FileName)) + if (auto Spelled = (sorry for the late dri

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

hokein added a comment. In D92298#2439325 , @sammccall wrote: > The thrust of this change is great, I'm just having trouble being sure there > are no bad side-effects. > > --- > > I almost left a comment here saying we might want to recover here... before

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman, gribozavr2. Herald added a subscriber: xazax.hun. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently errors detected when parsing the YAML for

[clang] 13e4e5e - Revert "[clang][cli] CompilerInvocationTest: add tests for boolean options"

Author: Jan Svoboda Date: 2020-12-09T10:35:07+01:00 New Revision: 13e4e5ed59c92d81ee5fee55f20ecf1842ec8cf3 URL: https://github.com/llvm/llvm-project/commit/13e4e5ed59c92d81ee5fee55f20ecf1842ec8cf3 DIFF: https://github.com/llvm/llvm-project/commit/13e4e5ed59c92d81ee5fee55f20ecf1842ec8cf3.diff L

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:79 + // Absolute canonical path that we're the cache for. (Not case-folded). + std::str

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 added a comment. This patch was reverted as it broke a build: http://lab.llvm.org:8011/#/builders/14/builds/2986 The assertions will need to take into account the actual value of `LLVM_ENABLE_NEW_PASS_MANAGER`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, krasimir, JakeMerdichAMD. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. clang-format see the `disable:` in __pragma(waring(disable:)) as ObjectiveC method call

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

Hiralo added a comment. We are dependent on this patch to exclude headers in regex while running clang-tidy. Can we have this patch merged with upcoming GA versions? or Can someone summarize what is pending in this review or what could be good alternative in v11 clang-tidy? Thank you in advance.

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

RKSimon added inline comments. Comment at: clang/lib/Basic/Targets/M68k.h:14 +#ifndef M680X0_H_LTNCIPAD +#define M680X0_H_LTNCIPAD + @myhsu This should probably be LLVM_CLANG_LIB_BASIC_TARGETS_M68K_H CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88393/

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon added a comment. This patch is very busy with 3 different aims - maybe split into 3 patches? The constifications, the include cleanup and the getModRefInfo tweak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

njames93 updated this revision to Diff 310476. njames93 added a comment. Use MemoryBufferRef instead of StringRef so the Diagnostic can have a meaningful filename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92920/new/ https://reviews.llvm.org/D

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 310481. vsavchenko added a comment. Replace let with const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h c

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a sub

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko added a comment. Here is the HTML file for the test.F14639004: report-399795.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ https://reviews.llvm.org/D92928 ___

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

RKSimon added a comment. Please can you pre-commit math-builtins-adjust.c with current IR checks and then rebase to show the diffs? Maybe rename it math-builtins-long.c as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://revi

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124 /// Note that this class also implements caching. -class CrossTranslationUnitContext { +class CrossTranslationUnitContext : public CrossTUAnalysisHelper { public:

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310488. melver added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files:

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

fhahn created this revision. fhahn added reviewers: SjoerdMeijer, dmgreen, t.p.northover. Herald added a subscriber: kristof.beyls. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds vcmla and the rotated variants as defi

[PATCH] D92930: [Clang] Add vcmla and rotated variants for Arm ACLE.

t.p.northover added a comment. Looks fine to me except for one weird quirk that I don't think should be there. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5237 NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1ArgType), + NEONMAP1(vcaddq_rot90_v, arm_neon_vcadd_rot90, Add1

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

steakhal added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124 /// Note that this class also implements caching. -class CrossTranslationUnitContext { +class CrossTranslationUnitContext : public CrossTUAnalysisHelper { public:

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310492. melver added a comment. Simplify using stripPointerCastsAndAliases() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-ali

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver added a comment. In D92846#2440118 , @dvyukov wrote: > Have you checked if there is already a function that does this? Frequently > there is :) > Some functions that look similar based on names: > stripPointerCasts > stripPointerCastsAndOffsets > s

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310494. melver added a comment. Style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-alias.cpp llvm/lib/Transforms/Instrument

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 310495. melver added a comment. Revert unnecessary reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-alias.cpp llvm/lib

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. The code looks reasonable to me. I see it only affects kernel, so assuming you booted kernel, we should be fine. I can rubber-stamp it, but if you want more meaningful review, please wait for

[PATCH] D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:2037 +if (Line->First->TokenText.startswith("#") || +Line->First->TokenText == "__pragma") { + continue; Maybe you should also handle MS-specific `_Pragma`? https

[PATCH] D92935: Introduce support for PowerPC devices with an Embedded Floating-point APU version 2 (efpu2)

kiausch created this revision. kiausch added reviewers: nemanjai, jhibbits. Herald added subscribers: dang, steven.zhang, shchenz, kbarton, hiraditya. kiausch requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. PowerPC cores l

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Some case errors on the allowRecovery variable name throughout. Comment at: clang/include/clang/Sema/Sema.h:3730 + SourceLocation

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

sammccall added a comment. (It seems like there are probably other callsites to these functions that could be updated to pass AllowRecovery=true. If so, those can easily be separate patches of course) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:114 assert(!ProjectRoot.empty()); +ChannelStatusWatcher = std::thread([&Channel]() { + grpc_connectivity_state Status = kbobyrev wrote: > sammccall wrote:

[PATCH] D92198: [clangd] Log remote index connectivity status

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:91 SPAN_ATTACH(Tracer, "Failed to parse", FailedToParse); +vlog("Remote index ({0}): {1} -> {2}", ServerAddress, toString(OldStatus), + toString(Channel->GetState(/*try_

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. In D89909#2439837 , @Anastasia wrote: > In D89909#2423750 , @bader wrote: > >>> It was mentioned that the changes in the type system with address spaces is >>> undesirable for SYCL because yo

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov updated this revision to Diff 310506. dfukalov added a comment. Splitting change as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 Files: llvm/include/llvm/Analysis/AliasAnalysis.h

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov updated this revision to Diff 310509. dfukalov edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/examples/Bye/Bye.

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong updated this revision to Diff 310510. martong added a comment. - Remove `if (!DC || !LexicalDC)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92209/new/ https://reviews.llvm.org/D92209 Files: clang/lib/AST/ASTImporter.cpp clang/unitte

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong marked an inline comment as done. martong added a comment. Thanks for the review guys! Comment at: clang/lib/AST/ASTImporter.cpp:2522 + // Add to the lookupTable because we could not do that in MapImported. + Importer.AddToLookupTable(ToTypedef); + te

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

RKSimon added inline comments. Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + This should probably be pulled out too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp created this revision. nullptr.cpp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp clan

[PATCH] D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

MyDeveloperDay updated this revision to Diff 310524. MyDeveloperDay added a comment. add support for additional _Pragma CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92922/new/ https://reviews.llvm.org/D92922 Files: clang/lib/Format/Format.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D91311: Add new 'preferred_name' attribute.

jyknight added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2384 + let Spellings = [Clang<"preferred_name", /*AllowInC*/0>]; + let Subjects = SubjectList<[ClassTmpl]>; + let Args = [TypeArgument<"TypedefType">]; I wonder if this attribute oug

[PATCH] D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

krasimir accepted this revision. krasimir added a comment. This is very nice :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92922/new/ https://reviews.llvm.org/D92922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + RKSimon wrote: > This should probably be pulled out too It uses `dyn_cast(I)` so clang-tidy reports //incomplete type 'llvm::CallBase' named in nested name specifier//

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

joechrisellis updated this revision to Diff 310529. joechrisellis added a comment. Herald added a subscriber: NickHung. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92761/new/ https://reviews.llvm.org/D92761 Files: clang/lib/CodeGen/CGE

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei. RKSimon requested review of this revision. Herald added a project: clang. Followup to D87604 , having confirmed on PR47506 that we can use the llvm codegen expansion for fadd/fmul as we

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis updated this revision to Diff 310532. joechrisellis added a comment. Herald added a subscriber: NickHung. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92762/new/ https://reviews.llvm.org/D92762 Files: clang/lib/CodeGen/CGC

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle abandoned this revision. nhaehnle added a comment. Herald added a subscriber: teijeong. Superseded by D92924 , D92925 , D92926 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D92939: [clangd] Split tweak tests into one file per tweak.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/tweaks/AnnotateHighlightingsTests.cpp:9 + +#include "Annotations.h" +#include "Config.h" Most of th

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

kadircet added a comment. this mostly LGTM. there are some changes to the existing behavior; like discovery order and not looking for other plugins under `build/`, but they seem like non-harmful changes to me. my biggest question is, have we considered updating `CompilationDatabasePlugin` inte

[PATCH] D92661: [RFC] Fix TLS and Coroutine

nhaehnle added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1281-1282 // The pseudoprobe intrinsic works as a place holder to the block it probes. -// Like the sideeffect intrinsic defined above, this intrinsic is treated by the -// optimizer as having opaqu

[PATCH] D92922: [clang-format] PR42434 Remove preprocessor and pragma lines from ObjectiveC guess

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92922/new/ https://reviews.llvm.org/D92922 ___ cfe-commits mailing list cfe

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

compnerd added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2326 + + if (CGF.CGM.getCodeGenOpts().OptimizationLevel != 0 && + CGF.CGM.getTarget().getTriple().isAArch64() && Nit: I think that `> 0` is easier to read. Comment a

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:79 + // Absolute canonical path that we're the cache for. (Not case-folded). + std::string Path; + kadircet wrote: >

[clang-tools-extra] 634a377 - [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

Author: Sam McCall Date: 2020-12-09T17:40:12+01:00 New Revision: 634a377bd8cbaa515a58295cfd85dcb6a21381c1 URL: https://github.com/llvm/llvm-project/commit/634a377bd8cbaa515a58295cfd85dcb6a21381c1 DIFF: https://github.com/llvm/llvm-project/commit/634a377bd8cbaa515a58295cfd85dcb6a21381c1.diff LO

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG634a377bd8cb: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC (authored by sammccall)

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:100 llvm::StringRef Parent = path::parent_path(P.Path); - llvm::SmallVector Ancestors; for (auto I = path::begin(Parent, path::Style::posix), This should be

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:608 for (const auto &Line : Tokens) { -llvm::SmallVector LineByteTokens; +llvm::SmallVector LineByteTokens; llvm::raw_svector_ostream OS(LineByteTokens); ---

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 310561. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/lib

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2328 + CGF.CGM.getTarget().getTriple().isAArch64() && + !CGF.CGM.getTarget().getTriple().isOSWindows()) { +auto *callBase = cast(value); ahatanak wrote: > rjmccall wrote: > > c

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver added a comment. In D92846#2442447 , @dvyukov wrote: > The code looks reasonable to me. I see it only affects kernel, so assuming > you booted kernel, we should be fine. > I can rubber-stamp it, but if you want more meaningful review, please wait

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

compnerd added a comment. There is nothing particularly special about that. The reason for the funclet handling there is that in the case of an outlined block for exception handling (i.e. a funclet), we need to ensure that the assembly marker received the funclet token as failure to do so woul

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

Quuxplusone added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3110 +/// +/// \returns Whether need to do the second overload resolution. If the first +/// overload resolution fails, or if the first overload resolution success but s/need/we need/ ==

[PATCH] D92944: Don't setup inalloca for swiftcc on i686-windows-msvc

rnk created this revision. rnk added reviewers: compnerd, rjmccall. rnk requested review of this revision. Herald added a project: clang. Swiftcall does it's own target-independent argument type classification, since it is not designed to be ABI compatible with anything local on the target that is

[PATCH] D92915: [Driver] Add -f[no-]new-pass-manager to supersede -f[no-]experimental-new-pass-manager

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. Makes sense to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92915/new/ https://reviews.llvm.org/D92915 ___

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 310568. ahatanak added a comment. Fix an incorrect comment in insertRetainOrClaimRVCalls in InlineFunction.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files:

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

rnk updated this revision to Diff 310569. rnk added a comment. - use assign instead of push_back Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92883/new/ https://reviews.llvm.org/D92883 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGE

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall marked 7 inline comments as done. sammccall added a comment. Thanks for the review! > my biggest question is, have we considered updating CompilationDatabasePlugin > interface to provide a loadFromBuffer and relativeFileName virtual methods. I > think loading logic could've been a lot

[PATCH] D92439: [CLANG] Fix missing error for use of 128-bit integer inside SPIR64 device code.

jyu2 closed this revision. jyu2 added a comment. commit by rGf8d5b49c786f : Fix missing error for use of 128-bit integer inside SPIR64 device code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92439/new/ https://rev

[PATCH] D92663: [clangd] Add hot-reload of compile_commands.json and compile_flags.txt

sammccall updated this revision to Diff 310574. sammccall marked an inline comment as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92663/new/ https://reviews.llvm.org/D92663 Files: clang-

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

NoQ added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124 /// Note that this class also implements caching. -class CrossTranslationUnitContext { +class CrossTranslationUnitContext : public CrossTUAnalysisHelper { public: stea

[PATCH] D92661: [RFC] Fix TLS and Coroutine

lxfind updated this revision to Diff 310575. lxfind added a comment. Herald added subscribers: nikic, kerbowa, jvesely. Fix all failing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92661/new/ https://reviews.llvm.org/D92661 Files: clang/l

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. LGTM. I don't see any reason to always emit this option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

aaronpuchert added a comment. In D92886#2441290 , @Quuxplusone wrote: > I agree with your reasoning, but in practice I still see a lot of people > using `static inline` for functions (especially function templates) in .h > files. That's also what I was

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

steakhal added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124 /// Note that this class also implements caching. -class CrossTranslationUnitContext { +class CrossTranslationUnitContext : public CrossTUAnalysisHelper { public:

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

rnk added a comment. I see two pre-commit test failures on the patch. Can you take a look at those as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91673/new/ https://reviews.llvm.org/D91673 ___ c

[clang] d7098ff - De-templatify EmitCallArgs argument type checking, NFCI

Author: Reid Kleckner Date: 2020-12-09T11:08:00-08:00 New Revision: d7098ff29c58dd08ede8314818b7de7fd2fea4cc URL: https://github.com/llvm/llvm-project/commit/d7098ff29c58dd08ede8314818b7de7fd2fea4cc DIFF: https://github.com/llvm/llvm-project/commit/d7098ff29c58dd08ede8314818b7de7fd2fea4cc.diff

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7098ff29c58: De-templatify EmitCallArgs argument type checking, NFCI (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] df28221 - Don't setup inalloca for swiftcc on i686-windows-msvc

Author: Reid Kleckner Date: 2020-12-09T11:08:48-08:00 New Revision: df282215d497e15104ae9e182e083cdfa0bae3c2 URL: https://github.com/llvm/llvm-project/commit/df282215d497e15104ae9e182e083cdfa0bae3c2 DIFF: https://github.com/llvm/llvm-project/commit/df282215d497e15104ae9e182e083cdfa0bae3c2.diff

[PATCH] D92944: Don't setup inalloca for swiftcc on i686-windows-msvc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdf282215d497: Don't setup inalloca for swiftcc on i686-windows-msvc (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D92944?vs

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. clang-offload-bundler is not only used by clang driver to bundle/unbundle files for offloading toolchains, but also used by

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

aaron.ballman added inline comments. Comment at: clang/test/Frontend/plugin-attribute.cpp:1 -// RUN: %clang -fplugin=%llvmshlibdir/Attribute%pluginext -emit-llvm -S %s -o - 2>&1 | FileCheck %s --check-prefix=ATTRIBUTE -// RUN: not %clang -fplugin=%llvmshlibdir/Attribute%pluginex

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval created this revision. clementval added reviewers: jdoerfert, jdenny, kiranchandramohan. Herald added subscribers: jfb, arphaman, guansong, yaxunl. clementval requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, L

[PATCH] D92956: Fix https://bugs.llvm.org/show_bug.cgi?id=48011

fanfuqiang created this revision. fanfuqiang added a reviewer: dblaikie. fanfuqiang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix https://bugs.llvm.org/show_bug.cgi?id=48011 Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added a comment. In D92808#2443006 , @compnerd wrote: > There is nothing particularly special about that. The reason for the funclet > handling there is that in the case of an outlined block for exception > handling (i.e. a funclet), we need to

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

clementval updated this revision to Diff 310589. clementval added a comment. Remove useless define macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92955/new/ https://reviews.llvm.org/D92955 Files: clang/include/clang/AST/ASTFwd.h clang/inc

[PATCH] D92955: [openmp] Remove clause from OMPKinds.def and use OMP.td info

jdoerfert added a comment. I like this a lot. We might even look into generating the clang OpenMPClause classes via TableGen later, thanks a lot. There is a file missing, right? The list of actual clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D92956: Fix https://bugs.llvm.org/show_bug.cgi?id=48011

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/warn-range-loop-analysis.cpp:35 + // operator. + ID1& operator=(ID1 const& other) { return *this; } +}; I recommend adding `ID1(ID1 const&) = default;` here. My understanding is that C++20 has d

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong updated this revision to Diff 310591. martong marked an inline comment as done. martong added a comment. - Remove not relevant param from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92209/new/ https://reviews.llvm.org/D92209 Files:

[PATCH] D92954: [clang-offload-bundler] Add option -list

tra added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:763 + +// Create an intermediate temporary file for reading the bundles. +TempFileHandlerRAII TempFiles; Having to create a temporary file in order to *list*

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. I don't think I understand the whole picture here. Why would only builtins get mutated? Does a call to "modf" still call "modf"? But __builtin_modf will call modf128? Is there a corresponding patch to the runtime libcalls table in the backend? With -ffast-math __bu

  1   2   3   >