martong added inline comments.
================
Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:124
/// Note that this class also implements caching.
-class CrossTranslationUnitContext {
+class CrossTranslationUnitContext : public CrossTUAnalysisHelper {
public:
----------------
Why don't we have a dependency in libCrossTU to libAnalysis? In the
CMakeLists.txt?
Here we implement the CrossTUAnalysisHelper's abstract virtual function thus we
include the `CrossTUAnalysisHelper.h`. But
CMake should know about the dependency even if this is only a header only
dependency, shouldn't it? (We were talking about this with @steakhal.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92432/new/
https://reviews.llvm.org/D92432
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
