dfukalov added inline comments.
================ Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:685 + } +} + ---------------- RKSimon wrote: > This should probably be pulled out too It uses `dyn_cast<CallBase>(I)` so clang-tidy reports //incomplete type 'llvm::CallBase' named in nested name specifier// if the function definition is in header. This is result of removing include Instructions.h from AliasAnalysis.h. Actually there is one more same clang-tidy report on `isa<AllocaInst>` in MemorySSA.h that includes AliasAnalysis.h (and so included Instructions.h through it). I thought to fix it the same way - moving function with `isa<AllocaInst>` to MemorySSA.cpp Or should I leave include Instructions.h in AliasAnalysis.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92852/new/ https://reviews.llvm.org/D92852 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
