[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM with a single comment on the test. Comment at: clang/unittests/Format/FormatTest.cpp:17676-17684 +format("void foo() {\n" + "#if 1\n" +

[PATCH] D90232: [clang-format] Formatting constructor initializer lists by putting them always on different lines (update to D14484)

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. I agree with @MyDeveloperDay that the existing tests should not be altered. Comment at: clang/docs/ClangFormatStyleOptions.rst:1473 -**ConstructorInitializerA

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

HsiangKai added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT("

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

liaolucy added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:68 +RVV_VECTOR_TYPE_INT("__rvv_int8mf2_t", RvvInt8mf2, RvvInt8mf2Ty, 4, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m1_t", RvvInt8m1, RvvInt8m1Ty, 8, 8, 1, true) +RVV_VECTOR_TYPE_INT("__r

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17676-17684 +format("void foo() {\n" + "#if 1\n" + " #pragma omp simd\n" + " for (int k = 0; k < 10; k++) {\n" +

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_IN

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

aqjune added a comment. Herald added a subscriber: frasercrmck. In D85788#2335838 , @eugenis wrote: > I wonder it can be avoided by > > - disable noundef analysis by default in cc1 > - always add -enable-noundef-analysis in the driver when invoking cc1 Wo

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jwakely added a comment. In D87974#2438723 , @zoecarver wrote: > In D87974#2438682 , @BillyONeal > wrote: > >>> Are they actually the same, with the same handling of corner cases like >>> unions and tail padding?

[clang] a134477 - Revert "Add new 'preferred_name' attribute."

Author: Richard Smith Date: 2020-12-08T00:42:48-08:00 New Revision: a1344779ab019a6bcd29842c1499343e15efbe87 URL: https://github.com/llvm/llvm-project/commit/a1344779ab019a6bcd29842c1499343e15efbe87 DIFF: https://github.com/llvm/llvm-project/commit/a1344779ab019a6bcd29842c1499343e15efbe87.diff

[PATCH] D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, JakeMerdichAMD, klimek. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay requested review of this revision. Fix spelling mistake Leave space after `.` and before beginning of next

[PATCH] D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I have only one question, what stands NFC for? I figured something like "no functional change"? But I can't find a definition anywhere. Repository: rG LLVM Github Mo

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. In D92257#2438926 , @MyDeveloperDay wrote: > In D92257#2435906 , @lebedev.ri > wrote: > >> In D92257#2435902

[clang] ca93f9a - [Clang][CodeGen][RISCV] Add hard float ABI tests with empty struct

Author: Luís Marques Date: 2020-12-08T09:19:05Z New Revision: ca93f9abdc0abc96ca8fb7999549a50aadd95caf URL: https://github.com/llvm/llvm-project/commit/ca93f9abdc0abc96ca8fb7999549a50aadd95caf DIFF: https://github.com/llvm/llvm-project/commit/ca93f9abdc0abc96ca8fb7999549a50aadd95caf.diff LOG:

[clang] fa8f5bf - [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

Author: Luís Marques Date: 2020-12-08T09:19:05Z New Revision: fa8f5bfa4e8cff042c9730320c74e97fab152ae1 URL: https://github.com/llvm/llvm-project/commit/fa8f5bfa4e8cff042c9730320c74e97fab152ae1 DIFF: https://github.com/llvm/llvm-project/commit/fa8f5bfa4e8cff042c9730320c74e97fab152ae1.diff LOG:

[clang] 3af354e - [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

Author: Luís Marques Date: 2020-12-08T09:19:05Z New Revision: 3af354e863f553ef727967dfc091a64a11500aa5 URL: https://github.com/llvm/llvm-project/commit/3af354e863f553ef727967dfc091a64a11500aa5 DIFF: https://github.com/llvm/llvm-project/commit/3af354e863f553ef727967dfc091a64a11500aa5.diff LOG:

[PATCH] D92792: [clang] - Also look for devtoolset-10

stephan.dollberg added a comment. Thanks @phosek , can you merge it please? I don't have perms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792 ___ cfe-commits ma

[PATCH] D92822: [clang-format] [NFC] Fix spelling and grammatical errors in IncludeBlocks text

curdeius accepted this revision. curdeius added a comment. In D92822#2439069 , @HazardyKnusperkeks wrote: > I have only one question, what stands NFC for? I figured something like "no > functional change"? But I can't find a definition anywhere. https:/

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17676-17684 +format("void foo() {\n" + "#if 1\n" + " #pragma omp simd\n" + " for (int k = 0; k < 10; k++) {\n" +

[PATCH] D92753: [clang-format] Add IndentPragma style to eliminate common clang-format off scenario

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17676-17684 +format("void foo() {\n" + "#if 1\n" + " #pragma omp simd\n" + "

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. > And where do I do that? Also I did not think I would not have a chance of > getting the access so early. https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

t.p.northover closed this revision. t.p.northover added a comment. Committed: To github.com:llvm/llvm-project.git c54d827fdb12..c5978f42ec8e main -> main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89959/new/ https://reviews.llvm.org/D89959 __

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

sammccall added a comment. Thanks for cleaning up! In D92788#2438207 , @njames93 wrote: > Not sure I'm a huge fan of this, Some of these cases the size is specified > because that's the upper limit we typically expect the SmallVector to use. The idea be

[PATCH] D92108: Fix inconsistent availability attribute message string literal check.

nigelp-xmos added a comment. Many thanks for review and approval. Please could it be committed as I do not have commit access? (I will request.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92108/new/ https://reviews.llvm.org/D92108

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92764/new/ https://reviews.llvm.org/D92764 ___

[PATCH] D92825: [clang][cli] CompilerInvocationTest: join two test fixtures into one

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a reviewer: a.sidorin. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D92826: [clang][cli] CompilerInvocationTest: rename member variable in fixture

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a reviewer: a.sidorin. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92825 . Repositor

[PATCH] D92827: [clang][cli] CompilerInvocationTest: split enum test into two

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92826 . Repository: rG LLVM Github Monorepo https:

[PATCH] D92828: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92827 . Repository: rG LLVM Github Monorepo https:

[PATCH] D92829: [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92828 . Repository: rG LLVM Github Monorepo https:

[PATCH] D92830: [clang][cli] CompilerInvocationTest: join and add test cases

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92829 . Repository: rG LLVM Github Monorepo https:

[PATCH] D92774: [clang][cli] Add command line marshalling tests

jansvoboda11 updated this revision to Diff 310134. jansvoboda11 added a comment. Split into multiple patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvoca

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

RKSimon added a comment. This patch doesn't look like it is taking into account the existing (albeit limited) support for znver3 - it looks like a very bad merge imo. It'd make much more sense to split this into several smaller incremental patches: 1 - cleanup any missing basic znver3 handling

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

sammccall added a comment. The thrust of this change is great, I'm just having trouble being sure there are no bad side-effects. --- I almost left a comment here saying we might want to recover here... before noticing that we recover all the way up at ParsePostfixExpressionSuffix(). It may be

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 updated this revision to Diff 310135. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/C

[PATCH] D92774: [clang][cli] Add command line marshalling tests

jansvoboda11 added a comment. I'm sorry about that, I understand that was hard to review. This is now split this into multiple patches: D92825 , D92826 , D92827 , D92828

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:45 Context.AddMetadata("version", clang::getClangToolFullVersion("clangd")); -std::chrono::system_clock::time_point Deadline = -std::chrono::system_clock::now() + Deadli

[PATCH] D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It must have been a tedious task to collect all these - without any copy-paste errors, really impressive! It's good to go, however, if you don't mind there would be some readability issue

[PATCH] D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints

steakhal added a comment. One more thing. Please reflow the path's summary, to keep the range constraint in a single line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92771/new/ https://reviews.llvm.org/D92771 ___

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 added a comment. That's great to hear, thanks. Comment at: clang/include/clang/Driver/Options.td:371 + // TODO: Assert that the flags have different value. + // TODO: Assert that only one of the flags can be implied. + Does TableGen support some

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

eugenis added a comment. This change looks fine to me, but I'm slightly concerned about https://reviews.llvm.org/D85788 - see my last comment on that revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D8167

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

aqjune added a comment. In D81678#2438264 , @eugenis wrote: > This change looks fine to me, but I'm slightly concerned about > https://reviews.llvm.org/D85788 - see my last comment on that revision. Thank you for the link! I left a comment there. Repos

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 ___ cfe-commits mailing list cf

[PATCH] D92630: ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92630/new/ https://reviews.llvm.org/D92630

[PATCH] D92773: [clang][cli] Unify boolean marshalling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG083e035c47f6: [clang][cli] Unify boolean marshalling (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 083e035 - [clang][cli] Unify boolean marshalling

Author: Jan Svoboda Date: 2020-12-08T13:47:30+01:00 New Revision: 083e035c47f6c73084ecf5ab7f41cddca19ce332 URL: https://github.com/llvm/llvm-project/commit/083e035c47f6c73084ecf5ab7f41cddca19ce332 DIFF: https://github.com/llvm/llvm-project/commit/083e035c47f6c73084ecf5ab7f41cddca19ce332.diff L

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

LuoYuanke created this revision. Herald added subscribers: pengfei, hiraditya. LuoYuanke requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92837 Files: clan

[PATCH] D92782: [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

bader updated this revision to Diff 310145. bader added a comment. Fix clang-format issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92782/new/ https://reviews.llvm.org/D92782 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGen/address

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Left a couple of nits and a question, but LGTM overall. Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +ret

[PATCH] D92678: ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92678/new/ https://reviews.llvm.org/D92678

[PATCH] D92680: Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92680/new/ https://reviews.llvm.org/D92680

[PATCH] D92699: Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92699/new/ https://reviews.llvm.org/D92699

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:499 +MI.RemoveOperand(3); // Remove $tmmcfg +for (int i = 2; i > 0; --i) + MI.RemoveOperand(i); Can change to i = 3? Comment at: llvm/lib/Target/X86

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:499 +MI.RemoveOperand(3); // Remove $tmmcfg +for (int i = 2; i > 0; --i) + MI.RemoveOperand(i); pengfei wrote: > Can change to i = 3? Yes, then remove line 498. ==

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a testing request, the frontend parts LGTM. I don't know enough about the LLVM side to feel comfortable signing off on it. @jdoerfert, would you mind approving that pa

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2366 +/// Matches C11 _Generic expression. +extern const internal::VariadicDynCastAllOfMatcher +genericSelectionExpr; tmroeder wrote: > aaron.ballman wrote: > > Do

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. In D92155#2419667 , @psionic12 wrote: >> - main file AST build: Important to run plugins here but it's critical they >> don't traverse the whole preamble (can degrade latency by orders of >> magnitude). > > Well, Sound reasonab

[PATCH] D91925: [clangd][NFC] Small tweak to combined provider

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. (I'm not sure how it resolves the problem, but certainly looks nicer!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91925/new/ https://re

[PATCH] D92825: [clang][cli] CompilerInvocationTest: join two test fixtures into one

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92825/new/ https://reviews.llvm.org/D92825 _

[PATCH] D92826: [clang][cli] CompilerInvocationTest: rename member variable in fixture

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92826/new/ https://reviews.llvm.org/D92826 _

[PATCH] D92827: [clang][cli] CompilerInvocationTest: split enum test into two

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92827/new/ https://reviews.llvm.org/D92827 _

[PATCH] D92828: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92828/new/ https://reviews.llvm.org/D92828 _

[PATCH] D92829: [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92829/new/ https://reviews.llvm.org/D92829 _

[PATCH] D92830: [clang][cli] CompilerInvocationTest: join and add test cases

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; thanks for splitting out the prep commits! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92830/new/ https://reviews.llvm.org/D9283

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 added a comment. WIP, need to fix a typo in the test. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:141 + ASSERT_TRUE(Diags->hasErrorOccurred()); // Driver-only flag. + ASSERT_TRUE(Invocation.getCodeGenOpts().Autolink); +} This

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 310176. jansvoboda11 added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp Index:

[PATCH] D91025: [clangd] Fix locateMacroAt() for macro definition outside preamble

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice catch! As always, sorry about the delay. Comment at: clang-tools-extra/clangd/SourceCode.cpp:987 + FileID FID = SM.getFileID(Loc); + auto JustAfterToken = +

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 added a comment. Ready to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM if you undo the change to lose support for AlwaysEmit (happy to consider in a separate patch if it’s the right thing to do though). Comment at: clang/include/cl

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 _

[clang-tools-extra] f6b205d - [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

Author: Adam Czachorowski Date: 2020-12-08T15:55:32+01:00 New Revision: f6b205dae16392382324fbca676ef6afe3920642 URL: https://github.com/llvm/llvm-project/commit/f6b205dae16392382324fbca676ef6afe3920642 DIFF: https://github.com/llvm/llvm-project/commit/f6b205dae16392382324fbca676ef6afe3920642.d

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b205dae163: [clangd] ExtractFunction: disable on regions that sometimes, but not always… (authored by adamcz). Repository: rG LLVM Github Monore

[PATCH] D92810: [clang-tidy] Recognize single character needles for absl::StrContains.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16622d535c02: [clang-tidy] Recognize single character needles for absl::StrContains. (authored by ckennelly). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 16622d5 - [clang-tidy] Recognize single character needles for absl::StrContains.

Author: Chris Kennelly Date: 2020-12-08T10:01:30-05:00 New Revision: 16622d535c021b566c1304b6388a6399e606 URL: https://github.com/llvm/llvm-project/commit/16622d535c021b566c1304b6388a6399e606 DIFF: https://github.com/llvm/llvm-project/commit/16622d535c021b566c1304b6388a6399e606.diff

[PATCH] D92762: [clang][AArch64][SVE] Avoid going through memory for coerced VLST arguments

joechrisellis updated this revision to Diff 310185. joechrisellis added a comment. Do not try to generate `llvm.experimental.vector.extract` instructions if the vector element types differ. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92762/new/

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2423750 , @bader wrote: >> It was mentioned that the changes in the type system with address spaces is >> undesirable for SYCL because you indend to parse existing C++ code as-is. >> This contradicts the intended sema

[clang] acd4950 - [FPEnv] Correct constrained metadata in fp16-ops-strict.c

Author: Kevin P. Neal Date: 2020-12-08T10:18:32-05:00 New Revision: acd4950d4f1e4ef5375a8a894a5b359caf7e844b URL: https://github.com/llvm/llvm-project/commit/acd4950d4f1e4ef5375a8a894a5b359caf7e844b DIFF: https://github.com/llvm/llvm-project/commit/acd4950d4f1e4ef5375a8a894a5b359caf7e844b.diff

[PATCH] D92596: [FPEnv] Correct constrained metadata in fp16-ops-strict.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacd4950d4f1e: [FPEnv] Correct constrained metadata in fp16-ops-strict.c (authored by kpn). Changed prior to commit: https://reviews.llvm.org/D9259

[clang-tools-extra] 8d2c095 - [clang-tidy] Omit std::make_unique/make_shared for default initialization.

Author: Chris Kennelly Date: 2020-12-08T10:34:17-05:00 New Revision: 8d2c095e5a6bd34f8bb5cffd5c57c8deea5b8647 URL: https://github.com/llvm/llvm-project/commit/8d2c095e5a6bd34f8bb5cffd5c57c8deea5b8647 DIFF: https://github.com/llvm/llvm-project/commit/8d2c095e5a6bd34f8bb5cffd5c57c8deea5b8647.diff

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2c095e5a6b: [clang-tidy] Omit std::make_unique/make_shared for d

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko added a comment. AfterStruct setting doesn't affect struct initialization. Your presumption is right. About these examples... I think that second and third variants are the right ones. struct new_struct struct_name = { a = 1 }; struct new_struct struct_name = {

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We can't expand lambda types anyway. Now we simply not offer the code actio

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

Anastasia added a comment. In D92721#2437941 , @mibintc wrote: > There are many RuntimeCalls that are created in Clang, including _read_pipe, > all the OpenMP runtime calls, etc. Shall they all have their calling > conventions set from the ABIInfo? Cur

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define cl_khr_subgroup_shuffle

[PATCH] D92487: [AArch64][Driver][SVE] Push missing SVE feature error from driver to frontend

peterwaller-arm updated this revision to Diff 310215. peterwaller-arm added a comment. Update patch for clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92487/new/ https://reviews.llvm.org/D92487 Files: clang/include/clang/Basic/Diagno

[clang] d14c631 - [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

Author: Gabor Marton Date: 2020-12-08T16:58:30+01:00 New Revision: d14c63167315edfc4a4ad91fac9c866c6e0cb67f URL: https://github.com/llvm/llvm-project/commit/d14c63167315edfc4a4ad91fac9c866c6e0cb67f DIFF: https://github.com/llvm/llvm-project/commit/d14c63167315edfc4a4ad91fac9c866c6e0cb67f.diff

[PATCH] D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd14c63167315: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd (authored by martong). Repository: rG LLVM Github Mono

[PATCH] D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints

martong marked 3 inline comments as done. martong added a comment. Thanks for the review! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1367-1368 +.Case(ReturnsZeroOrMinusOne) .ArgC

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

PiotrFusik added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define cl_khr_subgroup_shuffle

[clang] febe750 - [analyzer][StdLibraryFunctionsChecker] Add more return value contraints

Author: Gabor Marton Date: 2020-12-08T17:04:29+01:00 New Revision: febe75032f6f8322cce1dcbba11a44559aaa14e3 URL: https://github.com/llvm/llvm-project/commit/febe75032f6f8322cce1dcbba11a44559aaa14e3 DIFF: https://github.com/llvm/llvm-project/commit/febe75032f6f8322cce1dcbba11a44559aaa14e3.diff

[PATCH] D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. martong marked an inline comment as done. Closed by commit rGfebe75032f6f: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints (authored by martong)

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

Anastasia updated this revision to Diff 310227. Anastasia added a comment. - Set all macros to value 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c-base.h

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov created this revision. dfukalov added a reviewer: RKSimon. Herald added subscribers: kerbowa, asbirlea, jfb, steven_wu, george.burgess.iv, zzheng, hiraditya, eraman, nhaehnle, jvesely, arsenm, MatzeB. dfukalov requested review of this revision. Herald added projects: clang, LLVM. Herald a

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:66 class Value; +class TargetLibraryInfo; Just realized wrong order, will fix in updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. There are several LLDB tests failing with this change. The TestImportBaseClassWhenClassHasDerivedMember.py is probably the only relevant one. The others are probably failing for the same

[PATCH] D92661: [RFC] Fix TLS and Coroutine

lxfind added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + hoy wrote: > lxfind wrote: > > hoy wrote: > > > lxf

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:172 + + // TODO. This can produce wrong detection in case of a later class + // declaration. Example: Quuxplusone wrote: > I don't know the purpose of this code, but this //seems// like

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev updated this revision to Diff 310232. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve review comments. @sammccall, thanks for clarifying the cases you thought should be remaining as they are! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92853: Simplifying memory globalization from the front end to move optimizations to the middle end.Memory globalization was fully implemented in the front end. There are three runtimefunction

josemonsalve2 created this revision. josemonsalve2 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. ...__kmpc_data_sharing_coalesced_push_stack* __kmpc_d

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92854

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

Bigcheese added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:226 ASSERT_THAT(GeneratedArgs, - Contains(StrEq("-fno-experimental-new-pass-manager"))); + Not(Contains(StrEq("-fno-experimental-new-pass-manager";

  1   2   3   >