MyDeveloperDay marked 2 inline comments as done.
MyDeveloperDay added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:17676-17684
+ format("void foo() {\n"
+ "#if 1\n"
+ " #pragma omp simd\n"
+ " for (int k = 0; k < 10; k++) {\n"
+ " #pragma omp simd\n"
+ " for (int j = 0; j < 10; j++) {\n"
+ " }\n"
----------------
curdeius wrote:
> MyDeveloperDay wrote:
> > curdeius wrote:
> > > Last nit, I'd mess up spaces like suggested here.
> > This is `BeforeHash` not `AfterHash`, I think the test is correct (as it
> > passes)
> Ok. My thought was that we were not really checking that this patch will
> correctly reformat pragmas that are not yet on correct columns, but after
> your change to remove messUp=false, we do test it.
> Again, LGTM! And thank you for the patch (and the patience) :).
Its never a problem @curdeius, I'm always happy to wait for your feedback as
its considered and insightful, your comment made be go back and double check
and that can never be a bad thing. Thanks for the accept.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92753/new/
https://reviews.llvm.org/D92753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
