HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment.
In D92257#2438926 <https://reviews.llvm.org/D92257#2438926>, @MyDeveloperDay wrote: > In D92257#2435906 <https://reviews.llvm.org/D92257#2435906>, @lebedev.ri > wrote: > >> In D92257#2435902 <https://reviews.llvm.org/D92257#2435902>, @MyDeveloperDay >> wrote: >> >>> In D92257#2435899 <https://reviews.llvm.org/D92257#2435899>, >>> @HazardyKnusperkeks wrote: >>> >>>> In D92257#2435701 <https://reviews.llvm.org/D92257#2435701>, >>>> @MyDeveloperDay wrote: >>>> >>>>> Can I assume you need someone to land this for you? >>>> >>>> Yes I do. But I have a question, my last change is commited in your name, >>>> that means git blame would blame it on you, right? >>>> >>>> You can set me as author: >>>> `Björn Schäpers <bjo...@hazardy.de>` >>>> My Github Account is also called `HazardyKnusperkeks`. >>> >>> The process is that you add (https://llvm.org/docs/Contributing.html) >>> >>> Patch By: HazardyKnusperkeks >>> >>> to the commit message if the user doesn't have commit access, if you want >>> your name against the blame then I recommend applying for commit access >>> yourself. >> >> That is incorrect and does not represent the nowadays reality, i suggest >> that you look up the docs. >> >>> let me know if you still want me to land this > > Yes I agree I hadn’t seen that the process had changed, > > This is one reason why I don’t like landing patches for others, this just > confirms that in the future I will generally request people apply for commit > access themselves. And where do I do that? Also I did not think I would not have a chance of getting the access so early. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D92257 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
