[clang-tools-extra] 20b69af - [clangd] Add clang-tidy options to config

Author: Nathan James Date: 2020-11-22T10:04:01Z New Revision: 20b69af7c9c8bd9a621b05203f944bf94a3a4c26 URL: https://github.com/llvm/llvm-project/commit/20b69af7c9c8bd9a621b05203f944bf94a3a4c26 DIFF: https://github.com/llvm/llvm-project/commit/20b69af7c9c8bd9a621b05203f944bf94a3a4c26.diff LOG:

[PATCH] D90531: [clangd] Add clang-tidy options to config

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20b69af7c9c8: [clangd] Add clang-tidy options to config (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang-tools-extra] 82c22f1 - [clangd] Fix compile error after 20b69af7

Author: Nathan James Date: 2020-11-22T10:48:48Z New Revision: 82c22f124816d1f260dc8f0626d56b459d1358b8 URL: https://github.com/llvm/llvm-project/commit/82c22f124816d1f260dc8f0626d56b459d1358b8 DIFF: https://github.com/llvm/llvm-project/commit/82c22f124816d1f260dc8f0626d56b459d1358b8.diff LOG:

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob marked 82 inline comments as done. dougpuob added a comment. Hi @aaron.ballman, thank you for your feedback. I will update my change later. Unrelated change were mixed with other commits when I against git master. I did it again then the problem was gone. I found the command, `arc diff

[PATCH] D91410: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to prevent protential null deref

This revision was automatically updated to reflect the committed changes. Closed by commit rG1756d67934bb: [llvm][clang][mlir] Add checks for the return values from Target::createXXX to… (authored by OikawaKirie, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. @nridge, I believe this should fix the problem you're seeing. I'm somewhat confused as to why I'm not seeing the same

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. Because this is basically NFC and we already have tests for the AllowedRegexp option, there is no need to introduce new tests here. So long as those current tests pass with this change, thi

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:134-137 +if (!IgnoredRegexp.isValid()) { + llvm::errs() << "Invalid IgnoredRegexp regular expression: " + << IgnoredRegexpStr; +} ---

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies created this revision. lightmelodies added reviewers: kadircet, sammccall. lightmelodies added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman, javed.absar. Herald added a project: clang. lightmelodies requested review of this revision. Herald

[PATCH] D91930: [clangd] Implement textDocument/codeLens

njames93 added a comment. Please upload the diff with full context and fix the failing unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 ___ cfe-commits

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies updated this revision to Diff 306912. lightmelodies edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies updated this revision to Diff 306916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/ClangdServer.cpp cl

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525 +return "; cannot be fixed because '" + Fixup + + "' is not a valid ide

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525 +return "; cannot be fixed because '" + Fixup + + "' is not a valid identifier"; gribozavr2 wrote: > I don't think we need to tell that to

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525 +return "; cannot be fixed because '" + Fixup + + "' is not a valid identifier"; njames93 wrote: > gribozavr2 wrote: > > I don't think w

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525 +return "; cannot be fixed because '" + Fixup + + "' is not a valid identifier"; gribozavr2 wrote: > njames93 wrote: > > gribozavr2 wrote:

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://reviews.llvm.org/D91747 __

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

kadircet updated this revision to Diff 306924. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90750/new/ https://reviews.llvm.org/D90750 Files: clang-tools-ex

[PATCH] D91859: [clangd] Fix shared-lib builds

kadircet added a comment. In D91859#2409743 , @nridge wrote: > I applied the patch locally and it fixes most of the linker errors but I'm > still seeing one: > > [6/393] Linking CXX executable bin/clangd-index-server > FAILED: bin/clangd-index-server

[PATCH] D91915: [clang-tidy] Fix RenamerClangTidy checks trying to emit a fix that isnt a valid identifier

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:525 +return "; cannot be fixed because '" + Fixup + + "' is not a valid identifier"; njames93 wrote: > gribozavr2 wrote: > > njames93 wrote:

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. In D91859#2410166 , @kadircet wrote: > In D91859#2409743 , @nridge wrote: > >> I applied the patch locally and it fixes most of the linker errors but I'm >> still seeing one: >> >> [6/39

[clang] 825f80e - [Sema] Introduce function reference conversion, NFC

Author: Aaron Puchert Date: 2020-11-22T20:51:57+01:00 New Revision: 825f80e111f2815a009084f65267be3b5bf0897a URL: https://github.com/llvm/llvm-project/commit/825f80e111f2815a009084f65267be3b5bf0897a DIFF: https://github.com/llvm/llvm-project/commit/825f80e111f2815a009084f65267be3b5bf0897a.diff

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG825f80e111f2: [Sema] Introduce function reference conversion, NFC (authored by aaronpuchert). Changed prior to commit: https://reviews.llvm.org/D67112?vs=246862&id=306929#toc Repository: rG LLVM Gith

[clang-tools-extra] 359e2f9 - [clangd] Introduce config parsing for External blocks

Author: Kadir Cetinkaya Date: 2020-11-22T20:59:37+01:00 New Revision: 359e2f988dc560d519c91d3ee96a2ea99983f5d4 URL: https://github.com/llvm/llvm-project/commit/359e2f988dc560d519c91d3ee96a2ea99983f5d4 DIFF: https://github.com/llvm/llvm-project/commit/359e2f988dc560d519c91d3ee96a2ea99983f5d4.dif

[clang-tools-extra] c9776c8 - [clangd] Introduce config compilation for External blocks

Author: Kadir Cetinkaya Date: 2020-11-22T20:59:37+01:00 New Revision: c9776c8d4ef7c1d69b6d74b81627c4028396e7c1 URL: https://github.com/llvm/llvm-project/commit/c9776c8d4ef7c1d69b6d74b81627c4028396e7c1 DIFF: https://github.com/llvm/llvm-project/commit/c9776c8d4ef7c1d69b6d74b81627c4028396e7c1.dif

[PATCH] D90748: [clangd] Introduce config parsing for External blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG359e2f988dc5: [clangd] Introduce config parsing for External blocks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9776c8d4ef7: [clangd] Introduce config compilation for External blocks (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/

[clang-tools-extra] 067ffbf - [clangd] Introduce ProjectAwareIndex

Author: Kadir Cetinkaya Date: 2020-11-22T20:59:37+01:00 New Revision: 067ffbfe60180aa7b1fdd87b2b6e8ccc67a43a76 URL: https://github.com/llvm/llvm-project/commit/067ffbfe60180aa7b1fdd87b2b6e8ccc67a43a76 DIFF: https://github.com/llvm/llvm-project/commit/067ffbfe60180aa7b1fdd87b2b6e8ccc67a43a76.dif

[clang-tools-extra] cab3136 - [clangd] Use ProjectAwareIndex in ClangdMain

Author: Kadir Cetinkaya Date: 2020-11-22T20:59:38+01:00 New Revision: cab313680703097f5f4642b348c43018f55a5a4f URL: https://github.com/llvm/llvm-project/commit/cab313680703097f5f4642b348c43018f55a5a4f DIFF: https://github.com/llvm/llvm-project/commit/cab313680703097f5f4642b348c43018f55a5a4f.dif

[PATCH] D90750: [clangd] Introduce ProjectAwareIndex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG067ffbfe6018: [clangd] Introduce ProjectAwareIndex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D91860: [clangd] Move remote-index dependency from clangDaemon to ClangdMain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcab313680703: [clangd] Use ProjectAwareIndex in ClangdMain (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 6553600 - [clangd] Fix use-after-free in ProjectAwareIndex tests

Author: Kadir Cetinkaya Date: 2020-11-22T21:29:45+01:00 New Revision: 655360096f27f25a0e2f71729c1c879f1fd8d8a2 URL: https://github.com/llvm/llvm-project/commit/655360096f27f25a0e2f71729c1c879f1fd8d8a2 DIFF: https://github.com/llvm/llvm-project/commit/655360096f27f25a0e2f71729c1c879f1fd8d8a2.dif

[PATCH] D91908: [clang-tidy] Use compiled regex for AllowedRegexp in macro usage check

smhc added a comment. Thank you - I don't have commit access so am unable to merge it myself. The clang-tidy tests are passing fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91908/new/ https://reviews.llvm.org/D91908 ___ cfe-commits mai

[PATCH] D91859: [clangd] Fix shared-lib builds

nridge added a comment. In D91859#2410166 , @kadircet wrote: > In D91859#2409743 , @nridge wrote: > >> I applied the patch locally and it fixes most of the linker errors but I'm >> still seeing one: >> >> [...] > >

[PATCH] D91859: [clangd] Fix shared-lib builds

nridge added a comment. In D91859#2410002 , @kbobyrev wrote: > Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. > @nridge, I believe this should fix the problem you're seeing. Not sure if this is what you meant, but I fixed it by add

[PATCH] D91859: [clangd] Fix shared-lib builds

kbobyrev added a comment. In D91859#2410252 , @nridge wrote: > In D91859#2410002 , @kbobyrev wrote: > >> Ah, right. I think `clangd-remote-index` needs `protobuf` dependency. >> @nridge, I believe this should fix t

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc updated this revision to Diff 306942. smhc marked 4 inline comments as done. smhc added a comment. Updated after review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files: clang-tools-extra/clang-tidy/readability/IdentifierNa

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:127-128 getFileStyleFromOptions(const ClangTidyCheck::OptionsView &Options) { SmallVector, 0> Styles( SK_Count); SmallString<64> StyleString;

[clang] 15a3ae1 - [Clang] Add __STDCPP_THREADS__ to standard predefine macros

Author: Zequan Wu Date: 2020-11-22T16:05:53-08:00 New Revision: 15a3ae1ab1a64cc62041c32ba54914a9dd7b8361 URL: https://github.com/llvm/llvm-project/commit/15a3ae1ab1a64cc62041c32ba54914a9dd7b8361 DIFF: https://github.com/llvm/llvm-project/commit/15a3ae1ab1a64cc62041c32ba54914a9dd7b8361.diff LOG

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15a3ae1ab1a6: [Clang] Add __STDCPP_THREADS__ to standard predefine macros (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D90749: [clangd] Introduce config compilation for External blocks

thakis added a comment. This breaks tests on Windows: http://45.33.8.238/win/28408/step_9.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90749/new/ https://reviews.llvm.org/D907

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 306951. nridge marked 14 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-ex

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1649 + // into the same CallHierarchyIncomingCall. + llvm::DenseMap ResultMap; + // We can populate the keys of ResultMap, and the FromRanges fields of ---

[PATCH] D91123: [clangd] Call hierarchy (ClangdServer layer)

nridge updated this revision to Diff 306953. nridge added a comment. Update as per API changes in xrefs patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91123/new/ https://reviews.llvm.org/D91123 Files: clang-tools-extra/clangd/ClangdServer.c

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D91124: [clangd] Call hierarchy (ClangdLSPServer layer)

nridge updated this revision to Diff 306954. nridge added a comment. Update as per API changes in xrefs patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91124/new/ https://reviews.llvm.org/D91124 Files: clang-tools-extra/clangd/ClangdLSPServe

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D91941: [clangd] Use WorkScheduler.run() in ClangdServer::resolveTypeHierarchy()

nridge added a comment. As discussed in https://reviews.llvm.org/D91123#inline-856770 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91941/new/ https://reviews.llvm.org/D91941 ___ cfe-commits mailing list

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

pengfei added a comment. In D80344#2407305 , @tentzen wrote: > In D80344#2407250 , @pengfei wrote: > >> Do we need to consider FP exceptions in _try block? > > Yes, FP exception is handled as long as FP exceptions a

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

OikawaKirie added a comment. In D91844#2408897 , @dexonsmith wrote: > Is it possible to split these up into separate patches for unrelated code? Since these are reported by one static scan, and these reported places cannot be categorized with others, I c

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:134 public: static cl::opt VerifyPreservedCFG; kuhar wrote: > not necessary anymore there can bee a need to disabled/enable (e.g. for some tests or for debugging)

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added a comment. In D91327#2408521 , @kuhar wrote: > Looks fine to me, but I'm not confident enough to give an approval. Thanks. I'm working closely with @skatkov and believe he have enough expertise to review fully. The biggest issue with the cu

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

kuhar added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:134 public: static cl::opt VerifyPreservedCFG; yrouban wrote: > kuhar wrote: > > not necessary anymore > there can bee a need to disabled/enable (e.g. for some test

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:134 public: static cl::opt VerifyPreservedCFG; kuhar wrote: > yrouban wrote: > > kuhar wrote: > > > not necessary anymore > > there can bee a need to disabled/ena

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. Ping. If there's no pushback within next 24h i will commit this and wait for post-commit review (if any). Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 ___

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

hokein added a comment. just nits. Looks like the patch is based on the old revision (pre-merging tests are failing), I assume you have fixed the failure tests last week? Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:615 {"workspaceSymbolProvider", tru