nridge added a comment. In D91859#2410166 <https://reviews.llvm.org/D91859#2410166>, @kadircet wrote:
> In D91859#2409743 <https://reviews.llvm.org/D91859#2409743>, @nridge wrote: > >> I applied the patch locally and it fixes most of the linker errors but I'm >> still seeing one: >> >> [...] > > I am not able to reproduce the failure. Maybe we should just make the > dependencies introduced in `generate_protos` for grpc++ and protobuf PUBLIC, > to ensure they propagate into users (i believe that's the default for my > configuration for whatever reason). Can you share your cmake configuration ? The cmake command I'm using for this build building is something like: cmake -G Ninja <sourcedir> -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DLLVM_USE_LINKER=gold -DBUILD_SHARED_LIBS=ON \ -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_CCACHE_BUILD=ON -DCMAKE_BUILD_TYPE=Release \ -DCLANGD_ENABLE_REMOTE=ON \ -DLLVM_APPEND_VC_REV=OFF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91859/new/ https://reviews.llvm.org/D91859 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
