[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug informa

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug informa

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug informa

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306263. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

steven.zhang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:418 + // should prefer D-form if LXVX / STXVX uses a ZERO or ZERO8 + if (MI.getOpcode() == PPC::LXVX || MI.getOpcode() == PPC::STXVX) { +LLVM_DEBUG(dbgs()

[PATCH] D91279: [PowerPC] DForm instructions should be preferred when using zero register

shchenz added a comment. > After a discussion with the group I would like to correct what I said in the > previous post. > There already is a plan to do this in ISel in a different patch. The reason > we also want to do this optimization here is to try to catch situations where > this pattern i

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, wenlei, pengfei, hiraditya, mgorny. Herald added projects: clang, LLVM. hoy requested review of this revision. An indirect call site needs to be probed for its potential call targets. With CSSPGO a direct

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs &SA = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 && ---

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs &SA = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 && ---

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > > > aaron

[clang-tools-extra] 25f5406 - [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

Author: Chris Kennelly Date: 2020-11-18T21:16:03-05:00 New Revision: 25f5406f087579d43ca9a82dee7f3e76f0691bad URL: https://github.com/llvm/llvm-project/commit/25f5406f087579d43ca9a82dee7f3e76f0691bad DIFF: https://github.com/llvm/llvm-project/commit/25f5406f087579d43ca9a82dee7f3e76f0691bad.diff

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25f5406f0875: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view. (authored by ckennelly). Repository: rG LLVM Github Monor

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 306280. hoy edited the summary of this revision. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9175

[PATCH] D91047: Add a call super attribute plugin example

psionic12 updated this revision to Diff 306283. psionic12 added a comment. Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://reviews.llvm.org/D91047 Files: clang/examples/CMakeLists.txt clang/examples/Call

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306287. tentzen added a comment. per review feedback from John McCall and others, this update includes: - Rename intrinsic eha.scope.begin() with seh.scope.begin(). - Update LangRef.rst with detailed explanation - Add conditional cleanup test case and move th

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. I assume this has always been taken care of properly in the backend, so this is just a fix for va_arg treatment? If so, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/

[PATCH] D87981: [X86] AMX programming model.

mehdi_amini added a comment. (Drive by comments) Comment at: llvm/include/llvm/CodeGen/TileShapeInfo.h:27 + +class ShapeT { +public: Can you document the class? Comment at: llvm/lib/Target/X86/X86PreTileConfig.cpp:30 + +class X86PreTileConfig

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:783 + let Inst{47-32} = addr{15-0}; // offset + let Inst{11-8} = new; + let Inst{7-4} = BPF_CMPXCHG.Value; ast wrote: > yonghong-song wrote: > > jackmanb wrote: > > > If we go

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added inline comments. Comment at: llvm/lib/Target/X86/X86TileConfig.cpp:223 + LLVM_DEBUG(dbgs() << "** TILE REGISTER CONFIGURE**\n" +<< "** Function: " << mf.getName() << '\n'); + MF = &mf; mehdi_amini wrot

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay created this revision. MaskRay added reviewers: joerg, psmith, resistor. Herald added subscribers: cfe-commits, danielkiss, mstorsjo, kristof.beyls, krytarowski, arichardson, emaste. Herald added a project: clang. MaskRay requested review of this revision. In GCC, `aarch64-*-linux` and `a

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 306302. ckennelly added a comment. Added option to allow rewrites for default to value initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-t

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ikudrin added inline comments. Comment at: clang/include/clang/Driver/Options.td:2145-2146 HelpText<"Generate source-level debug information with dwarf version 5">; +def gdwarf64 : Flag<["-"], "gdwarf64">, Group, Flags<[CC1Option]>, + HelpText<"Generate DWARF64 debug informat

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks updated this revision to Diff 306307. aeubanks added a comment. rebase now we don't add a new parameter to callbacks, instead let individual instrumentations ask PassInstrumentationCallbacks for pass names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D87216: [NewPM] Support --print-before/after in NPM

aeubanks added a comment. In D87216#2356770 , @jamieschmeiser wrote: > The changes are specific to -print-before and -print-after (which is the > intended target and this work originated before -print-changed) but could the > change be made universal?

[PATCH] D64651: [Driver] Support file paths with -ccc-gcc-name

al3xtjames updated this revision to Diff 306309. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64651/new/ https://reviews.llvm.org/D64651 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay updated this revision to Diff 306312. MaskRay added a comment. Drop an unneeded change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Drive

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. In D91596#2404514 , @rjmccall wrote: > I assume this has always been taken care of properly in the backend, so this > is just a fix for va_arg treatment? If so, LGTM. Yes. That's just fix for `va_arg`. Thanks! CHANGES SINCE LAST

[clang] 6b1341e - [PowerPC] [Clang] Fix alignment of 128-bit float types

Author: Qiu Chaofan Date: 2020-11-19T14:22:14+08:00 New Revision: 6b1341eb5bb71a1ce4547165a247b23bb30ef44e URL: https://github.com/llvm/llvm-project/commit/6b1341eb5bb71a1ce4547165a247b23bb30ef44e DIFF: https://github.com/llvm/llvm-project/commit/6b1341eb5bb71a1ce4547165a247b23bb30ef44e.diff L

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1341eb5bb7: [PowerPC] [Clang] Fix alignment of 128-bit float types (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D91596?vs=305692&id=306315#toc Repository: rG LLVM Github M

[clang-tools-extra] 7c2990b - [clangd] Fix data race in GoToInclude.All test

Author: Kadir Cetinkaya Date: 2020-11-19T08:47:43+01:00 New Revision: 7c2990b8af6f906a431b14951e831647d9bbb090 URL: https://github.com/llvm/llvm-project/commit/7c2990b8af6f906a431b14951e831647d9bbb090 DIFF: https://github.com/llvm/llvm-project/commit/7c2990b8af6f906a431b14951e831647d9bbb090.dif

<    1   2   3