aeubanks added a comment. In D87216#2356770 <https://reviews.llvm.org/D87216#2356770>, @jamieschmeiser wrote:
> The changes are specific to -print-before and -print-after (which is the > intended target and this work originated before -print-changed) but could the > change be made universal? I would rather see the existing StringRef passed > to all the callbacks changed rather than adding the new StringRef to specific > callbacks. This way all passes benefit and are consistent. In particular, I > would like to see this change applied to -printChanged; this came up in the > reviews for that PR. If you would rather not make it universal, then at > least change all of the callbacks to also receive the new StringRef. I think this change might be a better way, PTAL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87216/new/ https://reviews.llvm.org/D87216 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
