MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:150 + const SanitizerArgs &SA = getToolChain().getSanitizerArgs(); + if (LINKER_SUPPORTS_Z_RELAX_TRANSTLS && + getToolChain().getTriple().getArch() == llvm::Triple::x86_64 && ---------------- MaskRay wrote: > Can the configure-time variable `LINKER_SUPPORTS_Z_RELAX_TRANSTLS` be > replaced by a version check on the triple suffix? > > You can see some tests where `x86_64-unknown-freebsd11` or > `x86_64-unknown-freebsd12` is used. The idea is that the driver continuously > bumps the default version. .. and the code base should not be littered with -D macros from configure-time variables here and there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91605/new/ https://reviews.llvm.org/D91605 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits