[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

hokein added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:434 +for (AttributedTypeLoc ATL = *ATLPtr; !ATL.isNull(); + ATL = ATL.getNextTypeLoc().getAs()) + Result.push_back(ATL.getAttr()); this looks like not safe, `getNextTypeLo

[PATCH] D89972: Add pipeline model for HiSilicon's TSV110

Elvina added a comment. Failure on test "linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp" looks bogus. I found the same cases https://reviews.llvm.org/D89895 and https://reviews.llvm.org/D89964. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

sammccall updated this revision to Diff 300182. sammccall added a comment. Add comment+assert to clarify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89785/new/ https://reviews.llvm.org/D89785 Files: clang-tools-extra/clangd/AST.cpp clang-too

[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:434 +for (AttributedTypeLoc ATL = *ATLPtr; !ATL.isNull(); + ATL = ATL.getNextTypeLoc().getAs()) + Result.push_back(ATL.getAttr()); hokein wrote: > this looks like not s

[PATCH] D88553: [clangd] Start using SyntaxTrees for folding ranges feature

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:40 -// Recursively collects FoldingRange from a symbol and its children. -void collectFoldingRanges(DocumentSymbol Symbol, - std::vector &Result) { +llvm::Option

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), sammccall wrote:

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300187. hokein marked 4 inline comments as done. hokein added a comment. address comments and add AST tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files: cla

[PATCH] D89785: [clangd] Add basic support for attributes (selection, hover)

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:233 + }; + ASSERT_THAT(DeclAttrs("X"), Each(implicitAttr())); + ASSERT_THAT(DeclAttrs("Y"), Contains(attrKi

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 updated this revision to Diff 300188. LiuChen3 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90009/new/ https://reviews.llvm.org/D90009 Files: clang/test/CodeGen/X86/att-inline-asm-prefix.c llvm/lib/T

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

LiuChen3 added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp:352 + if (Flags & X86::Force_VEXEncoding) +O << "\t{vex}"; + else if (Flags & X86::Force_VEX2Encoding) pengfei wrote: > `"\t{vex}\t"` ? No "\t" needed to a

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), hokein wrote:

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. With every incremental change, one needs to check-in new model upstream. This al

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

steakhal added a comment. @ASDenysPetrov Please grep for the `SymbolRef` and rename the other symbols/comments as well, especially the compound names. In D89987#2348935 , @OikawaKirie wrote: > Since `SymbolRef` is just a `const SymExpr *` in the current

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) --

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) -

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) -

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Spelling out `llvm::sys::path::` twice does

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) --

[PATCH] D89986: [AIX]ignore the option -fvisibility-inlines-hidden when there is no option -fvisibility=*

nemanjai added inline comments. Comment at: clang/test/CodeGen/aix-visibility-inlines-hidden.cpp:30-34 +// COMMON-ASM: mflr 0 +// COMMON-ASM-NEXT:stw 0, 8(1) +// COMMON-ASM-NEXT:stwu 1, -64(1) +// COMMON-ASM-NEXT:bl ._Z1fv +// NOP-ASM-NEXT: nop -

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:55 if (!RemoteIndexRoot.empty()) { assert(llvm::sys::path::is_absolute(RemoteIndexRoot)); +this->RemoteIndexRoot = llvm::sys::path::is_absolut

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev added a comment. The ones you proposed would not work without `using llvm::sys::path::*` which I avoid :( They have to have an argument from `llvm::sys::path::` in order for the lookup to be performed correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

ArcsinX added a comment. In D90016#2349436 , @kbobyrev wrote: > The ones you proposed would not work without `using llvm::sys::path::*` which > I avoid :( They have to have an argument from `llvm::sys::path::` in order > for the lookup to be performed co

[PATCH] D89852: [clangd] Get rid of llvm::Optional in Remote- and LocalIndexRoot; NFC

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:60 +llvm::StringRef Path(this->RemoteIndexRoot); +if (!is_separator(this->RemoteIndexRoot.back(), + llvm::sys::path::Style::posix)) -

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kadircet added a comment. I am not really keen about trusting ADL for these, as it makes the code less explicit for reader, especially as it is not something we commonly depend on clangd so readers/reviewers would not be expecting that. So I believe we should not stray away from the general pro

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

Tyker updated this revision to Diff 300213. Tyker added a comment. In D88645#2347731 , @aaron.ballman wrote: > In D88645#2347725 , @Tyker wrote: > >> In D88645#2347050 , @aa

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki updated this revision to Diff 300214. miyuki added a comment. Fixed linter errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69844/new/ https://reviews.llvm.org/D69844 Files: clang/include/clang/Basic/SourceLocation.h clang/lib/Anal

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1020-1023 +// Resume the default rounding and exception modes. +NewFPFeatures.setRoundingModeOverride( +llvm::RoundingMode::NearestTiesToEven); +NewFPFeatures.setFPExceptionModeOverride(L

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff added a comment. Ping. This is the only remaining prerequisite for D78903 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 __

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

sammccall created this revision. sammccall added reviewers: gribozavr, eduucaldas. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. This gives us slightly nicer syntax (foreach) for idioms currently expressed as a loop, and the opt

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev updated this revision to Diff 300222. kbobyrev added a comment. Add using directives for llvm::sys::path functions used more than once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90016/new/ https://reviews.llvm.org/D90016 Files: clan

[PATCH] D90026: [FPEnv] Tests for rounding properties of constant evalution

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, mibintc. Herald added a project: clang. sepavloff requested review of this revision. These are moved from D88498 . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90026

[PATCH] D89882: [clangd] Offset enum values by when marshalling

kbobyrev updated this revision to Diff 300229. kbobyrev added a comment. Migrate to proto2 syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-tools-extra/clangd/index/remote/Index.proto

[PATCH] D89882: [clangd] Offset enum values by when marshalling

kbobyrev updated this revision to Diff 300230. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Remove outdated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-to

[PATCH] D89882: [clangd] Migrate to proto2 syntax

kbobyrev updated this revision to Diff 300231. kbobyrev added a comment. Remove a newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-tools-extra/clangd/index/remote/Index.proto clang-

[PATCH] D90027: [CMake] generate_grpc_protos -> generate_protos(... GRPC). NFC

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: llvm-commits, cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added projects: clang, LLVM. sammccall requested review of this revision. Repository: rG LLVM Github Monorepo https://review

[PATCH] D89882: [clangd] Migrate to proto2 syntax

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:118 Req.IDs = std::move(*IDs); - Req.Filter = static_cast(Message->filter()); +

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:30 +using llvm::sys::path::append; +using llvm::sys::path::convert_to_slash; -

[clang-tools-extra] 55a2dee - [clang-tidy] Fix redefinition of module in the same module.modulemap file

Author: Dmitry Polukhin Date: 2020-10-23T13:20:18+01:00 New Revision: 55a2deed075b87646db62abc7bcd476541eda403 URL: https://github.com/llvm/llvm-project/commit/55a2deed075b87646db62abc7bcd476541eda403 DIFF: https://github.com/llvm/llvm-project/commit/55a2deed075b87646db62abc7bcd476541eda403.dif

[PATCH] D90031: [clang] Split remote index service definition into a separate file.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, mgorny. Herald added a project: clang. sammccall requested review of this revision. This allows it to have a separate namespace (grpc versioned service) with

[PATCH] D89886: [clang-tidy] Fix redefinition of module in the same module.modulemap file

This revision was automatically updated to reflect the committed changes. DmitryPolukhin marked an inline comment as done. Closed by commit rG55a2deed075b: [clang-tidy] Fix redefinition of module in the same module.modulemap file (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo

[PATCH] D90031: [clang] Split remote index service definition into a separate file.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90031/new/ https://reviews.llvm.org/D90031 _

[PATCH] D89882: [clangd] Migrate to proto2 syntax

kbobyrev updated this revision to Diff 300246. kbobyrev added a comment. Remove unnecessary comment and fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89882/new/ https://reviews.llvm.org/D89882 Files: clang-tools-extra/clangd/index/re

[clang-tools-extra] 421a2a0 - [clangd] Migrate to proto2 syntax

Author: Kirill Bobyrev Date: 2020-10-23T14:27:15+02:00 New Revision: 421a2a0dbbd691abeb86dee150cf710a6122e269 URL: https://github.com/llvm/llvm-project/commit/421a2a0dbbd691abeb86dee150cf710a6122e269 DIFF: https://github.com/llvm/llvm-project/commit/421a2a0dbbd691abeb86dee150cf710a6122e269.diff

[PATCH] D89882: [clangd] Migrate to proto2 syntax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421a2a0dbbd6: [clangd] Migrate to proto2 syntax (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D90027: [CMake] generate_grpc_protos -> generate_protos(... GRPC). NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81f7b2ac0fdc: [CMake] generate_grpc_protos -> generate_protos(...

[clang-tools-extra] 81f7b2a - [CMake] generate_grpc_protos -> generate_protos(... GRPC). NFC

Author: Sam McCall Date: 2020-10-23T14:28:07+02:00 New Revision: 81f7b2ac0fdc84906d31f6824e34103798d3306c URL: https://github.com/llvm/llvm-project/commit/81f7b2ac0fdc84906d31f6824e34103798d3306c DIFF: https://github.com/llvm/llvm-project/commit/81f7b2ac0fdc84906d31f6824e34103798d3306c.diff LO

[PATCH] D90016: [clangd] NFC: Rely on ADL in llvm::sys::path calls in marshalling

kbobyrev updated this revision to Diff 300249. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90016/new/ https://reviews.llvm.org/D90016 Files: clang-tools-e

[PATCH] D90016: [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6c4d880fa8c: [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path (authored by kbobyrev). Repository: rG LLVM Github Monorepo

[clang-tools-extra] e6c4d88 - [clangd] NFC: Add using directives to avoid spelling out llvm::sys::path

Author: Kirill Bobyrev Date: 2020-10-23T14:38:31+02:00 New Revision: e6c4d880fa8c1fdb55850cccd5d56050b7f3ecc5 URL: https://github.com/llvm/llvm-project/commit/e6c4d880fa8c1fdb55850cccd5d56050b7f3ecc5 DIFF: https://github.com/llvm/llvm-project/commit/e6c4d880fa8c1fdb55850cccd5d56050b7f3ecc5.diff

[PATCH] D90031: [clang] Split remote index service definition into a separate file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6c1c3f97f13: [clang] Split remote index service definition into a separate file. (authored by sammccall). Changed prior to commit: https://review

[clang-tools-extra] e6c1c3f - [clang] Split remote index service definition into a separate file.

Author: Sam McCall Date: 2020-10-23T15:20:51+02:00 New Revision: e6c1c3f97f13b7d973fa786a3f2da883fa31bdf6 URL: https://github.com/llvm/llvm-project/commit/e6c1c3f97f13b7d973fa786a3f2da883fa31bdf6 DIFF: https://github.com/llvm/llvm-project/commit/e6c1c3f97f13b7d973fa786a3f2da883fa31bdf6.diff LO

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov added a comment. I confirm that D89752 eliminates 47332 on Windows. Tested against the following CUDA versions: 7.0, 7,5, 9,2, 10.0, 10,1, 10.2, 11.0 Update 1, 11.1. Repository: rG LLVM Github Monorepo C

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

dougpuob added a comment. Hi @aaron.ballman, Thank you for the suggestion. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:237 +static void getHungarianNotationDefaultConfig( +std::shared_ptr HNOption) { + aaron.ballman wrot

[clang-tools-extra] ce63383 - [clangd] Drop version from remote index proto names, fix clangd-index-server

Author: Sam McCall Date: 2020-10-23T15:28:11+02:00 New Revision: ce63383e45f4c833dbff6a89b242bfd1d188786e URL: https://github.com/llvm/llvm-project/commit/ce63383e45f4c833dbff6a89b242bfd1d188786e DIFF: https://github.com/llvm/llvm-project/commit/ce63383e45f4c833dbff6a89b242bfd1d188786e.diff LO

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

ASDenysPetrov added a comment. @OikawaKirie > Different from ProgramStateRef which is an alias to IntrusiveRefCntPtr, or > StoreRef which is a wrapper object, an alias to a const SymExpr * makes no > sense to me. Yes. I omit this, because in such case we should go further and rename all those

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx created this revision. flx added reviewers: aaron.ballman, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. flx requested review of this revision. This fixes false positive cases where a non-const reference is passed to a std::function but interprete

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 300274. flx added a comment. Remove code comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp clang-

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx updated this revision to Diff 300276. flx added a comment. Revert -std=c++17 change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D90042 Files: clang-tools-extra/clang-tidy/utils/DeclRefExprUtils.cpp c

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

flx added a comment. I should note that I was only able to reproduce the false positive with the actual implementation std::function and not our fake version here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90042/new/ https://reviews.llvm.org/D

[PATCH] D89920: Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf55eeea4024c: Export TemplateArgumentMatcher so clients defining custom matchers don't need… (authored by davidvancleve, committed by sammccall). R

[clang] f55eeea - Export TemplateArgumentMatcher so clients defining custom matchers don't need to use the internal namespace

Author: David Van Cleve Date: 2020-10-23T16:13:56+02:00 New Revision: f55eeea4024cb05bff2c9f72968f23183e992a32 URL: https://github.com/llvm/llvm-project/commit/f55eeea4024cb05bff2c9f72968f23183e992a32 DIFF: https://github.com/llvm/llvm-project/commit/f55eeea4024cb05bff2c9f72968f23183e992a32.dif

[clang] 876af26 - [TableGen] Change !getop and !setop to !getdagop and !setdagop.

Author: Paul C. Anagnostopoulos Date: 2020-10-23T10:36:05-04:00 New Revision: 876af264c118c6ebcb8d79ab1a25d061f98fde82 URL: https://github.com/llvm/llvm-project/commit/876af264c118c6ebcb8d79ab1a25d061f98fde82 DIFF: https://github.com/llvm/llvm-project/commit/876af264c118c6ebcb8d79ab1a25d061f98f

[PATCH] D89814: [TableGen] Change !getop and !setop to !getdagop and !setdagop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876af264c118: [TableGen] Change !getop and !setop to !getdagop and !setdagop. (authored by Paul-C-Anagnostopoulos). Changed prior to commit: https

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Gith

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90047/new/ https://reviews.llvm.org/D90047 __

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. @dexonsmith, thanks for sharing your idea. Overall, I like the simplicity. As you say, not every command line option has an associated `CodeGenOptions` or `LangOptions` field. For this patch only, we'd need to create the following fields: - `CLUnsafeOptimizations`

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle added a comment. Hi Mehdi, this is not an appropriate place for this discussion. Yes, we have a general rule that patches can be reverted if they're obviously broken (e.g. build bot problems) or clearly violate some other standard. This is a good rule, but it doesn't apply here. If you

[PATCH] D83088: Introduce CfgTraits abstraction

arsenm added a comment. In D83088#2348641 , @mehdi_amini wrote: > In D83088#2347111 , @arsenm wrote: > >> In D83088#2346322 , @mehdi_amini >> wrote: >> >>> In D83088#2345540

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D89994: [libomptarget][nvptx] Undef, internal shared variables

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:2858 TransferMedium = new llvm::GlobalVariable( -M, Ty, /*isConstant=*/false, llvm::GlobalVariable::CommonLinkage, -llvm::Constant::getNullValue(Ty), TransferMediumName, +

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

dexonsmith created this revision. dexonsmith added reviewers: arphaman, JDevlieghere, teemperor. Herald added a subscriber: ributzka. dexonsmith requested review of this revision. Change the `InputFile` class to store a `MaybeFileEntryRef` instead of `FileEntry*`. This paged in a few API changes:

[PATCH] D90054: Added remotely ran compiler-rt tests.

aorlov created this revision. aorlov added reviewers: vvereschaka, broadwaylamb. aorlov added a project: LLVM. Herald added subscribers: cfe-commits, mgorny, dberris. Herald added a project: clang. aorlov requested review of this revision. Use LLVM/utils/remote-exec.py to run compiler-rt tests rem

[clang-tools-extra] 5dd3992 - [clangd] Fix remote-server build and add it to check-clangd

Author: Kadir Cetinkaya Date: 2020-10-23T18:08:02+02:00 New Revision: 5dd39923a09ec284d30083e5fadaa29e618d4446 URL: https://github.com/llvm/llvm-project/commit/5dd39923a09ec284d30083e5fadaa29e618d4446 DIFF: https://github.com/llvm/llvm-project/commit/5dd39923a09ec284d30083e5fadaa29e618d4446.dif

[PATCH] D90047: [clangd] Fix remote-server build and add it to check-clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dd39923a09e: [clangd] Fix remote-server build and add it to check-clangd (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90047/new/ h

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

steakhal added a comment. In D89987#2349959 , @ASDenysPetrov wrote: > @OikawaKirie > >> Different from ProgramStateRef which is an alias to IntrusiveRefCntPtr, or >> StoreRef which is a wrapper object, an alias to a const SymExpr * makes no >> sense to

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra added a comment. In D89832#2349915 , @emankov wrote: > I confirm that D89752 eliminates 47332 > on Windows. Tested against the > following CUDA versions: 7.0, 7,5, 9,2, 1

[PATCH] D89554: SourceManager: Clarify that FileInfo always has a ContentCache, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG74a878348021: SourceManager: Clarify that FileInfo always has a ContentCache, NFC (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89554?vs=298

[clang] 74a8783 - SourceManager: Clarify that FileInfo always has a ContentCache, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T12:38:53-04:00 New Revision: 74a8783480219f5f0e5c4673a6d0e29b4ad99877 URL: https://github.com/llvm/llvm-project/commit/74a8783480219f5f0e5c4673a6d0e29b4ad99877 DIFF: https://github.com/llvm/llvm-project/commit/74a8783480219f5f0e5c4673a6d0e29b4ad9

[PATCH] D89580: SourceManager: Fix an SLocEntry memory regression introduced with FileEntryRef

dexonsmith planned changes to this revision. dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:293 X.ContentAndKind.setInt(FileCharacter); - X.Filename = Filename; + const_cast(Con).Filename = Filename; return X; -

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:118 + private: +unsigned *Storage = nullptr; + }; JDevlieghere wrote: > I guess it's implicit in the implementation, but maybe it's worth adding a > comment describing

[clang] dbbc4f4 - SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

Author: Duncan P. N. Exon Smith Date: 2020-10-23T12:55:51-04:00 New Revision: dbbc4f4e226be44e484f448be2d308d205c81038 URL: https://github.com/llvm/llvm-project/commit/dbbc4f4e226be44e484f448be2d308d205c81038 DIFF: https://github.com/llvm/llvm-project/commit/dbbc4f4e226be44e484f448be2d308d205c8

[PATCH] D89913: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbbc4f4e226b: SourceManager: Encapsulate line number mapping into SrcMgr::LineOffsetMapping (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89

[clang] 65d2064 - [CUDA] Improve clang's ability to detect recent CUDA versions.

Author: Artem Belevich Date: 2020-10-23T10:03:29-07:00 New Revision: 65d206484c54177641d4b11d42cab1f1acc8c0c7 URL: https://github.com/llvm/llvm-project/commit/65d206484c54177641d4b11d42cab1f1acc8c0c7 DIFF: https://github.com/llvm/llvm-project/commit/65d206484c54177641d4b11d42cab1f1acc8c0c7.diff

[PATCH] D89752: [CUDA] Improve clang's ability to detect recent CUDA versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65d206484c54: [CUDA] Improve clang's ability to detect recent CUDA versions. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89752/new/ htt

[clang] e7fe125 - [CUDA] Extract CUDA version from cuda.h if version.txt is not found

Author: Artem Belevich Date: 2020-10-23T10:03:30-07:00 New Revision: e7fe125b776bf08d95e60ff3354a5c836218a0e6 URL: https://github.com/llvm/llvm-project/commit/e7fe125b776bf08d95e60ff3354a5c836218a0e6 DIFF: https://github.com/llvm/llvm-project/commit/e7fe125b776bf08d95e60ff3354a5c836218a0e6.diff

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. In D82756#2350233 , @jansvoboda11 wrote: > Correct me if I'm wrong, but when generating the command line, all "implied" > flags would be hidden, even if they were explicit in the original comand line: > > - original command li

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dexonsmith added a comment. IOW, the goal of formalizing would just be to: - error if the `.td` file defined options in the wrong order to get correct parsing - automatically generate the code for default value, instead of having to re-type the name of the keypath CHANGES SINCE LAST ACTION

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

dexonsmith added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088 + ID.Add(Range.getEnd()); + ID.Add(static_cast(Loc)); } I'm surprised you need this `static_cast`, can you explain why it was necessary? Repository: rG LLVM Github Mon

[PATCH] D89914: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG5431c37b55e2: SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache… (authored by dexonsmith). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D89

[clang] 5431c37 - SourceManager: Make LastLineNoContentCache and ContentCache::SourceLineCache mutable, NFC

Author: Duncan P. N. Exon Smith Date: 2020-10-23T13:22:47-04:00 New Revision: 5431c37b55e2c2952b6b56c9690bd1ce05b23c7e URL: https://github.com/llvm/llvm-project/commit/5431c37b55e2c2952b6b56c9690bd1ce05b23c7e DIFF: https://github.com/llvm/llvm-project/commit/5431c37b55e2c2952b6b56c9690bd1ce05b2

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448

[PATCH] D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef

NoQ added a comment. Honestly i'd rather eliminate `SymExpr` and go with `Symbol` everywhere. It's an overloaded term but appending "Expr" to it doesn't really make it significantly less overloaded. We're also properly namespaced so there wouldn't be any linking issues with the rest of LLVM. "S

[PATCH] D89982: [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks correct, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89982/new/ https://reviews.llvm.org/D89982 _

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

rjmccall added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:57 +Constant, // sycl_constant +Private, // sycl_private Generic, // ptr32_sptr I feel like we may be outgrowing these address-space map arrays. Comme

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

eduucaldas added a comment. Thanks Sam! I learned a lot from your patch ^^ Comment at: clang/include/clang/Tooling/Syntax/Tree.h:157-184 + /// Iterator over children (common base for const/non-const). + /// Not invalidated by tree mutations (holds a stable node pointer). + t

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

rjmccall added a comment. In D71726#2207700 , @yaxunl wrote: > clang does not always emit atomic instructions for atomic builtins. Clang may > emit lib calls for atomic builtins. Basically clang checks target info about > max atomic inline width and if t

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:154-155 + OldRounding = CGF.Builder.getDefaultConstrainedRounding(); if (OldFPFeatures == FPFeatures) return; sepavloff wrote: > This check can be lifted to just after the def

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

kpn added inline comments. Comment at: clang/test/CodeGen/aarch64-v8.2a-neon-intrinsics-constrained.c:26 +// metadata from the AST instead of the global default from the command line. +// FIXME: All cases of "fpexcept.maytrap" in this test are wrong. + kpn wrote:

[PATCH] D90063: [AIX] Also error on -G for link-only step

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, daltenty, jasonliu. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. Xiangling_L requested review of this revision. The change in [[ https://reviews.llvm.org/D89897 | [AI

  1   2   >