kadircet added a comment. I am not really keen about trusting ADL for these, as it makes the code less explicit for reader, especially as it is not something we commonly depend on clangd so readers/reviewers would not be expecting that. So I believe we should not stray away from the general project style in here.
Though I am a fan of not spelling `llvm::sys::path` bazillion times. What about having either a `using namepsace` for it or, using declarations for the individual symbols we are using (e.g. Style, covnert_to_slash and is_absolute)? This would also help with not spelling qualifiers over and over again in the argument names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90016/new/ https://reviews.llvm.org/D90016 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
