kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:30 +using llvm::sys::path::append; +using llvm::sys::path::convert_to_slash; ---------------- nit: I would move those into `clang::clangd::remote` (i.e. between `namespace remote {` and `namespace {`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90016/new/ https://reviews.llvm.org/D90016 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits