[PATCH] D88381: [Flang][Driver]Add PrintPreprocessedInput action `-E`

CarolineConcatto updated this revision to Diff 294612. CarolineConcatto added a comment. Remove -E from FlangOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381 Files: clang/include/clang/Driver/Optio

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

rsmith added inline comments. Comment at: clang/include/clang/AST/APValue.h:651-653 + /// The following functions are used as part of initialization. during + /// Deserialization and Importing. Reserve the space then write element + /// directly in place as after importing/des

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev updated this revision to Diff 294614. kbobyrev marked an inline comment as not done. kbobyrev added a comment. Update the patch. Still WIP, stash progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87831/new/ https://reviews.llvm.org/D

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX updated this revision to Diff 294616. ArcsinX added a comment. Use SourceManager::translateLineCol(), code simplifications. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87891/new/ https://reviews.llvm.org/D87891 Files: clang-tools-extra

[clang] bafdd11 - [SVE] Replace / operator in TypeSize/ElementCount with divideCoefficientBy

Author: David Sherwood Date: 2020-09-28T08:03:00+01:00 New Revision: bafdd11326a46421b68f68c794fd189c77a32e15 URL: https://github.com/llvm/llvm-project/commit/bafdd11326a46421b68f68c794fd189c77a32e15 DIFF: https://github.com/llvm/llvm-project/commit/bafdd11326a46421b68f68c794fd189c77a32e15.diff

[PATCH] D87700: [SVE] Replace / operator in TypeSize/ElementCount with divideCoefficientBy

This revision was automatically updated to reflect the committed changes. Closed by commit rGbafdd11326a4: [SVE] Replace / operator in TypeSize/ElementCount with divideCoefficientBy (authored by david-arm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to co

[PATCH] D87891: [clangd] findNearbyIdentifier(): guaranteed to give up after 2^N lines

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:589 // but not things like disabled preprocessor sections. if (!(tokenSpelledAt(Tok.location(), TB) || TB.expansionStartingAt(&Tok))) return false; here =

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov added a comment. In D87901#2296392 , @aganea wrote: > > Thanks for the patch! I'll let others review it, but I was just being > curious: what tool do you use for intercepting & printing `stat(` and > `openat(`? How can I repro locally? man

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov added a comment. @MaskRay Sure clang does not need to be installed and does not need to be beside GCC. But usually it is, and IMO this is the convenient setup for the most users who are not involved in development of clang itself and probably rely on tools installed as OS vendor's def

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

CarolineConcatto added a comment. Thank you @awarzynski for updating the patch. It looks good to me. I've build it locally and played a little bit. It works fine with gcc9.3. I did not try to build out-of-tree. But I don't see any reason it should not work. I have two minor comments. But besides

[PATCH] D88359: [analyzer][RFC] Complete rewrite of ArrayBoundCheckerV2

steakhal added a comment. In D88359#2297074 , @NoQ wrote: > So, `ArrayBoundCheckerV3` then? :D > We already have a similar simplification facility in `SValBuilder` created to > solve the similar problem with iterator checkers. It fires up when it knows

[PATCH] D87901: [Driver] Filter out /gcc and /gcc-cross if they do not exists

dmantipov updated this revision to Diff 294625. dmantipov added a comment. Initialize GCCDirExists and GCCCrossDirExists before calling ScanLibDirForGCCTriple(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

gamesh411 added a comment. Do you have some thoughts about this, should this be pursued, or do you think the use-case is not relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 __

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein updated this revision to Diff 294628. hokein added a comment. update the patch to fix another crash `ABC abc` where N's initailizer is contains-errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86048/new/ https://reviews.llvm.org/D86048

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein added inline comments. Comment at: clang/test/Sema/invalid-member.cpp:29 +}; +static_assert(sizeof(T) == 1, "No valid members"); The current fix (by invalidating the member decl) is probably suboptimal. The crash is caused by the fact that we escape the d

[PATCH] D87888: [X86] Use inlineasm flag output for the _bittest* intrinsics.

RKSimon added a comment. LGTM @rnk ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87888/new/ https://reviews.llvm.org/D87888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

bader added a comment. I'm okay with this change in general. One note though. There are two aspects of this change: 1. I agree that `cl-fp32-correctly-rounded-divide-sqrt` is OpenCL specific and nothing should not be added in other modes. 2. I have concerns WRT removing the attribute in OpenCL

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. This is really nice! We'd actually debated how to add such a feature, but had assumed it should be a "fix" rather than a "tweak" - I think this way is much better. Obviously making it f

[PATCH] D88312: "ErrorReturn checker" WIP review

balazske added a comment. Results for 'duckdb': link Repository:

[PATCH] D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl.

hokein updated this revision to Diff 294635. hokein marked an inline comment as done. hokein added a comment. Fix a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86765/new/ https://reviews.llvm.org/D86765 Files: clang/lib/Sema/SemaExpr.

[PATCH] D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl.

hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2584 +// Don't diagnose problems with invalid record decl, the no_member +// diagnostic is likely bogus, e.g. if a base specificer is invalid, the +// derived class is invalid, and has no base class

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I agree with the concerns about type T not being dependent, but don't have a good suggestion of where to draw the line (introducing dependence bits for Decl is obviously a big can of wor

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

sepavloff added a comment. In D87528#2295015 , @mibintc wrote: > I tried using the 0924 version of the patch on an internal workload SPEC > "cpu2017" and found that a few files failed to compile because of an error > message on static initializer, like t

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

hans added a comment. In D86091#2296576 , @mati865 wrote: > @hans sorry for not spotting it earlier but is it possible to still backport > it to LLVM 11? > It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 > repository. I'd pref

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo updated this revision to Diff 294644. tdeo added a comment. - Check body is empty instead of having no case statements. - Null check the return value from SwitchStmt::getCond. - Insert replacement before the right bracket instead of the left one, for future improvements. CHANGES SINCE LAST

[PATCH] D88174: [Sema] Address-space sensitive check for unbounded arrays (v2)

chrish_ericsson_atx added a comment. Ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88174/new/ https://reviews.llvm.org/D88174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo added a comment. @sammccall, I don't have commit access, so if this revision has no issues, can you land it? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88383/new/ https://reviews.llvm.org/D88383 ___ cfe-commits mailing list c

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG018066d9475d: [clangd] Add a tweak for filling in enumerators of a switch statement. (authored by tdeo, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang-tools-extra] 018066d - [clangd] Add a tweak for filling in enumerators of a switch statement.

Author: Tadeo Kondrak Date: 2020-09-28T13:37:18+02:00 New Revision: 018066d9475dac8d4b7a91bf967ea9231ff4b3f1 URL: https://github.com/llvm/llvm-project/commit/018066d9475dac8d4b7a91bf967ea9231ff4b3f1 DIFF: https://github.com/llvm/llvm-project/commit/018066d9475dac8d4b7a91bf967ea9231ff4b3f1.diff

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

sammccall added a comment. In D88383#2297735 , @tdeo wrote: > @sammccall, I don't have commit access, so if this revision has no issues, > can you land it? Thanks. Absolutely, thanks a lot for the patch! Any interest in extending to non-empty switches?

[PATCH] D88383: [clangd] Add a tweak for filling in enumerators of a switch statement.

tdeo added a comment. In D88383#2297778 , @sammccall wrote: > In D88383#2297735 , @tdeo wrote: > >> @sammccall, I don't have commit access, so if this revision has no issues, >> can you land it? Thanks. > > Absolut

[PATCH] D84306: [clang-format][NFC] Be more careful about the layout of FormatToken.

klimek added a comment. In D84306#2294952 , @MyDeveloperDay wrote: > Which bit do you find more complex? adding something to the FormatToken or > the use of the `is()` calls? I think mainly that a) the language doesn't support bitfields well yet, as ev

[PATCH] D82547: [VerifyDIPreserve] Expose original debuginfo preservation check as CC1 option

djtodoro updated this revision to Diff 294658. djtodoro added a comment. -Rebasing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82547/new/ https://reviews.llvm.org/D82547 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/include

[PATCH] D88403: Migrate Declarators to use the List API

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. After this change all nodes that have a delimited-list are using the `List` API. Implementation details: Let's look at a declaration with multiple

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa48f6079f288: [AArch64] Generate .note.gnu.property based on module flags. (authored by danielkiss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp:31 utils::IncludeSorter::IS_LLVM)), - MathHeader(Options.get("MathHeader", "math.h")) {} + MathHeader(Options

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

alexfh updated this revision to Diff 294666. alexfh marked 4 inline comments as done. alexfh added a comment. - clang-format - addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85666/new/ https://reviews.llvm.org/D85666 Files

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 created this revision. benshi001 added reviewers: dylanmckay, aykevl. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. benshi001 requested review of this revision. Improve avr-ld options for total 249 devices: 1. the argument of "-L" (device library sub path) 2

[PATCH] D88403: Migrate Declarators to use the List API

eduucaldas added a reviewer: gribozavr2. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:594 +/// Shrink \p Range to a subrange that only contains tokens of a list. +ArrayRef shrinkToFitList(ArrayRef Range) { + auto BeginChildren

[PATCH] D88410: [clang][AVR] Improve avr-ld command line options

benshi001 added a comment. For some devices, the library sub path "-L" and family name "-m" are not always equal. -L/usr/lib/avr/lib/XXX" "-L/usr/lib/gcc/avr/5.4.0/XXX" "-mYYY" XXX and YYY do not always equal to each other. But current clang/lib/Driver/ToolChains/AVR.cpp assumes they equal. Fo

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

mibintc added a comment. In D87528#2297647 , @sepavloff wrote: > In D87528#2295015 , @mibintc wrote: > >> I tried using the 0924 version of the patch on an internal workload SPEC >> "cpu2017" and found that a few f

[PATCH] D87279: [clang] Fix handling of physical registers in inline assembly operands.

jonpa added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87279/new/ https://reviews.llvm.org/D87279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

alexfh updated this revision to Diff 294678. alexfh added a comment. - Updated release notes and default option values in docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85666/new/ https://reviews.llvm.org/D85666 Files: clang-tools-extra/clan

[PATCH] D88312: "ErrorReturn checker" WIP review

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:505 + Report->markInteresting(CallSym); Report->addRange(CallLocation); C.emitReport(std::move(Report)); This still causes more harm then good

[PATCH] D88411: [clangd] Introduce MemoryTrees

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. A structure that can be used to rep

[clang] bf890dc - [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl.

Author: Haojian Wu Date: 2020-09-28T15:10:00+02:00 New Revision: bf890dcb0f5eb05b1a98cbd1cdd24c0c4ece8f8d URL: https://github.com/llvm/llvm-project/commit/bf890dcb0f5eb05b1a98cbd1cdd24c0c4ece8f8d DIFF: https://github.com/llvm/llvm-project/commit/bf890dcb0f5eb05b1a98cbd1cdd24c0c4ece8f8d.diff LO

[PATCH] D86765: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid record decl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf890dcb0f5e: [clang] Don't emit "no member" diagnostic if the lookup fails on an invalid… (authored by hokein). Repository: rG LLVM Github Monore

[PATCH] D85666: [clang-tidy] IncludeInserter: allow <> in header name

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdfe324da195: [clang-tidy] IncludeInserter: allow <> in header name (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85666/new/ https://r

[clang-tools-extra] fdfe324 - [clang-tidy] IncludeInserter: allow <> in header name

Author: Alexander Kornienko Date: 2020-09-28T15:14:04+02:00 New Revision: fdfe324da195ebd9b9c691f006b0d6ccc64365e1 URL: https://github.com/llvm/llvm-project/commit/fdfe324da195ebd9b9c691f006b0d6ccc64365e1 DIFF: https://github.com/llvm/llvm-project/commit/fdfe324da195ebd9b9c691f006b0d6ccc64365e1

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 updated this revision to Diff 294684. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88281/new/ https://reviews.llvm.org/D88281 Files: clang-tool

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 added a comment. If we just consider ranking, there are not many code paths. Most of the code paths are for gathering and creating code completion items. In the end all the code paths end up in the `addCandidate` method to get `scored` either by heuristics or by decision forest. So I h

[PATCH] D88413: [clangd] Add a metric for tracking memory usage

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo http

[PATCH] D88414: [clangd] Introduce memory dumping to FileIndex, FileSymbols and BackgroundIndex

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. File-granular information is considered det

[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

aaron.ballman added a comment. Multichar literals are implementation-defined in C and conditionally supported with implementation-defined semantics in C++. I agree that it may make sense to warn about their use for portability reasons, but I'm not certain whether it makes sense to promote their

[PATCH] D88415: [clangd] Introduce memory usage dumping to TUScheduler, for Preambles and ASTCache

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, javed.absar. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. File-granular information is c

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

adamcz accepted this revision. adamcz added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1635 +case RM::Heuristics: + Scores.Quality = Quality.evaluate(); + Scores.Relevance = Relevance.evaluate(); usaxena95 wrote: > adamcz

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.h:22 +/// preserving the hierarchy. +struct MemoryTree { +public: (I'm wondering if there are other resources we'd like to count, like disk size or so, but probably YAGNI an

[PATCH] D88411: [clangd] Introduce MemoryTrees

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/MemoryTree.cpp:28 +size_t ChildrenSize = 0; +for (const auto &C : Children) { + C.traverseTree(CollapseDetails, Here the detailed nodes are entirely collapsed. This isn't q

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

ye-luo added a comment. The minimal reproducer and full app work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88384/new/ https://reviews.llvm.org/D88384 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D88417: [clangd] Record memory usages after each notification

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Depends on D88415 Repository: rG LLVM Githu

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 updated this revision to Diff 294711. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added fixme for renaming evaluate() and fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88281/new/ https://reviews.llvm

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

aaron.ballman added a comment. Thank you for the changes, but do you know of any tests that are impacted by this? I'm not opposed to the proposed changes, but I am wondering -- the current behavior is that an empty output file (which can happen with especially egregious bugs) is always an error

[PATCH] D86790: [FE] Use preferred alignment instead of ABI alignment for complete object when applicable

jasonliu added inline comments. Comment at: clang/test/CodeGenCXX/aix-alignment.cpp:16 +// AIX64: %call = call noalias nonnull i8* @_Znam(i64 8) +B *allocBp() { return new B[0]; } + I believe we would also want to add a test for the delete call to verify the cha

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

ashi1 added a comment. Could you please add full context? Mostly looks good to me. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:243 - // Allow using target ID in --offload-arch. - StringRef GpuArch = translateTargetID(DriverArgs, CC1Args); + StringRef GpuArch = getGPUAr

[PATCH] D88384: [OpenMP][FIX] Verify compatible types for declare variant calls

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Change looks reasonable in itself too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88384/new/ https://reviews.llvm.org/D88384

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao updated this revision to Diff 294718. hliao added a comment. Split the original into 2. This is the first part, which add `correctly-rounded-device-sqrt-fp-math` for OpenCL only. The second part will remove that attribute annotating completely. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88303/new/ https://reviews.llvm.org/D88303 ___

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

baloghadamsoftware added inline comments. Comment at: clang/lib/Analysis/LiveVariables.cpp:522 - // FIXME: we should enqueue using post order. - for (const CFGBlock *B : cfg->nodes()) { + for (const CFGBlock *B : *AC.getAnalysis()) { worklist.enqueueBlock(B); --

[PATCH] D88424: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao created this revision. hliao added reviewers: bader, Anastasia, yaxunl. Herald added subscribers: cfe-commits, kerbowa, nhaehnle, jvesely. Herald added a project: clang. hliao requested review of this revision. - `-cl-fp32-correctly-rounded-divide-sqrt` is already handled in a per-instructi

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao added a comment. In D88303#2298259 , @bader wrote: > Thanks! Part 2 is submitted @ https://reviews.llvm.org/D88424 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88303/new/ https://reviews.llvm.org/D8

[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dbf80cad955: [clang][codegen] Annotate `correctly-rounded-divide-sqrt-fp-math` fn-attr for… (authored by hliao). Repository: rG LLVM Github Monor

[clang] 5dbf80c - [clang][codegen] Annotate `correctly-rounded-divide-sqrt-fp-math` fn-attr for OpenCL only.

Author: Michael Liao Date: 2020-09-28T11:40:32-04:00 New Revision: 5dbf80cad9556e222c4383960007fc0b27ea9541 URL: https://github.com/llvm/llvm-project/commit/5dbf80cad9556e222c4383960007fc0b27ea9541 DIFF: https://github.com/llvm/llvm-project/commit/5dbf80cad9556e222c4383960007fc0b27ea9541.diff

[PATCH] D87146: [analyzer] Implement shared semantics checks for XNU functions in PthreadLockChecker

ASDenysPetrov added a comment. @baloghadamsoftware > Sorry, absolutely no competence. That's OK. I've added a clarification section to the summary to make it easier to understand my intentions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87146/new/ https://reviews.llvm.org/D87146

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, jvesely, kzhuravl. yaxunl requested review of this revision. Herald added a subscriber: wdng. AMDGPU toolchain does not support -fPIE, therefore skip it if specified by

[PATCH] D88427: [clangd] Remove Tweak::Intent, use CodeAction kind directly

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Intent was a nice idea but it e

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

adamcz added a comment. Just noticed: typo in commit description - compeltions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88281/new/ https://reviews.llvm.org/D88281 ___ cfe-commits mailing list cfe-co

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

yaxunl updated this revision to Diff 294728. yaxunl added a comment. update patch with full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88377/new/ https://reviews.llvm.org/D88377 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/lib/Driver/ToolChains/AMDGPU.h clang/li

[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:243 - // Allow using target ID in --offload-arch. - StringRef GpuArch = translateTargetID(DriverArgs, CC1Args); + StringRef GpuArch = getGPUArch(DriverArgs)

[PATCH] D87282: [SYCL] Assume SYCL device functions are convergent

keryell added a comment. Be lazy Comment at: clang/test/CodeGenSYCL/convergent.cpp:18 +int main() { + kernel_single_task([]() { foo(); }); + return 0; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87282/new/

[PATCH] D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:875-876 "C++ standards before C++20">, InGroup, DefaultIgnore; +def err_anon_bitfield_member_init : Error< + "anonymous bit-field cannot have an in-class initializer">; def err

[PATCH] D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer

aaron.ballman updated this revision to Diff 294729. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88333/new/ https://reviews.llvm.org/D88333 Files: clang/include/clang/Bas

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2446 + fpOptions.isFPConstrained()) { +Info.CCEDiag(E, diag::note_constexpr_float_arithmetic_strict); +return false; FFDiag Comment at: clang/lib/AST/ExprCons

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

arsenm added inline comments. Comment at: clang/test/Driver/amdgpu-macros.cl:351 + +// GFX600-DAG: #define __amdgcn_wavefront_size 64 +// GFX601-DAG: #define __amdgcn_wavefront_size 64 Macros should be all caps CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D88071: [clangd] Add a trained DecisionForest for code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5f7e9e26cd0: [clangd] Add a trained DecisionForest for code completion. (authored by usaxena95). Changed prior to commit: https://reviews.llvm.org/D88071?vs=293346&id=294732#toc Repository: rG LLVM

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

arsenm added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.h:419 + +if (llvm::find(Features, "+wavefrontsize64") != Features.end()) + WavefrontSize = 64; Why is this not redundant with the features check? CHANGES SINCE LAST ACTION https

[PATCH] D86559: [Sema, CodeGen] Allow [[likely]] and [[unlikely]] on labels

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6454 +static bool validateLikelihoodAttr(Sema &S, Decl *D, const ParsedAttr &A) { + if (!isa(D)) { Mordante wrote: > aaron.ballman wrote: > > This is entering into somewhat novel

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

vsk added a comment. Thanks for the review! Comment at: clang/lib/CodeGen/CGExpr.cpp:1181 + if (T->isMemberPointerType()) +return CGM.getCXXABI().EmitMemberPointerIsNotNull( +*this, V, T->getAs()); ahatanak wrote: > You can fold `T->getAs()` into t

[PATCH] D88336: [ubsan] nullability-arg: Fix crash on C++ member function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06bc685fa240: [ubsan] nullability-arg: Fix crash on C++ member pointers (authored by vsk). Changed prior to commit: https://reviews.llvm.org/D8833

[clang] 06bc685 - [ubsan] nullability-arg: Fix crash on C++ member pointers

Author: Vedant Kumar Date: 2020-09-28T09:41:18-07:00 New Revision: 06bc685fa2400cc28282ab6dd3c917d45bfa662f URL: https://github.com/llvm/llvm-project/commit/06bc685fa2400cc28282ab6dd3c917d45bfa662f DIFF: https://github.com/llvm/llvm-project/commit/06bc685fa2400cc28282ab6dd3c917d45bfa662f.diff

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.h:419 + +if (llvm::find(Features, "+wavefrontsize64") != Features.end()) + WavefrontSize = 64; arsenm wrote: > Why is this not redundant wit

[PATCH] D88370: Emit predefined macro for wavefront size for amdgcn

yaxunl updated this revision to Diff 294734. yaxunl marked an inline comment as done. yaxunl added a comment. capitalize macro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88370/new/ https://reviews.llvm.org/D88370 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/

[PATCH] D88345: [CUDA] Allow local `static const {__constant__, __device__}` variables.

tra added a comment. In D88345#2296118 , @jlebar wrote: > wha... As you know, `const` doesn't mean anything, that can be const-casted > away. And then you'll be able to observe that this nominally-static variable > is just a normal variable. Yes, I'm a

[PATCH] D88425: Skip -fPIE for AMDGPU and HIP toolchain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Driver/hip-fpie-option.hip:34 + +// DEV-DAG: {{".*clang.*".* "-triple" "amdgcn-amd-amdhsa".* "-mrelocation-model" "pic" "-pic-level" "[1|2]" "-mframe-p

[clang-tools-extra] a8b55b6 - [clangd] Use Decision Forest to score code completions.

Author: Utkarsh Saxena Date: 2020-09-28T18:59:29+02:00 New Revision: a8b55b6939a5962d5b2bf1a57980562d6f3045e5 URL: https://github.com/llvm/llvm-project/commit/a8b55b6939a5962d5b2bf1a57980562d6f3045e5 DIFF: https://github.com/llvm/llvm-project/commit/a8b55b6939a5962d5b2bf1a57980562d6f3045e5.diff

[PATCH] D88281: [clangd] Use Decision Forest to score code completions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b55b6939a5: [clangd] Use Decision Forest to score code completions. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski marked 4 inline comments as done. awarzynski added a comment. In D87774#2293283 , @sameeranjoshi wrote: > Do you know if there are any bots configured to handle out-of-tree changes? > That might be helpful to avoid configuration differences and

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

awarzynski updated this revision to Diff 294740. awarzynski marked an inline comment as done. awarzynski added a comment. Address the remaining PR comments, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87774/new/ https://reviews.llvm.org/

[PATCH] D88424: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

hliao updated this revision to Diff 294745. hliao added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88424/new/ https://reviews.llvm.org/D88424 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenOpenCL/amdgpu-attrs.cl c

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, guansong, yaxunl. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. Replace the OpenMP Runtime Library

[PATCH] D87774: [flang] Introduce DiagnosticConsumer classes in libflangFrontend

kiranchandramohan added a subscriber: rovka. kiranchandramohan added a comment. In D87774#2298515 , @awarzynski wrote: > In D87774#2293283 , @sameeranjoshi > wrote: > >> Do you know if there are any bots configured

  1   2   3   >